presto 6641d589d5f6475d17883c30b2f9d67f0ff049c1

6641d589d5f6475d17883c30b2f9d67f0ff049c1

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 18

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	3
Move And Inline Method public assertOperatorEquals(operator Operator, input List<Page>, expected MaterializedResult) : void moved from class com.facebook.presto.operator.OperatorAssertion to class com.facebook.presto.operator.TestDistinctLimitOperator & inlined to public testDistinctLimit(hashEnabled boolean) : void	From	To
Move And Inline Method public assertOperatorEquals(operator Operator, input List<Page>, expected MaterializedResult) : void moved from class com.facebook.presto.operator.OperatorAssertion to class com.facebook.presto.operator.TestDistinctLimitOperator & inlined to public testDistinctLimitWithPageAlignment(hashEnabled boolean) : void	From	To
Move And Inline Method public assertOperatorEquals(operator Operator, input List<Page>, expected MaterializedResult) : void moved from class com.facebook.presto.operator.OperatorAssertion to class com.facebook.presto.operator.TestDistinctLimitOperator & inlined to public testDistinctLimitValuesLessThanLimit(hashEnabled boolean) : void	From	To
Change Parameter Type	3
Change Parameter Type operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEqualsIgnoreOrder(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannel Optional<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Change Parameter Type operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected List<Page>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Change Parameter Type operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannels List<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Rename Variable	1
Rename Variable factory : TopNOperatorFactory to operatorFactory : TopNOperatorFactory in method public testPartialMemoryFull() : void in class com.facebook.presto.operator.TestTopNOperator	From	To
Split Variable	1
Split Variable operator : Operator to [operatorFactory : TopNOperatorFactory, smallDiverContext : DriverContext] in method public testPartialMemoryFull() : void in class com.facebook.presto.operator.TestTopNOperator	From	To
Extract Method	2
Extract Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public assertOperatorEquals(operator Operator, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannels List<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Extract Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public assertOperatorEqualsIgnoreOrder(operator Operator, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannel Optional<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method	55
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testTopNRowNumberPartitioned(hashEnabled boolean) : void in class com.facebook.presto.operator.TestTopNRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testRowNumberArbitrary() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testMemoryLimit(hashEnabled boolean) : void in class com.facebook.presto.operator.TestHashAggregationOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testRowNumberPartitionedLimit(hashEnabled boolean) : void in class com.facebook.presto.operator.TestRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testMemoryLimit() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testSingleFieldKey() : void in class com.facebook.presto.operator.TestTopNOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testRowNumber() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testRowNumberUnpartitionedLimit() : void in class com.facebook.presto.operator.TestRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testPartialMemoryFull() : void in class com.facebook.presto.operator.TestTopNOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testRowNumberUnpartitioned() : void in class com.facebook.presto.operator.TestRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testMultiFieldKey() : void in class com.facebook.presto.operator.TestTopNOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testUnnestWithOrdinality() : void in class com.facebook.presto.operator.TestUnnestOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testMultiFieldKey() : void in class com.facebook.presto.operator.TestOrderByOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testNestedLoopJoin() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testLastValuePartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testReverseOrder() : void in class com.facebook.presto.operator.TestTopNOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testCrossJoinWithNullOnBothSides() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testEmptyProbePage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testTopNRowNumberUnPartitioned() : void in class com.facebook.presto.operator.TestTopNRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testEmptyBuildPage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testUnnestWithArray() : void in class com.facebook.presto.operator.TestUnnestOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testMemoryLimit() : void in class com.facebook.presto.operator.TestOrderByOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testUnnest() : void in class com.facebook.presto.operator.TestUnnestOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testRowNumberPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testPartiallyPreGroupedPartitionWithEmptyInput() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public test() : void in class com.facebook.presto.operator.TestFilterAndProjectOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEqualsIgnoreOrder(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testPartiallyPreGroupedPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testUnnestNonNumericDoubles() : void in class com.facebook.presto.operator.TestUnnestOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testAggregation() : void in class com.facebook.presto.operator.TestAggregationOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testProbeMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testSingleFieldKey() : void in class com.facebook.presto.operator.TestOrderByOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testLagPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testReverseOrder() : void in class com.facebook.presto.operator.TestOrderByOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testFirstValuePartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEqualsIgnoreOrder(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testFullyPreGroupedPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testLeadPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testCrossJoinWithNullProbe() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testRowNumberPartitioned(hashEnabled boolean) : void in class com.facebook.presto.operator.TestRowNumberOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testFullyPreGroupedAndFullySortedPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testProbeAndBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testCrossJoinWithNullBuild() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEqualsIgnoreOrder(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testFullyPreGroupedAndPartiallySortedPartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult) : void extracted from public testNthValuePartition() : void in class com.facebook.presto.operator.TestWindowOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testHashBuilderResizeLimit(hashEnabled boolean) : void in class com.facebook.presto.operator.TestHashAggregationOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Extract And Move Method public toPages(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>) : List<Page> extracted from public testHashBuilderResize(hashEnabled boolean) : void in class com.facebook.presto.operator.TestHashAggregationOperator & moved to class com.facebook.presto.operator.OperatorAssertion	From	To
Rename Parameter	3
Rename Parameter operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEqualsIgnoreOrder(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannel Optional<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Rename Parameter operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected List<Page>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To
Rename Parameter operator : Operator to operatorFactory : OperatorFactory in method public assertOperatorEquals(operatorFactory OperatorFactory, driverContext DriverContext, input List<Page>, expected MaterializedResult, hashEnabled boolean, hashChannels List<Integer>) : void in class com.facebook.presto.operator.OperatorAssertion	From	To

6641d589d5f6475d17883c30b2f9d67f0ff049c1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: