683d5423e80fcd429152079568dd9aa578faca4f
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public extractRegularColumnHandles(regularColumnMappings List<ColumnMapping>, doCoercion boolean) : List<HiveColumnHandle> renamed to public toColumnHandles(regularColumnMappings List<ColumnMapping>, doCoercion boolean) : List<HiveColumnHandle> in class com.facebook.presto.hive.HivePageSourceProvider.ColumnMapping | From | To | |
| Rename Method public extractRegularColumnMappings(columnMappings List<ColumnMapping>) : List<ColumnMapping> renamed to public extractRegularAndInterimColumnMappings(columnMappings List<ColumnMapping>) : List<ColumnMapping> in class com.facebook.presto.hive.HivePageSourceProvider.ColumnMapping | From | To | |
| Rename Variable | 2 | ||
| Rename Variable regularColumnMappings : List<ColumnMapping> to regularAndInterimColumnMappings : List<ColumnMapping> in method public createHivePageSource(cursorProviders Set<HiveRecordCursorProvider>, pageSourceFactories Set<HivePageSourceFactory>, configuration Configuration, session ConnectorSession, path Path, bucketNumber OptionalInt, start long, length long, fileSize long, schema Properties, effectivePredicate TupleDomain<HiveColumnHandle>, hiveColumns List<HiveColumnHandle>, partitionKeys List<HivePartitionKey>, hiveStorageTimeZone DateTimeZone, typeManager TypeManager, columnCoercions Map<Integer,HiveType>, bucketConversion Optional<BucketConversion>) : Optional<ConnectorPageSource> in class com.facebook.presto.hive.HivePageSourceProvider | From | To | |
| Rename Variable blocks : Block[] to adaptedBlocks : Block[] in method public getNextPage() : Page in class com.facebook.presto.hive.HivePageSource | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute bucketSplitInfo : Optional<BucketSplitInfo> to tableBucketInfo : Optional<BucketSplitInfo> in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To | |
| Extract Variable | 4 | ||
| Extract Variable partitionBucketColumns : List<String> in method private getPartitionMetadata(metastore SemiTransactionalHiveMetastore, table Table, tableName SchemaTableName, hivePartitions List<HivePartition>, bucketProperty Optional<HiveBucketProperty>) : Iterable<HivePartitionMetadata> from class com.facebook.presto.hive.HiveSplitManager | From | To | |
| Extract Variable partitionBucketCount : int in method private getPartitionMetadata(metastore SemiTransactionalHiveMetastore, table Table, tableName SchemaTableName, hivePartitions List<HivePartition>, bucketProperty Optional<HiveBucketProperty>) : Iterable<HivePartitionMetadata> from class com.facebook.presto.hive.HiveSplitManager | From | To | |
| Extract Variable tableBucketColumns : List<String> in method private getPartitionMetadata(metastore SemiTransactionalHiveMetastore, table Table, tableName SchemaTableName, hivePartitions List<HivePartition>, bucketProperty Optional<HiveBucketProperty>) : Iterable<HivePartitionMetadata> from class com.facebook.presto.hive.HiveSplitManager | From | To | |
| Extract Variable tableBucketCount : int in method private getPartitionMetadata(metastore SemiTransactionalHiveMetastore, table Table, tableName SchemaTableName, hivePartitions List<HivePartition>, bucketProperty Optional<HiveBucketProperty>) : Iterable<HivePartitionMetadata> from class com.facebook.presto.hive.HiveSplitManager | From | To | |
| Extract Method | 3 | ||
| Extract Method private testingPrincipalPrivilege(tableOwner String) : PrincipalPrivileges extracted from protected doTestMismatchSchemaTable(schemaTableName SchemaTableName, storageFormat HiveStorageFormat, tableBefore List<ColumnMetadata>, dataBefore MaterializedResult, tableAfter List<ColumnMetadata>, dataAfter MaterializedResult) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Method private createEmptyTable(schemaTableName SchemaTableName, hiveStorageFormat HiveStorageFormat, columns List<Column>, partitionColumns List<Column>, bucketProperty Optional<HiveBucketProperty>) : void extracted from protected createEmptyTable(schemaTableName SchemaTableName, hiveStorageFormat HiveStorageFormat, columns List<Column>, partitionColumns List<Column>) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Method private testingPrincipalPrivilege(tableOwner String) : PrincipalPrivileges extracted from protected createEmptyTable(schemaTableName SchemaTableName, hiveStorageFormat HiveStorageFormat, columns List<Column>, partitionColumns List<Column>) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Inline Variable | 1 | ||
| Inline Variable coercedBlock : Block in method public load(lazyBlock LazyBlock) : void from class com.facebook.presto.hive.HivePageSource.CoercionLazyBlockLoader | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter bucketSplitInfo : Optional<BucketSplitInfo> to tableBucketInfo : Optional<BucketSplitInfo> in method public BackgroundHiveSplitLoader(table Table, partitions Iterable<HivePartitionMetadata>, compactEffectivePredicate TupleDomain<? extends ColumnHandle>, tableBucketInfo Optional<BucketSplitInfo>, session ConnectorSession, hdfsEnvironment HdfsEnvironment, namenodeStats NamenodeStats, directoryLister DirectoryLister, executor Executor, loaderConcurrency int, recursiveDirWalkerEnabled boolean) in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To |