72ce7a496615f07a671b9e2c9be092eea123791e
Files Diff
- Added: 10
- Removed: 3
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type summarizedPartition : SummarizedPartition to tableLayout : Optional<TableLayoutHandle> in method public TableScanNode(id PlanNodeId, table TableHandle, outputs List<Symbol>, assignments Map<Symbol,ColumnHandle>, tableLayout Optional<TableLayoutHandle>, currentConstraint TupleDomain<ColumnHandle>, originalConstraint Expression) in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Change Parameter Type tableHandle : TableHandle to handle : TableLayoutHandle in method private getLocalQuerySplit(handle TableLayoutHandle) : Split in class com.facebook.presto.testing.LocalQueryRunner | From | To | |
| Change Parameter Type handle : TableHandle to connectorId : String in method public getConnectorSplitManager(connectorId String) : ConnectorSplitManager in class com.facebook.presto.split.SplitManager | From | To | |
| Rename Variable | 7 | ||
| Rename Variable partition : Partition to domain : TupleDomain<ColumnHandle> in method public visitAggregation(node AggregationNode, context RewriteContext<Void>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.MetadataQueryOptimizer.Optimizer | From | To | |
| Rename Variable partitionsDomainSummary : TupleDomain<ColumnHandle> to constraint : TupleDomain<ColumnHandle> in method public visitTableScan(node TableScanNode, context Void) : Void in class com.facebook.presto.util.JsonPlanPrinter.SourceVisitor | From | To | |
| Rename Variable partitions : List<Partition> to layout : TableLayout in method public visitAggregation(node AggregationNode, context RewriteContext<Void>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.MetadataQueryOptimizer.Optimizer | From | To | |
| Rename Variable tupleDomain : TupleDomain<ColumnHandle> to constraint : TupleDomain<ColumnHandle> in method private planTableScan(node TableScanNode, predicate Expression, context Context) : PlanNode in class com.facebook.presto.sql.planner.optimizations.IndexJoinOptimizer.IndexSourceRewriter | From | To | |
| Rename Variable entry : Map.Entry<Symbol,ColumnHandle> to assignment : Map.Entry<Symbol,ColumnHandle> in method public visitTableScan(node TableScanNode, indent Integer) : Void in class com.facebook.presto.sql.planner.PlanPrinter.Visitor | From | To | |
| Rename Variable partitionsDomainSummary : TupleDomain<ColumnHandle> to constraint : TupleDomain<ColumnHandle> in method public visitTableScan(node TableScanNode, indent Integer) : Void in class com.facebook.presto.sql.planner.PlanPrinter.Visitor | From | To | |
| Rename Variable originalConstraint : Expression to predicate : Expression in method public visitTableScan(node TableScanNode, context RewriteContext<Expression>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.PredicatePushDown.Rewriter | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute partitionsDroppedBySerialization : boolean to currentConstraint : TupleDomain<ColumnHandle> in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Rename Attribute summarizedPartition : SummarizedPartition to tableLayout : Optional<TableLayoutHandle> in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type partitions : List<Partition> to layout : TableLayout in method public visitAggregation(node AggregationNode, context RewriteContext<Void>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.MetadataQueryOptimizer.Optimizer | From | To | |
| Change Variable Type outputs : Set<Symbol> to outputs : Set<ColumnHandle> in method public visitTableScan(node TableScanNode, indent Integer) : Void in class com.facebook.presto.sql.planner.PlanPrinter.Visitor | From | To | |
| Change Variable Type partition : Partition to domain : TupleDomain<ColumnHandle> in method public visitAggregation(node AggregationNode, context RewriteContext<Void>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.MetadataQueryOptimizer.Optimizer | From | To | |
| Extract Variable | 2 | ||
| Extract Variable table : TableHandle in method public visitTableScan(node TableScanNode, indent Integer) : Void from class com.facebook.presto.sql.planner.PlanPrinter.Visitor | From | To | |
| Extract Variable column : ColumnHandle in method public visitTableScan(node TableScanNode, indent Integer) : Void from class com.facebook.presto.sql.planner.PlanPrinter.Visitor | From | To | |
| Inline Variable | 2 | ||
| Inline Variable requiredAssignmentSymbols : Set<Symbol> in method public visitTableScan(node TableScanNode, context RewriteContext<Set<Symbol>>) : PlanNode from class com.facebook.presto.sql.planner.optimizations.PruneUnreferencedOutputs.Rewriter | From | To | |
| Inline Variable output : PlanNode in method public visitTableScan(node TableScanNode, context RewriteContext<Expression>) : PlanNode from class com.facebook.presto.sql.planner.optimizations.PredicatePushDown.Rewriter | From | To | |
| Extract Method | 1 | ||
| Extract Method private planTableScan(node TableScanNode, predicate Expression, context Context) : PlanNode extracted from public visitTableScan(node TableScanNode, context RewriteContext<Context>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.IndexJoinOptimizer.IndexSourceRewriter | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type bindings : Map<Symbol,Object> to bindings : Map<ColumnHandle,?> in class com.facebook.presto.sql.planner.LookupSymbolResolver | From | To | |
| Change Attribute Type summarizedPartition : SummarizedPartition to tableLayout : Optional<TableLayoutHandle> in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Change Attribute Type partitionsDroppedBySerialization : boolean to currentConstraint : TupleDomain<ColumnHandle> in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method private printConstraint(indent int, table TableHandle, column ColumnHandle, constraint TupleDomain<ColumnHandle>) : void extracted from public visitTableScan(node TableScanNode, indent Integer) : Void in class com.facebook.presto.sql.planner.PlanPrinter.Visitor & moved to class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter tableHandle : TableHandle to handle : TableLayoutHandle in method private getLocalQuerySplit(handle TableLayoutHandle) : Split in class com.facebook.presto.testing.LocalQueryRunner | From | To | |
| Rename Parameter outputSymbols : List<Symbol> to outputs : List<Symbol> in method public TableScanNode(id PlanNodeId, table TableHandle, outputs List<Symbol>, assignments Map<Symbol,ColumnHandle>, tableLayout Optional<TableLayoutHandle>, currentConstraint TupleDomain<ColumnHandle>, originalConstraint Expression) in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To | |
| Rename Parameter handle : TableHandle to connectorId : String in method public getConnectorSplitManager(connectorId String) : ConnectorSplitManager in class com.facebook.presto.split.SplitManager | From | To | |
| Rename Parameter summarizedPartition : SummarizedPartition to tableLayout : Optional<TableLayoutHandle> in method public TableScanNode(id PlanNodeId, table TableHandle, outputs List<Symbol>, assignments Map<Symbol,ColumnHandle>, tableLayout Optional<TableLayoutHandle>, currentConstraint TupleDomain<ColumnHandle>, originalConstraint Expression) in class com.facebook.presto.sql.planner.plan.TableScanNode | From | To |