731308072e0957186b0658f398a68cdb9c83606e
Files Diff
- Added: 0
- Removed: 2
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type lookupSourceFactory : SettableLookupSourceFactory to lookupSourceFactory : PartitionedLookupSourceFactory in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceFactory PartitionedLookupSourceFactory, partitionIndex int, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Method | 1 | ||
| Move Method public isBlocked() : ListenableFuture<?> from class com.facebook.presto.operator.ParallelHashBuildOperator to public isBlocked() : ListenableFuture<?> from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Variable | 3 | ||
| Rename Variable supplier : Supplier<LookupSource> to partition : Supplier<LookupSource> in method public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Variable driver : Driver to hashBuildDriver : Driver in method protected createDrivers(taskContext TaskContext) : List<Driver> in class com.facebook.presto.benchmark.HashBuildBenchmark | From | To | |
| Rename Variable driverFactory : DriverFactory to hashBuildDriverFactory : DriverFactory in method protected createDrivers(taskContext TaskContext) : List<Driver> in class com.facebook.presto.benchmark.HashBuildBenchmark | From | To | |
| Move Attribute | 8 | ||
| Move Attribute private finishing : boolean from class com.facebook.presto.operator.ParallelHashBuildOperator to private finishing : boolean from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private partitionIndex : int from class com.facebook.presto.operator.ParallelHashBuildOperator to private partitionIndex : int from class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Move Attribute private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory to private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.ParallelHashBuildOperator to private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private index : PagesIndex from class com.facebook.presto.operator.ParallelHashBuildOperator to private index : PagesIndex from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private partitionIndex : int from class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory to private partitionIndex : int from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private partitionIndex : int from class com.facebook.presto.operator.ParallelHashBuildOperator to private partitionIndex : int from class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Move Attribute private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.ParallelHashBuildOperator to private preComputedHashChannel : Optional<Integer> from class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute hashChannel : Optional<Integer> to preComputedHashChannel : Optional<Integer> in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Rename Attribute pagesIndex : PagesIndex to index : PagesIndex in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Attribute finished : boolean to finishing : boolean in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type hashBuilderOperatorFactory : ParallelHashBuildOperatorFactory to hashBuilderOperatorFactory : HashBuilderOperatorFactory in method private createLookupSourceFactory(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Inline Variable | 1 | ||
| Inline Variable operatorFactory : OperatorFactory in method private createLookupSourceFactory(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceFactory from class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type lookupSourceFactory : SettableLookupSourceFactory to lookupSourceFactory : PartitionedLookupSourceFactory in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Change Attribute Type lookupSourceFactory : SettableLookupSourceFactory to lookupSourceFactory : PartitionedLookupSourceFactory in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter hashChannel : Optional<Integer> to preComputedHashChannel : Optional<Integer> in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceFactory PartitionedLookupSourceFactory, partitionIndex int, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Parameter hashChannel : Optional<Integer> to preComputedHashChannel : Optional<Integer> in method public HashBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, layout Map<Symbol,Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int, partitionCount int) in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To |