7cd7cd1b2918e1833d2cce9a700f7c4af4c303cf
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public getWallTime() : Duration renamed to public getPlanNodeWallTime() : Duration in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Method public getInputPositions() : long renamed to public getPlanNodeInputPositions() : long in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Method public getOutputPositions() : long renamed to public getPlanNodeOutputPositions() : long in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Method public getOutputDataSize() : DataSize renamed to public getPlanNodeOutputDataSize() : DataSize in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Method public getInputDataSize() : DataSize renamed to public getPlanNodeInputDataSize() : DataSize in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type joinHashSupplierClass : Class<? extends Supplier> to joinHashSupplierClass : Class<? extends LookupSourceSupplier> in method public LookupSourceSupplierFactory(joinHashSupplierClass Class<? extends LookupSourceSupplier>, pagesHashStrategyFactory PagesHashStrategyFactory) in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Rename Variable | 7 | ||
| Rename Variable outputBytes : Map<PlanNodeId,Long> to planNodeOutputBytes : Map<PlanNodeId,Long> in method private getPlanNodeStats(taskStats TaskStats) : List<PlanNodeStats> in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Variable inputPositions : Map<PlanNodeId,Long> to planNodeInputPositions : Map<PlanNodeId,Long> in method private getPlanNodeStats(taskStats TaskStats) : List<PlanNodeStats> in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Variable outputPositions : Map<PlanNodeId,Long> to planNodeOutputPositions : Map<PlanNodeId,Long> in method private getPlanNodeStats(taskStats TaskStats) : List<PlanNodeStats> in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Variable inputBytes : Map<PlanNodeId,Long> to planNodeInputBytes : Map<PlanNodeId,Long> in method private getPlanNodeStats(taskStats TaskStats) : List<PlanNodeStats> in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Variable wallMillis : Map<PlanNodeId,Long> to planNodeWallMillis : Map<PlanNodeId,Long> in method private getPlanNodeStats(taskStats TaskStats) : List<PlanNodeStats> in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Rename Variable outputPositions : long to planNodeOutputPositions : long in method public merge(planNodeStats1 PlanNodeStats, planNodeStats2 PlanNodeStats) : PlanNodeStats in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Variable inputDataSize : DataSize to planNodeInputDataSize : DataSize in method public merge(planNodeStats1 PlanNodeStats, planNodeStats2 PlanNodeStats) : PlanNodeStats in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Supplier<LookupSource> to LookupSourceSupplier in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Return Type Supplier<LookupSource> to LookupSourceSupplier in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, outputChannels Optional<List<Integer>>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Return Type Supplier<LookupSource> to LookupSourceSupplier in method public createLookupSourceSupplier(session ConnectorSession, addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private inputPositions : long from class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats to private inputPositions : long from class com.facebook.presto.sql.planner.PlanPrinter.OperatorInputStats | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute hashSize : int to hashCapacity : int in method public MultiChannelGroupByHash(hashTypes List<? extends Type>, hashChannels int[], inputHashChannel Optional<Integer>, expectedSize int, processDictionary boolean) in class com.facebook.presto.operator.MultiChannelGroupByHash | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute outputDataSize : DataSize to operatorHashCollisionsStats : Map<String,OperatorHashCollisionsStats> in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Attribute wallTime : Duration to planNodeWallTime : Duration in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Attribute inputDataSize : DataSize to operatorInputStats : Map<String,OperatorInputStats> in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Attribute inputPositions : long to planNodeInputPositions : long in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Attribute outputPositions : long to planNodeOutputPositions : long in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Split Variable | 1 | ||
| Split Variable inputPositions : long to [planNodeInputPositions : long, planNodeOutputDataSize : DataSize, operatorInputStats : Map<String,OperatorInputStats>] in method public merge(planNodeStats1 PlanNodeStats, planNodeStats2 PlanNodeStats) : PlanNodeStats in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type partition : Supplier<LookupSource> to partition : LookupSourceSupplier in method public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Change Variable Type joinHashSupplierClass : Class<? extends Supplier> to joinHashSupplierClass : Class<? extends LookupSourceSupplier> in method private internalCompileLookupSourceFactory(types List<Type>, outputChannels List<Integer>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Extract Method | 1 | ||
| Extract Method private formatDouble(value double) : String extracted from private printStats(indent int, planNodeId PlanNodeId, printInput boolean, printFiltered boolean) : void in class com.facebook.presto.sql.planner.PlanPrinter | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type constructor : Constructor<? extends Supplier> to constructor : Constructor<? extends LookupSourceSupplier> in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Change Attribute Type outputDataSize : DataSize to operatorHashCollisionsStats : Map<String,OperatorHashCollisionsStats> in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Change Attribute Type inputDataSize : DataSize to operatorInputStats : Map<String,OperatorInputStats> in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter wallTime : Duration to planNodeWallTime : Duration in method private PlanNodeStats(planNodeId PlanNodeId, planNodeWallTime Duration, planNodeInputPositions long, planNodeInputDataSize DataSize, planNodeOutputPositions long, planNodeOutputDataSize DataSize, operatorInputStats Map<String,OperatorInputStats>, operatorHashCollisionsStats Map<String,OperatorHashCollisionsStats>) in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Parameter inputPositions : long to planNodeInputPositions : long in method private PlanNodeStats(planNodeId PlanNodeId, planNodeWallTime Duration, planNodeInputPositions long, planNodeInputDataSize DataSize, planNodeOutputPositions long, planNodeOutputDataSize DataSize, operatorInputStats Map<String,OperatorInputStats>, operatorHashCollisionsStats Map<String,OperatorHashCollisionsStats>) in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To | |
| Rename Parameter outputPositions : long to planNodeOutputPositions : long in method private PlanNodeStats(planNodeId PlanNodeId, planNodeWallTime Duration, planNodeInputPositions long, planNodeInputDataSize DataSize, planNodeOutputPositions long, planNodeOutputDataSize DataSize, operatorInputStats Map<String,OperatorInputStats>, operatorHashCollisionsStats Map<String,OperatorHashCollisionsStats>) in class com.facebook.presto.sql.planner.PlanPrinter.PlanNodeStats | From | To |