7ea3cd53c6df03c28b8da94f25f369ab2c52ed52
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type sqlParser : SqlParser to queryPreparer : QueryPreparer in method public SqlQueryManager(queryPreparer QueryPreparer, embedVersion EmbedVersion, nodeSchedulerConfig NodeSchedulerConfig, queryManagerConfig QueryManagerConfig, sqlEnvironmentConfig SqlEnvironmentConfig, queryMonitor QueryMonitor, resourceGroupManager ResourceGroupManager<?>, memoryManager ClusterMemoryManager, locationFactory LocationFactory, transactionManager TransactionManager, queryIdGenerator QueryIdGenerator, sessionSupplier SessionSupplier, sessionPropertyDefaults SessionPropertyDefaults, internalNodeManager InternalNodeManager, executionFactories Map<Class<? extends Statement>,QueryExecutionFactory<?>>, metadata Metadata, warningCollectorFactory WarningCollectorFactory) in class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Move Method | 2 | ||
| Move Method public validateParameters(node Statement, parameterValues List<Expression>) : void from class com.facebook.presto.execution.SqlQueryManager to private validateParameters(node Statement, parameterValues List<Expression>) : void from class com.facebook.presto.execution.QueryPreparer | From | To | |
| Move Method public unwrapExecuteStatement(statement Statement, sqlParser SqlParser, session Session) : Statement from class com.facebook.presto.execution.SqlQueryManager to private unwrapExecuteStatement(statement Statement, sqlParser SqlParser, session Session) : Statement from class com.facebook.presto.execution.QueryPreparer | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private sqlParser : SqlParser from class com.facebook.presto.execution.SqlQueryManager to private sqlParser : SqlParser from class com.facebook.presto.execution.QueryPreparer | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.execution.QueryPreparer from class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Rename Class | 1 | ||
| Rename Class com.facebook.presto.execution.TestUnwrapExecute renamed to com.facebook.presto.execution.TestQueryPreparer | From | To | |
| Merge Variable | 2 | ||
| Merge Variable [statement : Statement, parameters : List<Expression>] to preparedQuery : PreparedQuery in method private createQueryInternal(queryId QueryId, sessionContext SessionContext, query String, resourceGroupManager ResourceGroupManager<C>) : void in class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Merge Variable [statement : Statement, parameters : List<Expression>] to preparedQuery : PreparedQuery in method private getQueryPlan(node Explain, planType ExplainType.Type, planFormat ExplainFormat.Type) : Node in class com.facebook.presto.sql.rewrite.ExplainRewrite.Visitor | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute sqlParser : SqlParser to queryPreparer : QueryPreparer in class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type sqlParser : SqlParser to queryPreparer : QueryPreparer in class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Inline Variable | 2 | ||
| Inline Variable self : URI in method private createQueryInternal(queryId QueryId, sessionContext SessionContext, query String, resourceGroupManager ResourceGroupManager<C>) : void from class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Inline Variable innerStatement : Statement in method private createQueryInternal(queryId QueryId, sessionContext SessionContext, query String, resourceGroupManager ResourceGroupManager<C>) : void from class com.facebook.presto.execution.SqlQueryManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter sqlParser : SqlParser to queryPreparer : QueryPreparer in method public SqlQueryManager(queryPreparer QueryPreparer, embedVersion EmbedVersion, nodeSchedulerConfig NodeSchedulerConfig, queryManagerConfig QueryManagerConfig, sqlEnvironmentConfig SqlEnvironmentConfig, queryMonitor QueryMonitor, resourceGroupManager ResourceGroupManager<?>, memoryManager ClusterMemoryManager, locationFactory LocationFactory, transactionManager TransactionManager, queryIdGenerator QueryIdGenerator, sessionSupplier SessionSupplier, sessionPropertyDefaults SessionPropertyDefaults, internalNodeManager InternalNodeManager, executionFactories Map<Class<? extends Statement>,QueryExecutionFactory<?>>, metadata Metadata, warningCollectorFactory WarningCollectorFactory) in class com.facebook.presto.execution.SqlQueryManager | From | To |