presto 84610e989fcd56afc5369f112a4bb956ee8e1aa6

84610e989fcd56afc5369f112a4bb956ee8e1aa6

Files Diff

Added: 1
Removed: 1
Renamed: 0
Modified: 16

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private newSelectionContext(user String, source String, tags Set<String>) : SelectionContext renamed to private newSelectionCritera(user String, source String, tags Set<String>) : SelectionCriteria in class com.facebook.presto.resourceGroups.TestStaticSelector	From	To
Change Parameter Type	16
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.StaticSelector	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.resourceGroups.FileResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to context : SelectionCriteria in method public expandTemplate(context SelectionCriteria) : ResourceGroupId in class com.facebook.presto.resourceGroups.ResourceGroupIdTemplate	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.spi.resourceGroups.ResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.ResourceGroupSelector	From	To
Change Parameter Type context : SelectionContext to context : SelectionCriteria in method private tryMatch(selectors List<ResourceGroupSelector>, context SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.TestFileResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to context : SelectionCriteria in method private assertMatch(selectors List<ResourceGroupSelector>, context SelectionCriteria, expectedResourceGroup String) : void in class com.facebook.presto.resourceGroups.TestFileResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.execution.resourceGroups.LegacyResourceGroupConfigurationManagerFactory.LegacyResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to context : SelectionCriteria in method public expandTemplate(context SelectionCriteria) : String in class com.facebook.presto.resourceGroups.ResourceGroupNameTemplate	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.db.DbResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.FileResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.spi.resourceGroups.ResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to context : SelectionCriteria in method protected getMatchingSpec(group ResourceGroup, context SelectionCriteria) : Map.Entry<ResourceGroupIdTemplate,ResourceGroupSpec> in class com.facebook.presto.resourceGroups.AbstractResourceConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.db.DbSourceExactMatchSelector	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.execution.resourceGroups.LegacyResourceGroupConfigurationManagerFactory.LegacyResourceGroupConfigurationManager	From	To
Change Parameter Type context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.resourceGroups.db.DbResourceGroupConfigurationManager	From	To
Change Return Type	1
Change Return Type SelectionContext to SelectionCriteria in method private newSelectionCritera(user String, source String, tags Set<String>) : SelectionCriteria in class com.facebook.presto.resourceGroups.TestStaticSelector	From	To
Rename Class	1
Rename Class com.facebook.presto.spi.resourceGroups.SelectionContext renamed to com.facebook.presto.spi.resourceGroups.SelectionCriteria	From	To
Change Variable Type	2
Change Variable Type context : SelectionContext to context : SelectionCriteria in method private createGroupIfNecessary(id ResourceGroupId, queryExecution QueryExecution, executor Executor) : void in class com.facebook.presto.execution.resourceGroups.InternalResourceGroupManager	From	To
Change Variable Type context : SelectionContext to context : SelectionCriteria in method private selectGroup(queryExecution QueryExecution) : ResourceGroupId in class com.facebook.presto.execution.resourceGroups.InternalResourceGroupManager	From	To
Rename Parameter	11
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.StaticSelector	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.db.DbResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.resourceGroups.FileResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.FileResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.spi.resourceGroups.ResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.spi.resourceGroups.ResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.ResourceGroupSelector	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.resourceGroups.db.DbSourceExactMatchSelector	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public match(criteria SelectionCriteria) : Optional<ResourceGroupId> in class com.facebook.presto.execution.resourceGroups.LegacyResourceGroupConfigurationManagerFactory.LegacyResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.execution.resourceGroups.LegacyResourceGroupConfigurationManagerFactory.LegacyResourceGroupConfigurationManager	From	To
Rename Parameter context : SelectionContext to criteria : SelectionCriteria in method public configure(group ResourceGroup, criteria SelectionCriteria) : void in class com.facebook.presto.resourceGroups.db.DbResourceGroupConfigurationManager	From	To

84610e989fcd56afc5369f112a4bb956ee8e1aa6

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: