8548ba813f2d426911062e59efa079ed296d44a6
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [groupingSetChannels : List<List<Integer>>, groupingChannels : List<Integer>, copyChannels : List<Integer>] to groupingSetMappings : List<Map<Integer,Integer>> in class com.facebook.presto.operator.GroupIdOperator.GroupIdOperatorFactory | From | To | |
| Rename Method | 1 | ||
| Rename Method public getIdentityMappings() : Map<Symbol,Symbol> renamed to public getArgumentMappings() : Map<Symbol,Symbol> in class com.facebook.presto.sql.planner.plan.GroupIdNode | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type groupingSetChannels : List<List<Integer>> to groupingSetMappings : List<Map<Integer,Integer>> in method public GroupIdOperatorFactory(operatorId int, planNodeId PlanNodeId, outputTypes List<? extends Type>, groupingSetMappings List<Map<Integer,Integer>>) in class com.facebook.presto.operator.GroupIdOperator.GroupIdOperatorFactory | From | To | |
| Rename Variable | 6 | ||
| Rename Variable translations : TranslationMap to aggregationTranslations : TranslationMap in method private aggregate(subPlan PlanBuilder, node QuerySpecification) : PlanBuilder in class com.facebook.presto.sql.planner.QueryPlanner | From | To | |
| Rename Variable identityMapping : Map<Symbol,Symbol> to newArgumentMappings : Map<Symbol,Symbol> in method public visitGroupId(node GroupIdNode, context RewriteContext<Set<Symbol>>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.PruneUnreferencedOutputs.Rewriter | From | To | |
| Rename Variable inputSymbol : Symbol to output : Symbol in method public visitGroupId(node GroupIdNode, context RewriteContext<Void>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.UnaliasSymbolReferences.Rewriter | From | To | |
| Rename Variable output : PlanNode to rewrittenNode : PlanNode in method public visitGroupId(node GroupIdNode, context RewriteContext<Expression>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.PredicatePushDown.Rewriter | From | To | |
| Rename Variable groupingSets : List<String> to inputGroupingSetSymbols : List<String> in method public visitGroupId(node GroupIdNode, context Void) : Void in class com.facebook.presto.util.GraphvizPrinter.NodePrinter | From | To | |
| Rename Variable identityMappingBuilder : ImmutableMap.Builder<Symbol,Symbol> to expectedInputs : ImmutableSet.Builder<Symbol> in method public visitGroupId(node GroupIdNode, context RewriteContext<Set<Symbol>>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.PruneUnreferencedOutputs.Rewriter | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<Symbol> to Set<Symbol> in method public getCommonGroupingColumns() : Set<Symbol> in class com.facebook.presto.sql.planner.plan.GroupIdNode | From | To | |
| Merge Variable | 2 | ||
| Merge Variable [groupingSetChannels : List<List<Integer>>, groupingChannels : ImmutableList.Builder<Integer>] to mappings : ImmutableList.Builder<Map<Integer,Integer>> in method public visitGroupId(node GroupIdNode, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Merge Variable [groupingSetNullChannels : BitSet[], groupInputs : int[], copyInputs : int[]] to groupingSetInputs : int[][] in method public createOperator(driverContext DriverContext) : Operator in class com.facebook.presto.operator.GroupIdOperator.GroupIdOperatorFactory | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute identityMappings : Map<Symbol,Symbol> to argumentMappings : Map<Symbol,Symbol> in class com.facebook.presto.sql.planner.plan.GroupIdNode | From | To | |
| Extract Variable | 1 | ||
| Extract Variable canonicalOutput : Symbol in method public visitGroupId(node GroupIdNode, context RewriteContext<Void>) : PlanNode from class com.facebook.presto.sql.planner.optimizations.UnaliasSymbolReferences.Rewriter | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type identityMappingBuilder : ImmutableMap.Builder<Symbol,Symbol> to expectedInputs : ImmutableSet.Builder<Symbol> in method public visitGroupId(node GroupIdNode, context RewriteContext<Set<Symbol>>) : PlanNode in class com.facebook.presto.sql.planner.optimizations.PruneUnreferencedOutputs.Rewriter | From | To | |
| Inline Variable | 1 | ||
| Inline Variable commonGroupingColumns : List<Symbol> in method private translateGroupIdSymbols(node GroupIdNode) : Function<Symbol,Optional<Symbol>> from class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type groupingSetChannels : List<List<Integer>> to groupingSetMappings : List<Map<Integer,Integer>> in class com.facebook.presto.operator.GroupIdOperator.GroupIdOperatorFactory | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter groupingSetChannels : List<List<Integer>> to groupingSetMappings : List<Map<Integer,Integer>> in method public GroupIdOperatorFactory(operatorId int, planNodeId PlanNodeId, outputTypes List<? extends Type>, groupingSetMappings List<Map<Integer,Integer>>) in class com.facebook.presto.operator.GroupIdOperator.GroupIdOperatorFactory | From | To |