87e8b99caf77d62310372864f453341ea42f9743
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 1 | ||
| Move Method public getPartitionUpdate() : PartitionUpdate from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter to public getPartitionUpdate() : PartitionUpdate from class com.facebook.presto.hive.HivePageSink.HiveWriter | From | To | |
| Change Return Type | 1 | ||
| Change Return Type HiveRecordWriter to HiveWriter in method private createWriter(partitionColumns Page, position int, bucketNumber OptionalInt) : HiveWriter in class com.facebook.presto.hive.HivePageSink | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private writePath : String from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter to private writePath : String from class com.facebook.presto.hive.HivePageSink.HiveWriter | From | To | |
| Move Attribute private fileName : String from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter to private fileName : String from class com.facebook.presto.hive.HivePageSink.HiveWriter | From | To | |
| Move Attribute private targetPath : String from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter to private targetPath : String from class com.facebook.presto.hive.HivePageSink.HiveWriter | From | To | |
| Move Attribute private isNew : boolean from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter to private isNew : boolean from class com.facebook.presto.hive.HivePageSink.HiveWriter | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.hive.HivePageSink.HiveWriter from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute writePath : String to path : Path in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Extract Variable | 2 | ||
| Extract Variable objectInspectors : List<ObjectInspector> in method public HiveRecordWriter(path Path, inputColumnNames List<String>, compress boolean, outputFormat String, serDe String, schema Properties, typeManager TypeManager, conf JobConf) from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Extract Variable fileNameWithExtension : String in method private createWriter(partitionColumns Page, position int, bucketNumber OptionalInt) : HiveWriter from class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type | 9 | ||
| Change Variable Type writer : HiveRecordWriter to writer : HiveWriter in method private doAppend(page Page) : CompletableFuture<?> in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type writer : HiveRecordWriter to writer : HiveWriter in method private doFinish() : ImmutableList<Slice> in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type writers : Int2ObjectMap<HiveRecordWriter> to writers : Int2ObjectMap<HiveWriter> in method private doAbort() : void in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type writer : HiveRecordWriter to writer : HiveWriter in method private doAbort() : void in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type writers : Int2ObjectMap<HiveRecordWriter> to writers : Int2ObjectMap<HiveWriter> in method private doFinish() : ImmutableList<Slice> in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Variable Type writers : Int2ObjectMap<HiveRecordWriter> to writers : Int2ObjectMap<HiveWriter> in method private doAppend(page Page) : CompletableFuture<?> in class com.facebook.presto.hive.HivePageSink | From | To | |
| Inline Variable | 1 | ||
| Inline Variable fileColumnHiveTypes : List<HiveType> in method public HiveRecordWriter(partitionName String, compress boolean, isNew boolean, inputColumns List<DataColumn>, outputFormat String, serDe String, schema Properties, fileName String, writePath String, targetPath String, typeManager TypeManager, conf JobConf) from class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type writers : HiveRecordWriter[] to writers : HiveWriter[] in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Attribute Type bucketWriters : List<Int2ObjectMap<HiveRecordWriter>> to bucketWriters : List<Int2ObjectMap<HiveWriter>> in class com.facebook.presto.hive.HivePageSink | From | To | |
| Change Attribute Type writePath : String to path : Path in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To |