88b42d41b8afc2778dfca6db4141e2f8c6acf6e4
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private getConnector(connectorId ConnectorId) : Connector renamed to private getCatalog(connectorId ConnectorId) : Catalog in class com.facebook.presto.transaction.TransactionManager | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public getMetadata(session Session) : ConnectorMetadata from class com.facebook.presto.metadata.MetadataManager.ConnectorEntry to private getCatalogMetadata(session Session, connectorId ConnectorId) : CatalogMetadata from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Move And Rename Method public getTransactionHandle(session Session) : ConnectorTransactionHandle from class com.facebook.presto.metadata.MetadataManager.ConnectorEntry to private getCatalogMetadataForWrite(session Session, connectorId ConnectorId) : CatalogMetadata from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Move Method | 1 | ||
| Move Method private getConnectorId() : ConnectorId from class com.facebook.presto.metadata.MetadataManager.ConnectorEntry to public getConnectorId() : ConnectorId from class com.facebook.presto.transaction.TransactionManager.TransactionMetadata.ConnectorTransactionMetadata | From | To | |
| Rename Variable | 6 | ||
| Rename Variable connector : Connector to catalog : Catalog in method private getCatalog(connectorId ConnectorId) : Catalog in class com.facebook.presto.transaction.TransactionManager | From | To | |
| Rename Variable target : ConnectorEntry to connectorId : ConnectorId in method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Rename Variable entry : ConnectorEntry to connectorId : ConnectorId in method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Inline Method | 2 | ||
| Inline Method private addConnectorInternal(type ConnectorType, catalogName String, connector MaterializedConnector) : void inlined to private addCatalogConnector(catalogName String, connectorId ConnectorId, factory ConnectorFactory, properties Map<String,String>) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Inline Method private checkMetadataArguments(connectorId ConnectorId, catalogName String) : void inlined to public registerConnectorCatalog(connectorId ConnectorId, catalogName String) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to ConnectorId in method private registerBogusConnector(transactionManager TransactionManager, catalogName String) : ConnectorId in class com.facebook.presto.security.TestAccessControlManager | From | To | |
| Change Return Type ConnectorTransactionHandle to CatalogMetadata in method private getCatalogMetadataForWrite(session Session, connectorId ConnectorId) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Return Type ConnectorMetadata to CatalogMetadata in method private getCatalogMetadata(session Session, connectorId ConnectorId) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Return Type Connector to Catalog in method private getCatalog(connectorId ConnectorId) : Catalog in class com.facebook.presto.transaction.TransactionManager | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private INFORMATION_SCHEMA_NAME : String from class com.facebook.presto.metadata.MetadataManager to private INFORMATION_SCHEMA_NAME : String from class com.facebook.presto.metadata.CatalogMetadata | From | To | |
| Extract Variable | 30 | ||
| Extract Variable connectorId : ConnectorId in method public beginCreateTable(session Session, catalogName String, tableMetadata ConnectorTableMetadata, layout Optional<NewTableLayout>) : OutputTableHandle from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public canCreateSampledTables(session Session, catalogName String) : boolean from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public revokeTablePrivileges(session Session, tableName QualifiedObjectName, privileges Set<Privilege>, grantee String, grantOption boolean) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorSession : ConnectorSession in method public listSchemaNames(session Session, catalogName String) : List<String> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public createSchema(session Session, schema CatalogSchemaName, properties Map<String,Object>) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public metadataDelete(session Session, tableHandle TableHandle, tableLayoutHandle TableLayoutHandle) : OptionalLong from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public beginInsert(session Session, tableHandle TableHandle) : InsertTableHandle from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public dropTable(session Session, tableHandle TableHandle) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public renameColumn(session Session, tableHandle TableHandle, source ColumnHandle, target String) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public createTable(session Session, catalogName String, tableMetadata ConnectorTableMetadata) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getColumnMetadata(session Session, tableHandle TableHandle, columnHandle ColumnHandle) : ColumnMetadata from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public dropSchema(session Session, schema CatalogSchemaName) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public createView(session Session, viewName QualifiedObjectName, viewData String, replace boolean) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getSampleWeightColumnHandle(session Session, tableHandle TableHandle) : Optional<ColumnHandle> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public finishDelete(session Session, tableHandle TableHandle, fragments Collection<Slice>) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public supportsMetadataDelete(session Session, tableHandle TableHandle, tableLayoutHandle TableLayoutHandle) : boolean from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getInsertLayout(session Session, table TableHandle) : Optional<NewTableLayout> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getUpdateRowIdColumnHandle(session Session, tableHandle TableHandle) : ColumnHandle from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public addColumn(session Session, tableHandle TableHandle, column ColumnMetadata) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getColumnHandles(session Session, tableHandle TableHandle) : Map<String,ColumnHandle> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public finishInsert(session Session, tableHandle InsertTableHandle, fragments Collection<Slice>) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public renameTable(session Session, tableHandle TableHandle, newTableName QualifiedObjectName) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public dropView(session Session, viewName QualifiedObjectName) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getTableMetadata(session Session, tableHandle TableHandle) : TableMetadata from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public beginDelete(session Session, tableHandle TableHandle) : TableHandle from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public renameSchema(session Session, source CatalogSchemaName, target String) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public finishCreateTable(session Session, tableHandle OutputTableHandle, fragments Collection<Slice>) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public grantTablePrivileges(session Session, tableName QualifiedObjectName, privileges Set<Privilege>, grantee String, grantOption boolean) : void from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public resolveIndex(session Session, tableHandle TableHandle, indexableColumns Set<ColumnHandle>, outputColumns Set<ColumnHandle>, tupleDomain TupleDomain<ColumnHandle>) : Optional<ResolvedIndex> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Variable connectorId : ConnectorId in method public getNewTableLayout(session Session, catalogName String, tableMetadata ConnectorTableMetadata) : Optional<NewTableLayout> from class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type connector : Connector to catalog : Catalog in method private getCatalog(connectorId ConnectorId) : Catalog in class com.facebook.presto.transaction.TransactionManager | From | To | |
| Change Variable Type target : ConnectorEntry to connectorId : ConnectorId in method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Variable Type entry : ConnectorEntry to connectorId : ConnectorId in method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Method | 6 | ||
| Extract Method public getCatalogMetadata(transactionId TransactionId, connectorId ConnectorId) : CatalogMetadata extracted from public getConnectorTransaction(transactionId TransactionId, connectorId ConnectorId) : ConnectorTransactionHandle in class com.facebook.presto.transaction.TransactionManager | From | To | |
| Extract Method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata extracted from public beginCreateTable(session Session, catalogName String, tableMetadata ConnectorTableMetadata, layout Optional<NewTableLayout>) : OutputTableHandle in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata extracted from public canCreateSampledTables(session Session, catalogName String) : boolean in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata extracted from public renameTable(session Session, tableHandle TableHandle, newTableName QualifiedObjectName) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata extracted from public createTable(session Session, catalogName String, tableMetadata ConnectorTableMetadata) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Extract Method private getCatalogMetadataForWrite(session Session, catalogName String) : CatalogMetadata extracted from public getNewTableLayout(session Session, catalogName String, tableMetadata ConnectorTableMetadata) : Optional<NewTableLayout> in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type connectorsByCatalog : ConcurrentMap<String,ConnectorEntry> to connectorsByCatalog : ConcurrentMap<String,ConnectorId> in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter connectorId : String to catalogName : String in method private registerBogusConnector(transactionManager TransactionManager, catalogName String) : ConnectorId in class com.facebook.presto.security.TestAccessControlManager | From | To |