95ad82b47530f8ecef59bd1afc215894965e2acd
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getOutput(lookupSource LookupSource) : Page renamed to private processProbe(lookupSource LookupSource) : void in class com.facebook.presto.operator.LookupJoinOperator | From | To | |
| Rename Method public setPartitionLookupSourceSupplier(partitionIndex int, partitionLookupSource Supplier<LookupSource>) : void renamed to public lendPartitionLookupSource(partitionIndex int, partitionLookupSource Supplier<LookupSource>) : ListenableFuture<?> in class com.facebook.presto.operator.PartitionedLookupSourceFactory | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type lookupSourceProviderFuture : ListenableFuture<LookupSourceProvider> to lookupSourceFactory : LookupSourceFactory in method public LookupJoinOperator(operatorContext OperatorContext, allTypes List<Type>, probeTypes List<Type>, joinType JoinType, lookupSourceFactory LookupSourceFactory, joinProbeFactory JoinProbeFactory, onClose Runnable, lookupJoinsCount OptionalInt, hashGenerator HashGenerator, partitioningSpillerFactory PartitioningSpillerFactory) in class com.facebook.presto.operator.LookupJoinOperator | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to ListenableFuture<?> in method public lendPartitionLookupSource(partitionIndex int, partitionLookupSource Supplier<LookupSource>) : ListenableFuture<?> in class com.facebook.presto.operator.PartitionedLookupSourceFactory | From | To | |
| Change Return Type Operator to HashBuilderOperator in method public createOperator(driverContext DriverContext) : HashBuilderOperator in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Change Return Type Page to void in method private processProbe(lookupSource LookupSource) : void in class com.facebook.presto.operator.LookupJoinOperator | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute finishing : boolean to state : State in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Extract Variable | 1 | ||
| Extract Variable buildOperator : HashBuilderOperator in method private setupBuildSide(parallelBuild boolean, taskContext TaskContext, hashChannels List<Integer>, buildPages RowPagesBuilder, filterFunction Optional<InternalJoinFilterFunction>, spillEnabled boolean) : BuildSideSetup from class com.facebook.presto.operator.TestHashJoinOperator | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type finishing : boolean to state : State in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Extract Method | 5 | ||
| Extract Method private addInput(page Page, spillInfoSnapshot SpillInfoSnapshot) : void extracted from public addInput(page Page) : void in class com.facebook.presto.operator.LookupJoinOperator | From | To | |
| Extract Method private finishInput() : void extracted from public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Extract Method private tryFetchLookupSourceProvider() : boolean extracted from public addInput(page Page) : void in class com.facebook.presto.operator.LookupJoinOperator | From | To | |
| Extract Method private buildLookupSource() : LookupSourceSupplier extracted from public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Extract Method private updateIndex(page Page) : void extracted from public addInput(page Page) : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter lookupSourceProviderFuture : ListenableFuture<LookupSourceProvider> to lookupSourceFactory : LookupSourceFactory in method public LookupJoinOperator(operatorContext OperatorContext, allTypes List<Type>, probeTypes List<Type>, joinType JoinType, lookupSourceFactory LookupSourceFactory, joinProbeFactory JoinProbeFactory, onClose Runnable, lookupJoinsCount OptionalInt, hashGenerator HashGenerator, partitioningSpillerFactory PartitioningSpillerFactory) in class com.facebook.presto.operator.LookupJoinOperator | From | To |