95d440f8300efb4af84d001c23b5a4b7927274bf
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private produceResult(controlColumns List<Column>, testColumns List<Column>, controlChecksum ChecksumQueryAndResult, testChecksum ChecksumQueryAndResult) : MatchResult renamed to private match(controlColumns List<Column>, testColumns List<Column>, controlChecksum ChecksumResult, testChecksum ChecksumResult) : MatchResult in class com.facebook.presto.verifier.framework.DataVerification | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type controlChecksum : ChecksumQueryAndResult to controlChecksum : ChecksumResult in method private match(controlColumns List<Column>, testColumns List<Column>, controlChecksum ChecksumResult, testChecksum ChecksumResult) : MatchResult in class com.facebook.presto.verifier.framework.DataVerification | From | To | |
| Change Parameter Type testChecksum : ChecksumQueryAndResult to testChecksum : ChecksumResult in method private match(controlColumns List<Column>, testColumns List<Column>, controlChecksum ChecksumResult, testChecksum ChecksumResult) : MatchResult in class com.facebook.presto.verifier.framework.DataVerification | From | To | |
| Change Parameter Type verificationResult : Optional<MatchResult> to verificationResult : Optional<VerificationResult> in method private buildEvent(control Optional<QueryBundle>, test Optional<QueryBundle>, controlStats Optional<QueryStats>, testStats Optional<QueryStats>, queryException Optional<QueryException>, verificationResult Optional<VerificationResult>, deterministic Optional<Boolean>) : VerifierQueryEvent in class com.facebook.presto.verifier.framework.AbstractVerification | From | To | |
| Change Return Type | 2 | ||
| Change Return Type MatchResult to VerificationResult in method public verify(control QueryBundle, test QueryBundle) : VerificationResult in class com.facebook.presto.verifier.framework.DataVerification | From | To | |
| Change Return Type MatchResult to VerificationResult in method protected abstract verify(control QueryBundle, test QueryBundle) : VerificationResult in class com.facebook.presto.verifier.framework.AbstractVerification | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.verifier.framework.VerificationResult from class com.facebook.presto.verifier.framework.MatchResult | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type verificationResult : MatchResult to verificationResult : VerificationResult in method public run() : Optional<VerifierQueryEvent> in class com.facebook.presto.verifier.framework.AbstractVerification | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter firstChecksumResult : ChecksumResult to firstChecksum : ChecksumResult in method protected isDeterministic(control QueryBundle, firstChecksum ChecksumResult) : Optional<Boolean> in class com.facebook.presto.verifier.framework.DataVerification | From | To |