a431ae9de088347b3e2433277c3cd2cf3fb4464a
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 52
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [userPool : MemoryPool, systemPool : MemoryPool] to memoryPool : MemoryPool in class com.facebook.presto.memory.TestMemoryTracking | From | To | |
| Extract Subclass | 2 | ||
| Extract Subclass com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext | From | To | |
| Extract Subclass com.facebook.presto.memory.context.AbstractAggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute private usedBytes : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to private usedBytes : long from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Attribute private closed : boolean from class com.facebook.presto.memory.context.AggregatedMemoryContext to private closed : boolean from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Attribute package NOT_BLOCKED : ListenableFuture<?> from class com.facebook.presto.memory.context.AggregatedMemoryContext to package NOT_BLOCKED : ListenableFuture<?> from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private queryId : QueryId in class com.facebook.presto.testing.TestingTaskContext.Builder | From | To | |
| Rename Class | 1 | ||
| Rename Class com.facebook.presto.operator.OperatorContext.DecoratedLocalMemoryContext renamed to com.facebook.presto.operator.OperatorContext.InternalLocalMemoryContext | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type parent : AggregatedMemoryContext to parent : AbstractAggregatedMemoryContext in method public transferMemory(to LocalMemoryContext) : void in class com.facebook.presto.memory.context.SimpleLocalMemoryContext | From | To | |
| Change Variable Type parent : AggregatedMemoryContext to parent : AbstractAggregatedMemoryContext in method private checkMemoryContextState(target SimpleLocalMemoryContext) : void in class com.facebook.presto.memory.context.SimpleLocalMemoryContext | From | To | |
| Change Variable Type systemMemoryPool : MemoryPool to queryId : QueryId in method public build() : TaskContext in class com.facebook.presto.testing.TestingTaskContext.Builder | From | To | |
| Extract Variable | 1 | ||
| Extract Variable taskUserMemory : long in method public getStageInfo(taskInfosSupplier Supplier<Iterable<TaskInfo>>, subStageInfosSupplier Supplier<Iterable<StageInfo>>) : StageInfo from class com.facebook.presto.execution.StageStateMachine | From | To | |
| Inline Variable | 1 | ||
| Inline Variable maxHeap : long in method public LocalMemoryManager(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig) from class com.facebook.presto.memory.LocalMemoryManager | From | To | |
| Extract Method | 1 | ||
| Extract Method private isBlockedOnMemory() : boolean extracted from public updateMemoryUsage(bytesAdded long) : void in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager | From | To | |
| Rename Method | 3 | ||
| Rename Method public getNotFullFuture() : ListenableFuture<?> renamed to public getBufferBlockedFuture() : ListenableFuture<?> in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager | From | To | |
| Rename Method package getQueryUserMemoryReservation(queryId QueryId) : long renamed to package getQueryMemoryReservation(queryId QueryId) : long in class com.facebook.presto.memory.MemoryPool | From | To | |
| Rename Method public getUserMemoryReservation() : long renamed to public getTotalMemoryReservation() : long in class com.facebook.presto.memory.LowMemoryKiller.QueryMemoryInfo | From | To | |
| Push Down Method | 10 | ||
| Push Down Method public toString() : String from class com.facebook.presto.memory.context.AggregatedMemoryContext to public toString() : String from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Method package abstract updateBytes(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract updateBytes(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Method package abstract closeContext() : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract closeContext() : void from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Method package addBytes(bytes long) : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to package addBytes(bytes long) : void from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Method public close() : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to public close() : void from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext | From | To | |
| Push Down Method package addExact(usedBytes long, bytes long) : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to package addExact(usedBytes long, bytes long) : long from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Push Down Method public getBytes() : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to public getBytes() : long from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext | From | To | |
| Push Down Method public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext to public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext | From | To | |
| Push Down Method public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext to public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext | From | To | |
| Push Down Method package abstract tryUpdateBytes(delta long) : boolean from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract tryUpdateBytes(delta long) : boolean from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext | From | To | |
| Inline Method | 1 | ||
| Inline Method private createDriverContext(memoryLimit long, systemMemoryLimit long) : DriverContext inlined to private createDriverContext(memoryLimit long) : DriverContext in class com.facebook.presto.operator.TestHashAggregationOperator | From | To | |
| Rename Variable | 2 | ||
| Rename Variable userMemory : long to totalMemory : long in method private updateSystemMemory(delta long) : ListenableFuture<?> in class com.facebook.presto.memory.QueryContext | From | To | |
| Rename Variable currentMemory : long to currentUserMemory : long in method private updateMemoryUsage(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener | From | To | |
| Change Return Type | 3 | ||
| Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.RootAggregatedMemoryContext | From | To | |
| Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.ChildAggregatedMemoryContext | From | To | |
| Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.SimpleAggregatedMemoryContext | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute systemMemoryPool : MemoryPool to queryId : QueryId in method public build() : TaskContext in class com.facebook.presto.testing.TestingTaskContext.Builder | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.facebook.presto.memory.context.AbstractAggregatedMemoryContext from classes [com.facebook.presto.memory.context.ChildAggregatedMemoryContext, com.facebook.presto.memory.context.RootAggregatedMemoryContext, com.facebook.presto.memory.context.SimpleAggregatedMemoryContext] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute memoryReservation : long to totalMemoryReservation : long in class com.facebook.presto.memory.LowMemoryKiller.QueryMemoryInfo | From | To | |
| Rename Attribute previousMemory : long to previousUserMemory : long in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.ChildAggregatedMemoryContext | From | To | |
| Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.SimpleLocalMemoryContext | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter expectedUserPoolMemory : long to expectedPoolMemory : long in method private assertLocalMemoryAllocations(memoryTrackingContext MemoryTrackingContext, expectedPoolMemory long, expectedContextUserMemory long, expectedContextSystemMemory long) : void in class com.facebook.presto.memory.TestMemoryTracking | From | To | |
| Rename Parameter systemMemoryLimit : long to memoryLimit : long in method private createDriverContext(memoryLimit long) : DriverContext in class com.facebook.presto.operator.TestHashAggregationOperator | From | To | |
| Rename Parameter memoryReservation : long to totalMemoryReservation : long in method public QueryMemoryInfo(queryId QueryId, memoryPoolId MemoryPoolId, totalMemoryReservation long) in class com.facebook.presto.memory.LowMemoryKiller.QueryMemoryInfo | From | To |