presto ae664f895670060f71f773b780ce7bfa4f1645c9

ae664f895670060f71f773b780ce7bfa4f1645c9

Files Diff

Added: 11
Removed: 5
Renamed: 0
Modified: 25

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	11
Change Parameter Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Parameter Type responseSizeTracker : LongConsumer to stats : RemoteTaskStats in method public SimpleHttpResponseHandler(callback SimpleHttpResponseCallback<T>, uri URI, stats RemoteTaskStats) in class com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To
Change Parameter Type stateChangeListener : StateChangeListener<TaskInfo> to stateChangeListener : StateChangeListener<TaskStatus> in method public addStateChangeListener(stateChangeListener StateChangeListener<TaskStatus>) : void in class com.facebook.presto.execution.MockRemoteTaskFactory.MockRemoteTask	From	To
Change Parameter Type stateChangeListener : StateChangeListener<TaskInfo> to stateChangeListener : StateChangeListener<TaskStatus> in method public addStateChangeListener(stateChangeListener StateChangeListener<TaskStatus>) : void in class com.facebook.presto.execution.RemoteTask	From	To
Change Parameter Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public stateChanged(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Change Parameter Type newState : TaskInfo to newStatus : TaskStatus in method public stateChanged(newStatus TaskStatus) : void in class com.facebook.presto.execution.MemoryTrackingRemoteTaskFactory.UpdatePeakMemory	From	To
Change Parameter Type stateChangeListener : StateChangeListener<TaskInfo> to stateChangeListener : StateChangeListener<TaskStatus> in method public addStateChangeListener(stateChangeListener StateChangeListener<TaskStatus>) : void in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Parameter Type value : TaskInfo to value : TaskStatus in method public success(value TaskStatus) : void in class com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Change Parameter Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.execution.RemoteTask	From	To
Change Parameter Type taskInfo : TaskInfo to taskStatus : TaskStatus in method private updateMemoryUsage(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Change Parameter Type response : JsonResponse<T> to response : FullJsonResponseHandler.JsonResponse<T> in method public onSuccess(response FullJsonResponseHandler.JsonResponse<T>) : void in class com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To
Move Method	6
Move Method public getState() : TaskState from class com.facebook.presto.execution.TaskInfo to public getState() : TaskState from class com.facebook.presto.execution.TaskStatus	From	To
Move Method public getSelf() : URI from class com.facebook.presto.execution.TaskInfo to public getSelf() : URI from class com.facebook.presto.execution.TaskStatus	From	To
Move Method public getVersion() : long from class com.facebook.presto.execution.TaskInfo to public getVersion() : long from class com.facebook.presto.execution.TaskStatus	From	To
Move Method public getFailures() : List<ExecutionFailureInfo> from class com.facebook.presto.execution.TaskInfo to public getFailures() : List<ExecutionFailureInfo> from class com.facebook.presto.execution.TaskStatus	From	To
Move Method public getTaskInstanceId() : String from class com.facebook.presto.execution.TaskInfo to public getTaskInstanceId() : String from class com.facebook.presto.execution.TaskStatus	From	To
Move Method private updateTaskInfo(newValue TaskInfo) : void from class com.facebook.presto.server.HttpRemoteTask to package updateTaskInfo(newValue TaskInfo) : void from class com.facebook.presto.server.remotetask.TaskInfoFetcher	From	To
Move Attribute	10
Move Attribute public MIN_VERSION : long from class com.facebook.presto.execution.TaskInfo to private MIN_VERSION : long from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private taskInstanceId : String from class com.facebook.presto.execution.TaskInfo to private taskInstanceId : String from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private self : URI from class com.facebook.presto.execution.TaskInfo to private self : URI from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute public MAX_VERSION : long from class com.facebook.presto.execution.TaskInfo to private MAX_VERSION : long from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private taskInfo : StateMachine<TaskInfo> from class com.facebook.presto.server.HttpRemoteTask to private taskInfo : StateMachine<TaskInfo> from class com.facebook.presto.server.remotetask.TaskInfoFetcher	From	To
Move Attribute private failures : List<ExecutionFailureInfo> from class com.facebook.presto.execution.TaskInfo to private failures : List<ExecutionFailureInfo> from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private state : TaskState from class com.facebook.presto.execution.TaskInfo to private state : TaskState from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute public STARTING_VERSION : long from class com.facebook.presto.execution.TaskInfo to public STARTING_VERSION : long from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private version : long from class com.facebook.presto.execution.TaskInfo to private version : long from class com.facebook.presto.execution.TaskStatus	From	To
Move Attribute private taskId : TaskId from class com.facebook.presto.execution.TaskInfo to private taskId : TaskId from class com.facebook.presto.execution.TaskStatus	From	To
Extract Class	2
Extract Class com.facebook.presto.server.remotetask.TaskInfoFetcher from class com.facebook.presto.server.HttpRemoteTask	From	To
Extract Class com.facebook.presto.execution.TaskStatus from class com.facebook.presto.execution.TaskInfo	From	To
Move And Rename Class	1
Move And Rename Class com.facebook.presto.server.HttpRemoteTask.ContinuousTaskInfoFetcher moved and renamed to com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Move Class	8
Move Class com.facebook.presto.server.RemoteTaskStats moved to com.facebook.presto.server.remotetask.RemoteTaskStats	From	To
Move Class com.facebook.presto.server.HttpLocationFactory moved to com.facebook.presto.server.remotetask.HttpLocationFactory	From	To
Move Class com.facebook.presto.server.HttpRemoteTask moved to com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Move Class com.facebook.presto.server.HttpRemoteTask.SimpleHttpResponseHandler moved to com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To
Move Class com.facebook.presto.server.TestBackoff moved to com.facebook.presto.server.remotetask.TestBackoff	From	To
Move Class com.facebook.presto.server.HttpRemoteTask.RequestErrorTracker moved to com.facebook.presto.server.remotetask.RequestErrorTracker	From	To
Move Class com.facebook.presto.server.Backoff moved to com.facebook.presto.server.remotetask.Backoff	From	To
Move Class com.facebook.presto.server.HttpRemoteTask.SimpleHttpResponseCallback moved to com.facebook.presto.server.remotetask.SimpleHttpResponseCallback	From	To
Extract Variable	2
Extract Variable taskId : TaskId in method public removeOldTasks() : void from class com.facebook.presto.execution.SqlTaskManager	From	To
Extract Variable taskState : TaskState in method public getStageInfo(taskInfosSupplier Supplier<Iterable<TaskInfo>>, subStageInfosSupplier Supplier<Iterable<StageInfo>>) : StageInfo from class com.facebook.presto.execution.StageStateMachine	From	To
Change Variable Type	6
Change Variable Type taskInfo : TaskInfo to taskStatus : TaskStatus in method package failTask(cause Throwable) : void in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Variable Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public getQueuedPartitionedSplitCount() : int in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Variable Type stateChangeFutures : List<CompletableFuture<TaskInfo>> to stateChangeFutures : List<CompletableFuture<TaskStatus>> in method public getTaskStateChange() : CompletableFuture<?> in class com.facebook.presto.execution.SqlStageExecution	From	To
Change Variable Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public getPartitionedSplitCount() : int in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Variable Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public failed(cause Throwable) : void in class com.facebook.presto.server.remotetask.HttpRemoteTask.UpdateResponseHandler	From	To
Change Variable Type taskInfo : TaskInfo to taskStatus : TaskStatus in method public failed(cause Throwable) : void in class com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Inline Variable	2
Inline Variable uriBuilder : HttpUriBuilder in method private scheduleNextRequest() : void from class com.facebook.presto.server.HttpRemoteTask.ContinuousTaskInfoFetcher	From	To
Inline Variable uri : URI in method public abort() : void from class com.facebook.presto.server.HttpRemoteTask	From	To
Extract Method	1
Extract Method private abort(status TaskStatus) : void extracted from public abort() : void in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Rename Method	3
Rename Method public getInfoRefreshMaxWait() : Duration renamed to public getStatusRefreshMaxWait() : Duration in class com.facebook.presto.execution.TaskManagerConfig	From	To
Rename Method public getTaskId() : TaskId renamed to public getTaskStatus() : TaskStatus in class com.facebook.presto.execution.TaskInfo	From	To
Rename Method public setInfoRefreshMaxWait(infoRefreshMaxWait Duration) : TaskManagerConfig renamed to public setStatusRefreshMaxWait(statusRefreshMaxWait Duration) : TaskManagerConfig in class com.facebook.presto.execution.TaskManagerConfig	From	To
Rename Variable	5
Rename Variable taskInfo : TaskInfo to taskStatus : TaskStatus in method public getQueuedPartitionedSplitCount() : int in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Rename Variable taskInfo : TaskInfo to taskStatus : TaskStatus in method public failed(cause Throwable) : void in class com.facebook.presto.server.remotetask.HttpRemoteTask.UpdateResponseHandler	From	To
Rename Variable taskInfo : TaskInfo to taskStatus : TaskStatus in method public failed(cause Throwable) : void in class com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Rename Variable taskInfo : TaskInfo to taskStatus : TaskStatus in method package failTask(cause Throwable) : void in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Rename Variable taskInfo : TaskInfo to taskStatus : TaskStatus in method public getPartitionedSplitCount() : int in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Return Type	3
Change Return Type CompletableFuture<TaskInfo> to CompletableFuture<TaskStatus> in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Change Return Type CompletableFuture<TaskInfo> to CompletableFuture<TaskStatus> in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.execution.RemoteTask	From	To
Change Return Type TaskId to TaskStatus in method public getTaskStatus() : TaskStatus in class com.facebook.presto.execution.TaskInfo	From	To
Rename Attribute	3
Rename Attribute infoRefreshMaxWait : Duration to statusRefreshMaxWait : Duration in class com.facebook.presto.execution.TaskManagerConfig	From	To
Rename Attribute taskInfoRefreshMaxWait : Duration to taskStatusRefreshMaxWait : Duration in class com.facebook.presto.server.HttpRemoteTaskFactory	From	To
Rename Attribute responseSizeTracker : LongConsumer to stats : RemoteTaskStats in class com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To
Change Attribute Type	2
Change Attribute Type responseSizeTracker : LongConsumer to stats : RemoteTaskStats in class com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To
Change Attribute Type future : ListenableFuture<JsonResponse<TaskInfo>> to future : ListenableFuture<FullJsonResponseHandler.JsonResponse<TaskStatus>> in class com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Extract And Move Method	1
Extract And Move Method package updateTaskStatus(newValue TaskStatus) : void extracted from private updateTaskInfo(newValue TaskInfo, sources List<TaskSource>) : void in class com.facebook.presto.server.HttpRemoteTask & moved to class com.facebook.presto.server.remotetask.ContinuousTaskStatusFetcher	From	To
Rename Parameter	7
Rename Parameter taskInfo : TaskInfo to taskStatus : TaskStatus in method public stateChanged(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Rename Parameter infoRefreshMaxWait : Duration to statusRefreshMaxWait : Duration in method public setStatusRefreshMaxWait(statusRefreshMaxWait Duration) : TaskManagerConfig in class com.facebook.presto.execution.TaskManagerConfig	From	To
Rename Parameter newState : TaskInfo to newStatus : TaskStatus in method public stateChanged(newStatus TaskStatus) : void in class com.facebook.presto.execution.MemoryTrackingRemoteTaskFactory.UpdatePeakMemory	From	To
Rename Parameter taskInfo : TaskInfo to taskStatus : TaskStatus in method private updateMemoryUsage(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Rename Parameter taskInfo : TaskInfo to taskStatus : TaskStatus in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.execution.RemoteTask	From	To
Rename Parameter taskInfo : TaskInfo to taskStatus : TaskStatus in method public getStateChange(taskStatus TaskStatus) : CompletableFuture<TaskStatus> in class com.facebook.presto.server.remotetask.HttpRemoteTask	From	To
Rename Parameter responseSizeTracker : LongConsumer to stats : RemoteTaskStats in method public SimpleHttpResponseHandler(callback SimpleHttpResponseCallback<T>, uri URI, stats RemoteTaskStats) in class com.facebook.presto.server.remotetask.SimpleHttpResponseHandler	From	To

ae664f895670060f71f773b780ce7bfa4f1645c9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: