presto ba430d48e0b42544cc85afcd3ac44390f163e372

ba430d48e0b42544cc85afcd3ac44390f163e372

Files Diff

Added: 2
Removed: 2
Renamed: 0
Modified: 2

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public testDoubleVarchar() : void renamed to public testMaxDoubleVarchar() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Rename Method public testNull() : void renamed to public testMaxNull() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Rename Method public testDoubleDouble() : void renamed to public testMaxDoubleDouble() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Pull Up Method	10
Pull Up Method public output(valueType Type, state MaxOrMinByState, out BlockBuilder) : void from class com.facebook.presto.operator.aggregation.MaxBy to public output(valueType Type, state MaxOrMinByState, out BlockBuilder) : void from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method public getSignature() : Signature from class com.facebook.presto.operator.aggregation.MinBy to public getSignature() : Signature from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method private generateAggregation(valueType Type, keyType Type) : InternalAggregationFunction from class com.facebook.presto.operator.aggregation.MinBy to private generateAggregation(valueType Type, keyType Type) : InternalAggregationFunction from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method private generateAggregation(valueType Type, keyType Type) : InternalAggregationFunction from class com.facebook.presto.operator.aggregation.MaxBy to private generateAggregation(valueType Type, keyType Type) : InternalAggregationFunction from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method public getSignature() : Signature from class com.facebook.presto.operator.aggregation.MaxBy to public getSignature() : Signature from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method private createInputParameterMetadata(value Type, key Type) : List<ParameterMetadata> from class com.facebook.presto.operator.aggregation.MaxBy to private createInputParameterMetadata(value Type, key Type) : List<ParameterMetadata> from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method public specialize(types Map<String,Type>, arity int, typeManager TypeManager, functionRegistry FunctionRegistry) : FunctionInfo from class com.facebook.presto.operator.aggregation.MinBy to public specialize(types Map<String,Type>, arity int, typeManager TypeManager, functionRegistry FunctionRegistry) : FunctionInfo from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method private createInputParameterMetadata(value Type, key Type) : List<ParameterMetadata> from class com.facebook.presto.operator.aggregation.MinBy to private createInputParameterMetadata(value Type, key Type) : List<ParameterMetadata> from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method public specialize(types Map<String,Type>, arity int, typeManager TypeManager, functionRegistry FunctionRegistry) : FunctionInfo from class com.facebook.presto.operator.aggregation.MaxBy to public specialize(types Map<String,Type>, arity int, typeManager TypeManager, functionRegistry FunctionRegistry) : FunctionInfo from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Method public output(valueType Type, state MaxOrMinByState, out BlockBuilder) : void from class com.facebook.presto.operator.aggregation.MinBy to public output(valueType Type, state MaxOrMinByState, out BlockBuilder) : void from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Move Method	2
Move Method public input(keyType Type, state MaxOrMinByState, value Block, key Block, position int) : void from class com.facebook.presto.operator.aggregation.MaxBy to public input(min boolean, keyType Type, state MaxOrMinByState, value Block, key Block, position int) : void from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Move Method public input(keyType Type, state MaxOrMinByState, value Block, key Block, position int) : void from class com.facebook.presto.operator.aggregation.MinBy to public input(min boolean, keyType Type, state MaxOrMinByState, value Block, key Block, position int) : void from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Rename Variable	3
Rename Variable doubleDouble : InternalAggregationFunction to function : InternalAggregationFunction in method public testMaxDoubleDouble() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Rename Variable doubleVarchar : InternalAggregationFunction to function : InternalAggregationFunction in method public testMaxDoubleVarchar() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Rename Variable doubleDouble : InternalAggregationFunction to function : InternalAggregationFunction in method public testMaxNull() : void in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Pull Up Attribute	6
Pull Up Attribute private INPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MinBy to private INPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Attribute private COMBINE_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MaxBy to private COMBINE_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Attribute private INPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MaxBy to private INPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Attribute private OUTPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MaxBy to private OUTPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Attribute private OUTPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MinBy to private OUTPUT_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Pull Up Attribute private COMBINE_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.MinBy to private COMBINE_FUNCTION : MethodHandle from class com.facebook.presto.operator.aggregation.AbstractMinMaxBy	From	To
Rename Class	1
Rename Class com.facebook.presto.operator.aggregation.TestMaxByAggregation renamed to com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To
Extract Superclass	1
Extract Superclass com.facebook.presto.operator.aggregation.AbstractMinMaxBy from classes [com.facebook.presto.operator.aggregation.MaxBy, com.facebook.presto.operator.aggregation.MinBy]	From	To
Rename Attribute	1
Rename Attribute metadata : MetadataManager to METADATA : MetadataManager in class com.facebook.presto.operator.aggregation.TestMinMaxByAggregation	From	To

ba430d48e0b42544cc85afcd3ac44390f163e372

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: