be22100e7fc45fe7f862359b13b7c37d4f7ee692
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public getPartition(page Page, position int) : int renamed to public getBucket(page Page, position int) : int in class com.facebook.presto.sql.planner.PartitionFunctionHandle.SingleBucketFunction | From | To | |
Rename Method public getPartitionCount() : OptionalInt renamed to public getBucketToPartition() : Optional<int[]> in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To | |
Pull Up Method | 4 | ||
Pull Up Method public getPartitionCount() : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.RoundRobinPartitionFunction to public getPartition(functionArguments Page, position int) : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Pull Up Method public getPartitionCount() : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.HashPartitionFunction to public getPartition(functionArguments Page, position int) : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Pull Up Method public getPartitionCount() : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.RoundRobinPartitionFunction to public getPartitionCount() : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Pull Up Method public getPartitionCount() : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.HashPartitionFunction to public getPartitionCount() : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in method public PartitionFunctionBinding(functionHandle PartitionFunctionHandle, partitioningColumns List<Symbol>, hashColumn Optional<Symbol>, replicateNulls boolean, bucketToPartition Optional<int[]>) in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To | |
Rename Variable | 1 | ||
Rename Variable partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in method private createStages(parent Optional<SqlStageExecution>, nextStageId AtomicInteger, locationFactory LocationFactory, plan StageExecutionPlan, nodeScheduler NodeScheduler, remoteTaskFactory RemoteTaskFactory, session Session, splitBatchSize int, nodePartitioningManager NodePartitioningManager, executor ExecutorService, nodeTaskMap NodeTaskMap, stageSchedulers ImmutableMap.Builder<StageId,StageScheduler>, stageLinkages ImmutableMap.Builder<StageId,StageLinkage>) : List<SqlStageExecution> in class com.facebook.presto.execution.scheduler.SqlQueryScheduler | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private partitionCount : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.RoundRobinPartitionFunction to private partitionCount : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Pull Up Attribute private partitionCount : int from class com.facebook.presto.sql.planner.PartitionFunctionHandle.HashPartitionFunction to private partitionCount : int from class com.facebook.presto.operator.PartitionFunction | From | To | |
Change Return Type | 1 | ||
Change Return Type OptionalInt to Optional<int[]> in method public getBucketToPartition() : Optional<int[]> in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To | |
Rename Class | 1 | ||
Rename Class com.facebook.presto.sql.planner.PartitionFunctionHandle.SinglePartitionFunction renamed to com.facebook.presto.sql.planner.PartitionFunctionHandle.SingleBucketFunction | From | To | |
Rename Attribute | 1 | ||
Rename Attribute partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To | |
Change Variable Type | 1 | ||
Change Variable Type partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in method private createStages(parent Optional<SqlStageExecution>, nextStageId AtomicInteger, locationFactory LocationFactory, plan StageExecutionPlan, nodeScheduler NodeScheduler, remoteTaskFactory RemoteTaskFactory, session Session, splitBatchSize int, nodePartitioningManager NodePartitioningManager, executor ExecutorService, nodeTaskMap NodeTaskMap, stageSchedulers ImmutableMap.Builder<StageId,StageScheduler>, stageLinkages ImmutableMap.Builder<StageId,StageLinkage>) : List<SqlStageExecution> in class com.facebook.presto.execution.scheduler.SqlQueryScheduler | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To | |
Rename Parameter | 1 | ||
Rename Parameter partitionCount : OptionalInt to bucketToPartition : Optional<int[]> in method public PartitionFunctionBinding(functionHandle PartitionFunctionHandle, partitioningColumns List<Symbol>, hashColumn Optional<Symbol>, replicateNulls boolean, bucketToPartition Optional<int[]>) in class com.facebook.presto.sql.planner.PartitionFunctionBinding | From | To |