c0b3efb2a4a0909f8bfaf4ac2bf1464c24dd3fd2
Files Diff
- Added: 68
- Removed: 0
- Renamed: 0
- Modified: 32
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public writeOrcColumn(outputFile File, format Format, compression Compression, type Type, values Iterator<?>) : DataSize renamed to public writeOrcColumnOld(outputFile File, format Format, compression CompressionKind, type Type, values Iterator<?>) : DataSize in class com.facebook.presto.orc.OrcTester | From | To | |
| Rename Method private assertFileContents(type Type, tempFile TempFile, expectedValues List<?>, skipFirstBatch boolean, skipStripe boolean, metadataReader MetadataReader, format Format) : void renamed to private assertFileContentsNew(type Type, tempFile TempFile, expectedValues List<?>, skipFirstBatch boolean, skipStripe boolean, metadataReader MetadataReader, format Format) : void in class com.facebook.presto.orc.OrcTester | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type compression : Compression to compression : CompressionKind in method package createOrcRecordWriter(outputFile File, format Format, compression CompressionKind, type Type) : RecordWriter in class com.facebook.presto.orc.OrcTester | From | To | |
| Change Parameter Type compression : Compression to compression : CompressionKind in method public writeOrcColumnOld(outputFile File, format Format, compression CompressionKind, type Type, values Iterator<?>) : DataSize in class com.facebook.presto.orc.OrcTester | From | To | |
| Change Parameter Type compression : Compression to compression : CompressionKind in method private createOrcRecordWriter(outputFile File, format Format, compression CompressionKind, columnObjectInspector ObjectInspector) : FileSinkOperator.RecordWriter in class com.facebook.presto.orc.TestCachingOrcDataSource | From | To | |
| Change Parameter Type compressionCodec : Compression to compressionCodec : CompressionKind in method private createDwrfRecordWriter(outputFile File, compressionCodec CompressionKind, type Type) : RecordWriter in class com.facebook.presto.orc.OrcTester | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private MAGIC : Slice from class com.facebook.presto.orc.OrcReader to public MAGIC : Slice from class com.facebook.presto.orc.metadata.PostScript | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.facebook.presto.orc.OrcTester.Compression moved and renamed to com.facebook.presto.orc.stream.LongOutputStreamV2.SerializationUtils.FixedBitSizes | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type compression : Compression to compression : CompressionKind in method public assertRoundTrip(type Type, readValues List<?>, verifyWithOldReader boolean) : void in class com.facebook.presto.orc.OrcTester | From | To | |
| Extract Method | 2 | ||
| Extract Method private matchMiddleSection(columnStatistics ColumnStatistics, size int) : void extracted from public matches(numberOfRows long, statisticsByColumnIndex Map<Integer,ColumnStatistics>) : boolean in class com.facebook.presto.orc.TestingOrcPredicate.BasicOrcPredicate | From | To | |
| Extract Method public assertRoundTrip(type Type, readValues List<?>, verifyWithOldReader boolean) : void extracted from public assertRoundTrip(type Type, readValues List<?>) : void in class com.facebook.presto.orc.OrcTester | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type compressions : Set<Compression> to compressions : Set<CompressionKind> in class com.facebook.presto.orc.OrcTester | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public createOrcDecompressor(orcDataSourceId OrcDataSourceId, compression CompressionKind, bufferSize int) : Optional<OrcDecompressor> extracted from public OrcReader(orcDataSource OrcDataSource, delegate MetadataReader, maxMergeDistance DataSize, maxReadSize DataSize, maxBlockSize DataSize) in class com.facebook.presto.orc.OrcReader & moved to class com.facebook.presto.orc.OrcDecompressor | From | To |