c26a6619da02f79e3fba00ab651ff81201eaa4c7
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Merge Attribute | 1 | ||
Merge Attribute [nullableResult : boolean, argumentProperties : List<ArgumentProperty>, methodsGroups : List<MethodsGroup>] to choices : List<PolymorphicScalarFunctionChoice> in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type methods : List<Method> to methodAndNativeContainerTypes : List<MethodAndNativeContainerTypes> in method package MethodsGroup(methodAndNativeContainerTypes List<MethodAndNativeContainerTypes>, extraParametersFunction Optional<Function<SpecializeContext,List<Object>>>) in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.MethodsGroup | From | To | |
Move Method | 2 | ||
Move Method public implementation(methodGroupSpecification Function<MethodsGroupBuilder,MethodsGroupBuilder>) : PolymorphicScalarFunctionBuilder from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder to public implementation(methodsGroupSpecification Function<MethodsGroupBuilder,MethodsGroupBuilder>) : ChoiceBuilder from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Move Method public argumentProperties(argumentProperties ArgumentProperty...) : PolymorphicScalarFunctionBuilder from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder to public argumentProperties(argumentProperties ArgumentProperty...) : ChoiceBuilder from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Rename Variable | 1 | ||
Rename Variable matchingMethodHandle : MethodHandle to methodHandle : MethodHandle in method private getScalarFunctionImplementationChoice(boundVariables BoundVariables, typeManager TypeManager, functionRegistry FunctionRegistry, choice PolymorphicScalarFunctionChoice) : ScalarImplementationChoice in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Change Return Type | 4 | ||
Change Return Type PolymorphicScalarFunctionBuilder to ChoiceBuilder in method public implementation(methodsGroupSpecification Function<MethodsGroupBuilder,MethodsGroupBuilder>) : ChoiceBuilder in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Change Return Type List<Method> to List<MethodAndNativeContainerTypes> in method package getMethods() : List<MethodAndNativeContainerTypes> in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.MethodsGroup | From | To | |
Change Return Type PolymorphicScalarFunctionBuilder to ChoiceBuilder in method public argumentProperties(argumentProperties ArgumentProperty...) : ChoiceBuilder in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Change Return Type PolymorphicScalarFunctionBuilder to SqlScalarFunction in method private castFunctionToDecimalFromBuilder(from TypeSignature, nullableResult boolean, methodNames String...) : SqlScalarFunction in class com.facebook.presto.type.DecimalCasts | From | To | |
Move Attribute | 6 | ||
Move Attribute private methodsGroups : List<MethodsGroup> from class com.facebook.presto.metadata.PolymorphicScalarFunction to private methodsGroups : List<MethodsGroup> from class com.facebook.presto.metadata.PolymorphicScalarFunction.PolymorphicScalarFunctionChoice | From | To | |
Move Attribute private methodsGroups : List<MethodsGroup> from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder to private methodsGroups : List<MethodsGroup> from class com.facebook.presto.metadata.PolymorphicScalarFunction.PolymorphicScalarFunctionChoice | From | To | |
Move Attribute private argumentProperties : List<ArgumentProperty> from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder to private argumentProperties : List<ArgumentProperty> from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Move Attribute private nullableResult : boolean from class com.facebook.presto.metadata.PolymorphicScalarFunction to private nullableResult : boolean from class com.facebook.presto.metadata.PolymorphicScalarFunction.PolymorphicScalarFunctionChoice | From | To | |
Move Attribute private argumentProperties : List<ArgumentProperty> from class com.facebook.presto.metadata.PolymorphicScalarFunction to private argumentProperties : List<ArgumentProperty> from class com.facebook.presto.metadata.PolymorphicScalarFunction.PolymorphicScalarFunctionChoice | From | To | |
Move Attribute private nullableResult : boolean from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder to private nullableResult : boolean from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To | |
Extract Class | 2 | ||
Extract Class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder from class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder | From | To | |
Extract Class com.facebook.presto.metadata.PolymorphicScalarFunction.PolymorphicScalarFunctionChoice from class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Rename Attribute | 2 | ||
Rename Attribute methods : List<Method> to methodAndNativeContainerTypes : List<MethodAndNativeContainerTypes> in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.MethodsGroup | From | To | |
Rename Attribute argumentProperties : List<ArgumentProperty> to choices : List<PolymorphicScalarFunctionChoice> in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Change Variable Type | 2 | ||
Change Variable Type candidateMethod : Method to candidateMethod : MethodAndNativeContainerTypes in method private getScalarFunctionImplementationChoice(boundVariables BoundVariables, typeManager TypeManager, functionRegistry FunctionRegistry, choice PolymorphicScalarFunctionChoice) : ScalarImplementationChoice in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Change Variable Type matchingMethod : Optional<Method> to matchingMethod : Optional<MethodAndNativeContainerTypes> in method private getScalarFunctionImplementationChoice(boundVariables BoundVariables, typeManager TypeManager, functionRegistry FunctionRegistry, choice PolymorphicScalarFunctionChoice) : ScalarImplementationChoice in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type argumentProperties : List<ArgumentProperty> to choices : List<PolymorphicScalarFunctionChoice> in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Change Attribute Type methods : List<Method> to methodAndNativeContainerTypes : List<MethodAndNativeContainerTypes> in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.MethodsGroup | From | To | |
Extract Method | 1 | ||
Extract Method private getScalarFunctionImplementationChoice(boundVariables BoundVariables, typeManager TypeManager, functionRegistry FunctionRegistry, choice PolymorphicScalarFunctionChoice) : ScalarImplementationChoice extracted from public specialize(boundVariables BoundVariables, arity int, typeManager TypeManager, functionRegistry FunctionRegistry) : ScalarFunctionImplementation in class com.facebook.presto.metadata.PolymorphicScalarFunction | From | To | |
Rename Parameter | 2 | ||
Rename Parameter methods : List<Method> to methodAndNativeContainerTypes : List<MethodAndNativeContainerTypes> in method package MethodsGroup(methodAndNativeContainerTypes List<MethodAndNativeContainerTypes>, extraParametersFunction Optional<Function<SpecializeContext,List<Object>>>) in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.MethodsGroup | From | To | |
Rename Parameter methodGroupSpecification : Function<MethodsGroupBuilder,MethodsGroupBuilder> to methodsGroupSpecification : Function<MethodsGroupBuilder,MethodsGroupBuilder> in method public implementation(methodsGroupSpecification Function<MethodsGroupBuilder,MethodsGroupBuilder>) : ChoiceBuilder in class com.facebook.presto.metadata.PolymorphicScalarFunctionBuilder.ChoiceBuilder | From | To |