c67be7691a39f797522a8a19cde3a2011b0ecfe4
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 3 | ||
| Move And Rename Method private createDirectories(path Path) : void from class com.facebook.presto.hive.HiveMetadata to public createDirectory(hdfsEnvironment HdfsEnvironment, temporaryPath Path) : void from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move And Rename Method private rename(source Path, target Path) : void from class com.facebook.presto.hive.HiveMetadata to public renameDirectory(hdfsEnvironment HdfsEnvironment, schemaName String, tableName String, source Path, target Path) : void from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move And Rename Method private getTargetPath(schemaName String, tableName String, schemaTableName SchemaTableName) : Path from class com.facebook.presto.hive.HiveMetadata to public getTableDefaultLocation(metastore HiveMetastore, hdfsEnvironment HdfsEnvironment, schemaName String, tableName String) : Path from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in method public HiveConnector(lifeCycleManager LifeCycleManager, metadata ConnectorMetadata, splitManager ConnectorSplitManager, pageSourceProvider ConnectorPageSourceProvider, pageSinkProvider ConnectorPageSinkProvider, handleResolver ConnectorHandleResolver, systemTables Set<SystemTable>, sessionProperties List<PropertyMetadata<?>>, tableProperties List<PropertyMetadata<?>>, accessControl ConnectorAccessControl) in class com.facebook.presto.hive.HiveConnector | From | To | |
| Move Method | 5 | ||
| Move Method private createRecordWriter(target Path, conf JobConf, properties Properties, outputFormatName String) : RecordWriter from class com.facebook.presto.hive.HiveRecordSink to public createRecordWriter(target Path, conf JobConf, properties Properties, outputFormatName String) : RecordWriter from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move Method private isDirectory(path Path) : boolean from class com.facebook.presto.hive.HiveMetadata to private isDirectory(hdfsEnvironment HdfsEnvironment, path Path) : boolean from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move Method private getJavaObjectInspector(type Type) : ObjectInspector from class com.facebook.presto.hive.HiveRecordSink to private getJavaObjectInspector(type Type) : ObjectInspector from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move Method private getJavaObjectInspectors(types Iterable<Type>) : List<ObjectInspector> from class com.facebook.presto.hive.HiveRecordSink to public getJavaObjectInspectors(types Iterable<Type>) : List<ObjectInspector> from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Move Method private getDatabase(database String) : Database from class com.facebook.presto.hive.HiveMetadata to private getDatabase(metastore HiveMetastore, database String) : Database from class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.hive.HiveWriteUtils from class com.facebook.presto.hive.HiveRecordSink | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.facebook.presto.hive.HiveRecordSink moved and renamed to com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Extract Variable | 2 | ||
| Extract Variable typeManager : TypeRegistry in method protected setup(host String, port int, databaseName String, awsAccessKey String, awsSecretKey String, writableBucket String) : void from class com.facebook.presto.hive.AbstractTestHiveClientS3 | From | To | |
| Extract Variable typeManager : TypeRegistry in method protected setup(host String, port int, databaseName String, timeZoneId String, connectorName String, maxOutstandingSplits int, maxThreads int) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in method public create(connectorId String, config Map<String,String>) : Connector in class com.facebook.presto.hive.HiveConnectorFactory | From | To | |
| Change Variable Type columnNames : ImmutableList.Builder<String> to columnHandles : ImmutableList.Builder<HiveColumnHandle> in method private getColumnHandles(connectorId String, tableMetadata ConnectorTableMetadata) : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Change Variable Type temporaryRoot : Path to writePath : String in method public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Extract Method | 4 | ||
| Extract Method public getType(hiveType String, typeManager TypeManager) : Type extracted from public getType(hiveType String) : Type in class com.facebook.presto.hive.HiveType | From | To | |
| Extract Method private createTable(schemaName String, tableName String, tableOwner String, columnHandles List<HiveColumnHandle>, hiveStorageFormat HiveStorageFormat, targetPath Path) : void extracted from public commitCreateTable(session ConnectorSession, tableHandle ConnectorOutputTableHandle, fragments Collection<Slice>) : void in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Extract Method private getColumnHandles(connectorId String, tableMetadata ConnectorTableMetadata) : List<HiveColumnHandle> extracted from public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Extract Method private getColumnHandles(connectorId String, tableMetadata ConnectorTableMetadata) : List<HiveColumnHandle> extracted from public createTable(session ConnectorSession, tableMetadata ConnectorTableMetadata) : void in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Rename Method | 5 | ||
| Rename Method public finishRecord() : void renamed to public addRow(fieldValues List<Object>) : void in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Rename Method public getRecordSinkProvider() : ConnectorRecordSinkProvider renamed to public getPageSinkProvider() : ConnectorPageSinkProvider in class com.facebook.presto.hive.HiveConnector | From | To | |
| Rename Method public getColumnNames() : List<String> renamed to public getInputColumns() : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Rename Method public getTemporaryPath() : String renamed to public getWritePath() : String in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Rename Method public getTargetPath() : String renamed to public getFilePrefix() : String in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Inline Method | 1 | ||
| Inline Method private pathExists(path Path) : boolean inlined to public commitCreateTable(session ConnectorSession, tableHandle ConnectorOutputTableHandle, fragments Collection<Slice>) : void in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Rename Variable | 4 | ||
| Rename Variable recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in method public create(connectorId String, config Map<String,String>) : Connector in class com.facebook.presto.hive.HiveConnectorFactory | From | To | |
| Rename Variable columnNames : ImmutableList.Builder<String> to columnHandles : ImmutableList.Builder<HiveColumnHandle> in method private getColumnHandles(connectorId String, tableMetadata ConnectorTableMetadata) : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Rename Variable temporaryRoot : Path to writePath : String in method public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ConnectorRecordSinkProvider to ConnectorPageSinkProvider in method public getPageSinkProvider() : ConnectorPageSinkProvider in class com.facebook.presto.hive.HiveConnector | From | To | |
| Change Return Type List<String> to List<HiveColumnHandle> in method public getInputColumns() : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Change Return Type Collection<Slice> to void in method public commit() : void in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable properties : Properties to schema : Properties in method public HiveRecordWriter(schemaName String, tableName String, inputColumnNames List<String>, outputFormat String, serDe String, schema Properties, fileName String, writePath Path, typeManager TypeManager, conf JobConf) in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute temporaryPath : String to writePath : String in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Rename Attribute targetPath : String to filePrefix : String in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Rename Attribute columnNames : List<String> to inputColumns : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Rename Attribute recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in class com.facebook.presto.hive.HiveConnector | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type columnNames : List<String> to inputColumns : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveOutputTableHandle | From | To | |
| Change Attribute Type recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in class com.facebook.presto.hive.HiveConnector | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter recordSinkProvider : ConnectorRecordSinkProvider to pageSinkProvider : ConnectorPageSinkProvider in method public HiveConnector(lifeCycleManager LifeCycleManager, metadata ConnectorMetadata, splitManager ConnectorSplitManager, pageSourceProvider ConnectorPageSourceProvider, pageSinkProvider ConnectorPageSinkProvider, handleResolver ConnectorHandleResolver, systemTables Set<SystemTable>, sessionProperties List<PropertyMetadata<?>>, tableProperties List<PropertyMetadata<?>>, accessControl ConnectorAccessControl) in class com.facebook.presto.hive.HiveConnector | From | To | |
| Rename Parameter path : Path to temporaryPath : Path in method public createDirectory(hdfsEnvironment HdfsEnvironment, temporaryPath Path) : void in class com.facebook.presto.hive.HiveWriteUtils | From | To | |
| Rename Parameter target : Path to writePath : Path in method public HiveRecordWriter(schemaName String, tableName String, inputColumnNames List<String>, outputFormat String, serDe String, schema Properties, fileName String, writePath Path, typeManager TypeManager, conf JobConf) in class com.facebook.presto.hive.HivePageSink.HiveRecordWriter | From | To |