cf04cf0d4f9c39d8721619306ce5ef66c3b868f2
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 5 | ||
Change Parameter Type transactionManager : TransactionManager to catalogManager : CatalogManager in method private registerConnector(catalogManager CatalogManager, transactionManager TransactionManager, catalogName String, connectorId ConnectorId, connector Connector) : void in class com.facebook.presto.transaction.TestTransactionManager | From | To | |
Change Parameter Type metadata : Metadata to transactionManager : TransactionManager in method public CatalogSystemTable(transactionManager TransactionManager) in class com.facebook.presto.connector.system.CatalogSystemTable | From | To | |
Change Parameter Type metadata : Metadata to metadata : CatalogManager in method private updateConnectorIds(announcer Announcer, metadata CatalogManager, serverConfig ServerConfig, schedulerConfig NodeSchedulerConfig) : void in class com.facebook.presto.server.PrestoServer | From | To | |
Change Parameter Type metadata : Metadata to transactionManager : TransactionManager in method public CatalogJdbcTable(transactionManager TransactionManager) in class com.facebook.presto.connector.system.jdbc.CatalogJdbcTable | From | To | |
Change Parameter Type transactionManager : TransactionManager to catalogManager : CatalogManager in method private registerBogusConnector(catalogManager CatalogManager, transactionManager TransactionManager, catalogName String) : ConnectorId in class com.facebook.presto.security.TestAccessControlManager | From | To | |
Move Method | 1 | ||
Move Method public registerCatalog(catalog Catalog) : void from class com.facebook.presto.transaction.TransactionManager to public registerCatalog(catalog Catalog) : void from class com.facebook.presto.metadata.CatalogManager | From | To | |
Rename Variable | 1 | ||
Rename Variable catalogNames : Map<String,ConnectorId> to catalogs : List<Catalog> in method private updateConnectorIds(announcer Announcer, metadata CatalogManager, serverConfig ServerConfig, schedulerConfig NodeSchedulerConfig) : void in class com.facebook.presto.server.PrestoServer | From | To | |
Extract Class | 2 | ||
Extract Class com.facebook.presto.metadata.CatalogManager from class com.facebook.presto.transaction.TransactionManager | From | To | |
Extract Class com.facebook.presto.metadata.CatalogManager from class com.facebook.presto.connector.ConnectorManager | From | To | |
Rename Attribute | 2 | ||
Rename Attribute metadata : Metadata to transactionManager : TransactionManager in class com.facebook.presto.connector.system.CatalogSystemTable | From | To | |
Rename Attribute metadata : Metadata to transactionManager : TransactionManager in class com.facebook.presto.connector.system.jdbc.CatalogJdbcTable | From | To | |
Change Variable Type | 1 | ||
Change Variable Type catalogNames : Map<String,ConnectorId> to catalogs : List<Catalog> in method private updateConnectorIds(announcer Announcer, metadata CatalogManager, serverConfig ServerConfig, schedulerConfig NodeSchedulerConfig) : void in class com.facebook.presto.server.PrestoServer | From | To | |
Extract Method | 2 | ||
Extract Method public createTestTransactionManager(catalogManager CatalogManager) : TransactionManager extracted from public createTestTransactionManager() : TransactionManager in class com.facebook.presto.transaction.TransactionManager | From | To | |
Extract Method public createTestMetadataManager(catalogManager CatalogManager) : MetadataManager extracted from public createTestMetadataManager() : MetadataManager in class com.facebook.presto.metadata.MetadataManager | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type metadata : Metadata to transactionManager : TransactionManager in class com.facebook.presto.connector.system.CatalogSystemTable | From | To | |
Change Attribute Type metadata : Metadata to transactionManager : TransactionManager in class com.facebook.presto.connector.system.jdbc.CatalogJdbcTable | From | To | |
Rename Parameter | 4 | ||
Rename Parameter transactionManager : TransactionManager to catalogManager : CatalogManager in method private registerConnector(catalogManager CatalogManager, transactionManager TransactionManager, catalogName String, connectorId ConnectorId, connector Connector) : void in class com.facebook.presto.transaction.TestTransactionManager | From | To | |
Rename Parameter metadata : Metadata to transactionManager : TransactionManager in method public CatalogSystemTable(transactionManager TransactionManager) in class com.facebook.presto.connector.system.CatalogSystemTable | From | To | |
Rename Parameter metadata : Metadata to transactionManager : TransactionManager in method public CatalogJdbcTable(transactionManager TransactionManager) in class com.facebook.presto.connector.system.jdbc.CatalogJdbcTable | From | To | |
Rename Parameter transactionManager : TransactionManager to catalogManager : CatalogManager in method private registerBogusConnector(catalogManager CatalogManager, transactionManager TransactionManager, catalogName String) : ConnectorId in class com.facebook.presto.security.TestAccessControlManager | From | To |