d1cf4fbc456c3ccc731ba38eb9ed400e424a9d9f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private doMetadataDelete(storageFormat HiveStorageFormat, tableName SchemaTableName) : void renamed to private doTestMetadataDelete(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type metastore : ExtendedHiveMetastore to metastore : SemiTransactionalHiveMetastore in method public listAllDataPaths(metastore SemiTransactionalHiveMetastore, schemaName String, tableName String) : List<String> in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Rename Variable | 2 | ||
| Rename Variable writePath : Path to stagingPathRoot : Path in method private doInsertIntoExistingPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Rename Variable writePath : Path to stagingPathRoot : Path in method private doInsertIntoNewPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Inline Method | 2 | ||
| Inline Method private insertData(tableHandle ConnectorTableHandle, data MaterializedResult, session ConnectorSession) : void inlined to private doInsertIntoExistingPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Inline Method private insertData(tableHandle ConnectorTableHandle, data MaterializedResult, session ConnectorSession) : void inlined to private doInsertIntoNewPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ConnectorTransactionHandle to Transaction in method protected newTransaction() : Transaction in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable | 6 | ||
| Extract Variable queryId : String in method protected doCreateEmptyTable(tableName SchemaTableName, storageFormat HiveStorageFormat, createTableColumns List<ColumnMetadata>) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable stagingPathRoot : Path in method public testTableCreationRollback() : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable stagingPathRoot : Path in method private doInsertIntoNewPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable queryId : String in method protected doCreateTable(tableName SchemaTableName, storageFormat HiveStorageFormat) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable stagingPathRoot : Path in method private doInsertIntoExistingPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Variable stagingPathRoot : Path in method private doInsert(storageFormat HiveStorageFormat, tableName SchemaTableName) : void from class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type transaction : ConnectorTransactionHandle to transaction : Transaction in method private doInsertIntoNewPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Change Variable Type transaction : ConnectorTransactionHandle to transaction : Transaction in method private doInsertIntoExistingPartition(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To | |
| Extract Method | 1 | ||
| Extract Method private insertData(tableName SchemaTableName, data MaterializedResult) : String extracted from private doInsert(storageFormat HiveStorageFormat, tableName SchemaTableName) : void in class com.facebook.presto.hive.AbstractTestHiveClient | From | To |