presto e4967d2c8ffa33fe62005ef897ccf1b898e3826c

e4967d2c8ffa33fe62005ef897ccf1b898e3826c

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 8

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Variable	4
Rename Variable context : CompilerContext to thisVariable : Variable in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void in class com.facebook.presto.sql.gen.JoinCompiler	From	To
Rename Variable positionVariable : Variable to position : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Rename Variable outputVariable : Variable to output : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Rename Variable compilerContext : CompilerContext to thisVariable : Variable in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void in class com.facebook.presto.sql.gen.JoinCompiler	From	To
Change Variable Type	4
Change Variable Type context : CompilerContext to thisVariable : Variable in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void in class com.facebook.presto.sql.gen.JoinCompiler	From	To
Change Variable Type outputVariable : Variable to output : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Change Variable Type positionVariable : Variable to position : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Change Variable Type compilerContext : CompilerContext to thisVariable : Variable in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void in class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable	66
Extract Variable session : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable rightPosition : Parameter in method private generateCompareTo(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, sortTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>) : void from class com.facebook.presto.sql.gen.OrderingCompiler	From	To
Extract Variable leftBlockIndex : Parameter in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable leftBlockPosition : Parameter in method private generatePositionEqualsPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable count : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, projections int) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable value : Parameter in method private generateGroupedField(definition ClassDefinition, constructor MethodDefinition, ensureCapacity MethodDefinition, stateField StateField) : FieldDefinition from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable page : Parameter in method private generateAddInput(definition ClassDefinition, stateField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, parameterMetadatas List<ParameterMetadata>, inputFunction MethodHandle, callSiteBinder CallSiteBinder, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable pageBuilder : Parameter in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable blockIndex : Parameter in method private generateHashPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>, hashChannelField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable position : Parameter in method private generateHashRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable out : Parameter in method private generateSerialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable start : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable state : Parameter in method private generateDeserialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable leftPosition : Parameter in method private generateCompareTo(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, sortTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>) : void from class com.facebook.presto.sql.gen.OrderingCompiler	From	To
Extract Variable leftBlockIndex : Parameter in method private generatePositionEqualsPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable pageBuilder : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable stateSerializer : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable blockPosition : Parameter in method private generateHashPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>, hashChannelField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable thisVariable : Variable in method private generateAddIntermediateAsCombine(definition ClassDefinition, stateField FieldDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, combineFunction MethodHandle, singleStateClass Class<?>, callSiteBinder CallSiteBinder, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable index : Parameter in method private generateDeserialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable state : Parameter in method private generateSerialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable session : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable pageBuilder : Parameter in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, blockFields List<FieldDefinition>, positionField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Extract Variable blocks : List<Parameter> in method private generateFilterMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, filter RowExpression) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable cursor : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable out : Parameter in method private generateGroupedEvaluateIntermediate(definition ClassDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable rightBlocks : Parameter in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable session : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, projections int) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable position : Parameter in method private generateFilterMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, filter RowExpression) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable cursor : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, projections int) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable confidence : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable pagesIndex : Parameter in method private generateCompareTo(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, sortTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>) : void from class com.facebook.presto.sql.gen.OrderingCompiler	From	To
Extract Variable end : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable blockIndex : Parameter in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable value : Parameter in method private generateField(definition ClassDefinition, constructor MethodDefinition, stateField StateField) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable maskChannel : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable out : Parameter in method private generateGroupedEvaluateFinal(definition ClassDefinition, confidenceField FieldDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition, outputFunction MethodHandle, approximate boolean, callSiteBinder CallSiteBinder) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable out : Parameter in method private generateEvaluateIntermediate(definition ClassDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable session : Parameter in method private generateFilterMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, filter RowExpression) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable thisVariable : Variable in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable sampleWeightChannel : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable page : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, filter RowExpression, projections List<RowExpression>) : void from class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Extract Variable blocks : Parameter in method private generateHashRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable cursor : Parameter in method private generateFilterMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, filter RowExpression) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable out : Parameter in method private generateEvaluateFinal(definition ClassDefinition, confidenceField FieldDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition, outputFunction MethodHandle, approximate boolean, callSiteBinder CallSiteBinder) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable rightBlockIndex : Parameter in method private generatePositionEqualsPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable lookupSource : Parameter in method public internalCompileJoinOperatorFactory(types List<Type>, probeJoinChannel List<Integer>, probeHashChannel Optional<Integer>) : HashJoinOperatorFactoryFactory from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Extract Variable page : Parameter in method public internalCompileJoinOperatorFactory(types List<Type>, probeJoinChannel List<Integer>, probeHashChannel Optional<Integer>) : HashJoinOperatorFactoryFactory from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Extract Variable blockPosition : Parameter in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable output : Parameter in method private generateProjectMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, methodName String, projection RowExpression) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable groupId : Parameter in method private generateGroupedEvaluateIntermediate(definition ClassDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable rightBlockPosition : Parameter in method private generatePositionEqualsPositionMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable session : Parameter in method private generateFilterMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, filter RowExpression) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable rightPosition : Parameter in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable page : Parameter in method private generateConstructor(classDefinition ClassDefinition, probeChannels List<Integer>, probeHashChannel Optional<Integer>, lookupSourceField FieldDefinition, blockFields List<FieldDefinition>, probeChannelFields List<FieldDefinition>, probeBlocksArrayField FieldDefinition, probePageField FieldDefinition, probeHashBlockField FieldDefinition, positionField FieldDefinition, positionCountField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Extract Variable pageBuilder : Parameter in method private generateProcessMethod(classDefinition ClassDefinition, projections int) : void from class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Extract Variable block : Parameter in method private generateDeserialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Extract Variable leftBlockPosition : Parameter in method private generatePositionEqualsRowMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, joinChannelTypes List<Type>, joinChannelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable lookupSource : Parameter in method private generateConstructor(classDefinition ClassDefinition, probeChannels List<Integer>, probeHashChannel Optional<Integer>, lookupSourceField FieldDefinition, blockFields List<FieldDefinition>, probeChannelFields List<FieldDefinition>, probeBlocksArrayField FieldDefinition, probePageField FieldDefinition, probeHashBlockField FieldDefinition, positionField FieldDefinition, positionCountField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Extract Variable outputChannelOffset : Parameter in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, channelFields List<FieldDefinition>) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable stateFactory : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable hashChannel : Parameter in method private generateConstructor(classDefinition ClassDefinition, joinChannels List<Integer>, channelFields List<FieldDefinition>, joinChannelFields List<FieldDefinition>, hashChannelField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Extract Variable block : Variable in method public visitInputReference(node InputReferenceExpression, context CompilerContext) : ByteCodeNode from class com.facebook.presto.sql.gen.PageProcessorCompiler.fieldReferenceCompiler	From	To
Extract Variable inputChannels : Parameter in method private generateConstructor(definition ClassDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, inputChannelsField FieldDefinition, maskChannelField FieldDefinition, sampleWeightChannelField FieldDefinition, confidenceField FieldDefinition, stateField FieldDefinition, grouped boolean) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable groupId : Parameter in method private generateGroupedEvaluateFinal(definition ClassDefinition, confidenceField FieldDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition, outputFunction MethodHandle, approximate boolean, callSiteBinder CallSiteBinder) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler	From	To
Extract Variable channels : Parameter in method private generateConstructor(classDefinition ClassDefinition, joinChannels List<Integer>, channelFields List<FieldDefinition>, joinChannelFields List<FieldDefinition>, hashChannelField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinCompiler	From	To
Inline Variable	3
Inline Variable compilerContext : CompilerContext in method private generateSerialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To
Inline Variable page : ByteCodeExpression in method private generateConstructor(classDefinition ClassDefinition, probeChannels List<Integer>, probeHashChannel Optional<Integer>, lookupSourceField FieldDefinition, blockFields List<FieldDefinition>, probeChannelFields List<FieldDefinition>, probeBlocksArrayField FieldDefinition, probePageField FieldDefinition, probeHashBlockField FieldDefinition, positionField FieldDefinition, positionCountField FieldDefinition) : void from class com.facebook.presto.sql.gen.JoinProbeCompiler	From	To
Inline Variable compilerContext : CompilerContext in method private generateDeserialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void from class com.facebook.presto.operator.aggregation.state.StateCompiler	From	To

e4967d2c8ffa33fe62005ef897ccf1b898e3826c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: