e81d4324a717b2408e807154eef39d8588b6e3c4
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type channelFields : List<FieldDefinition> to outputChannelCount : int in method private generateGetChannelCountMethod(classDefinition ClassDefinition, outputChannelCount int) : void in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Rename Variable | 2 | ||
| Rename Variable index : int to outputChannel : int in method private generateAppendToMethod(classDefinition ClassDefinition, callSiteBinder CallSiteBinder, types List<Type>, outputChannels List<Integer>, channelFields List<FieldDefinition>) : void in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Rename Variable i : int to outputIndex : int in method public appendTo(blockIndex int, position int, pageBuilder PageBuilder, outputChannelOffset int) : void in class com.facebook.presto.operator.SimplePagesHashStrategy | From | To | |
| Extract Method | 4 | ||
| Extract Method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, outputChannels Optional<List<Integer>>) : Supplier<LookupSource> extracted from public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Extract Method public createPagesHashStrategy(joinChannels List<Integer>, hashChannel Optional<Integer>, outputChannels Optional<List<Integer>>) : PagesHashStrategy extracted from public createPagesHashStrategy(joinChannels List<Integer>, hashChannel Optional<Integer>) : PagesHashStrategy in class com.facebook.presto.operator.PagesIndex | From | To | |
| Extract Method public compileLookupSourceFactory(types List<? extends Type>, joinChannels List<Integer>, outputChannels Optional<List<Integer>>) : LookupSourceSupplierFactory extracted from public compileLookupSourceFactory(types List<? extends Type>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Extract Method public compilePagesHashStrategyFactory(types List<Type>, joinChannels List<Integer>, outputChannels Optional<List<Integer>>) : PagesHashStrategyFactory extracted from public compilePagesHashStrategyFactory(types List<Type>, joinChannels List<Integer>) : PagesHashStrategyFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter channelFields : List<FieldDefinition> to outputChannelCount : int in method private generateGetChannelCountMethod(classDefinition ClassDefinition, outputChannelCount int) : void in class com.facebook.presto.sql.gen.JoinCompiler | From | To |