presto e8a5a9063cadb5c6b775ad22e2c7b0f31f17a317

e8a5a9063cadb5c6b775ad22e2c7b0f31f17a317

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	5
Rename Method public getPartitionedSourceNode() : PlanNode renamed to public getPartitionedSourceNodes() : Set<PlanNode> in class com.facebook.presto.sql.planner.PlanFragment	From	To
Rename Method private findSource(node PlanNode, nodeId PlanNodeId) : PlanNode renamed to private findSources(node PlanNode, nodeIds Set<PlanNodeId>, nodes ImmutableSet.Builder<PlanNode>) : void in class com.facebook.presto.sql.planner.PlanFragment	From	To
Rename Method public getPartitionedSource() : PlanNodeId renamed to public getPartitionedSources() : List<PlanNodeId> in class com.facebook.presto.sql.planner.PlanFragment	From	To
Rename Method public getDistributeBy() : PlanNodeId renamed to public getPartitionedSources() : Set<PlanNodeId> in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Rename Method public setSourceDistribution(source PlanNodeId, partitioning PartitioningHandle) : FragmentProperties renamed to public addSourceDistribution(source PlanNodeId, distribution PartitioningHandle) : FragmentProperties in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Change Parameter Type	5
Change Parameter Type splits : Iterable<Split> to splits : Multimap<PlanNodeId,Split> in method public scheduleSplits(node Node, partition int, splits Multimap<PlanNodeId,Split>) : Set<RemoteTask> in class com.facebook.presto.execution.SqlStageExecution	From	To
Change Parameter Type splitSource : SplitSource to splitSources : Map<PlanNodeId,SplitSource> in method public FixedSourcePartitionedScheduler(stage SqlStageExecution, splitSources Map<PlanNodeId,SplitSource>, schedulingOrder List<PlanNodeId>, partitioning NodePartitionMap, splitBatchSize int, nodeSelector NodeSelector) in class com.facebook.presto.execution.scheduler.FixedSourcePartitionedScheduler	From	To
Change Parameter Type sourceSplits : Iterable<Split> to sourceSplits : Multimap<PlanNodeId,Split> in method private scheduleTask(node Node, partition int, sourceSplits Multimap<PlanNodeId,Split>) : RemoteTask in class com.facebook.presto.execution.SqlStageExecution	From	To
Change Parameter Type partitionedSource : PlanNodeId to partitionedSources : List<PlanNodeId> in method public PlanFragment(id PlanFragmentId, root PlanNode, symbols Map<Symbol,Type>, partitioning PartitioningHandle, partitionedSources List<PlanNodeId>, partitionFunction PartitionFunctionBinding) in class com.facebook.presto.sql.planner.PlanFragment	From	To
Change Parameter Type dataSource : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in method public StageExecutionPlan(fragment PlanFragment, splitSources Map<PlanNodeId,SplitSource>, subStages List<StageExecutionPlan>) in class com.facebook.presto.sql.planner.StageExecutionPlan	From	To
Rename Variable	3
Rename Variable currentSource : TaskSource to nextSource : TaskSource in method private schedulePartitionedSource(source TaskSource) : void in class com.facebook.presto.execution.SqlTaskExecution	From	To
Rename Variable newMaxAcknowledgedSplit : long to currentMaxAcknowledgedSplit : long in method private updateSources(sources List<TaskSource>) : Map<PlanNodeId,TaskSource> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Rename Variable splits : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in method public plan(root SubPlan, session Session) : StageExecutionPlan in class com.facebook.presto.sql.planner.DistributedExecutionPlanner	From	To
Change Return Type	34
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitRemoteSource(node RemoteSourceNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitTopNRowNumber(node TopNRowNumberNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitDelete(node DeleteNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitUnnest(node UnnestNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type PlanNodeId to Set<PlanNodeId> in method public getPartitionedSources() : Set<PlanNodeId> in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitUnion(node UnionNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitOutput(node OutputNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitTableWriter(node TableWriterNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitIndexJoin(node IndexJoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitSort(node SortNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitTopN(node TopNNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitProject(node ProjectNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type PlanNode to Set<PlanNode> in method public getPartitionedSourceNodes() : Set<PlanNode> in class com.facebook.presto.sql.planner.PlanFragment	From	To
Change Return Type PlanNode to void in method private findSources(node PlanNode, nodeIds Set<PlanNodeId>, nodes ImmutableSet.Builder<PlanNode>) : void in class com.facebook.presto.sql.planner.PlanFragment	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitDistinctLimit(node DistinctLimitNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitAggregation(node AggregationNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitSample(node SampleNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitJoin(node JoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitEnforceSingleRow(node EnforceSingleRowNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type PlanNodeId to List<PlanNodeId> in method public getPartitionedSources() : List<PlanNodeId> in class com.facebook.presto.sql.planner.PlanFragment	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitLimit(node LimitNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitExchange(node ExchangeNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitMetadataDelete(node MetadataDeleteNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitMarkDistinct(node MarkDistinctNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitSemiJoin(node SemiJoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitFilter(node FilterNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitGroupId(node GroupIdNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method protected visitPlan(node PlanNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitTableScan(node TableScanNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitValues(node ValuesNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitExplainAnalyze(node ExplainAnalyzeNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitTableFinish(node TableFinishNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitRowNumber(node RowNumberNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Return Type Optional<SplitSource> to Map<PlanNodeId,SplitSource> in method public visitWindow(node WindowNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Rename Attribute	2
Rename Attribute dataSource : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.StageExecutionPlan	From	To
Rename Attribute partitionedDriverFactory : DriverSplitRunnerFactory to partitionedDriverFactories : Map<PlanNodeId,DriverSplitRunnerFactory> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Change Variable Type	6
Change Variable Type splits : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in method public plan(root SubPlan, session Session) : StageExecutionPlan in class com.facebook.presto.sql.planner.DistributedExecutionPlanner	From	To
Change Variable Type sourceSplits : Optional<SplitSource> to sourceSplits : Map<PlanNodeId,SplitSource> in method public visitSemiJoin(node SemiJoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Variable Type leftSplits : Optional<SplitSource> to leftSplits : Map<PlanNodeId,SplitSource> in method public visitJoin(node JoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Variable Type filteringSourceSplits : Optional<SplitSource> to filteringSourceSplits : Map<PlanNodeId,SplitSource> in method public visitSemiJoin(node SemiJoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Variable Type rightSplits : Optional<SplitSource> to rightSplits : Map<PlanNodeId,SplitSource> in method public visitJoin(node JoinNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Change Variable Type nodeSplits : Optional<SplitSource> to nodeSplits : Map<PlanNodeId,SplitSource> in method public visitSample(node SampleNode, context Void) : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.DistributedExecutionPlanner.Visitor	From	To
Extract Variable	2
Extract Variable blocked : CompletableFuture<?> in method public schedule() : ScheduleResult from class com.facebook.presto.execution.scheduler.FixedSourcePartitionedScheduler	From	To
Extract Variable count : int in method public getPartitionedSplitCount() : int from class com.facebook.presto.execution.MockRemoteTaskFactory.MockRemoteTask	From	To
Change Attribute Type	2
Change Attribute Type dataSource : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in class com.facebook.presto.sql.planner.StageExecutionPlan	From	To
Change Attribute Type partitionedDriverFactory : DriverSplitRunnerFactory to partitionedDriverFactories : Map<PlanNodeId,DriverSplitRunnerFactory> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Extract Method	3
Extract Method private schedulePartitionedSource(source TaskSource) : void extracted from private updateSources(sources List<TaskSource>) : Map<PlanNodeId,TaskSource> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Extract Method private scheduleUnpartitionedSource(source TaskSource, updatedUnpartitionedSources Map<PlanNodeId,TaskSource>) : void extracted from private updateSources(sources List<TaskSource>) : Map<PlanNodeId,TaskSource> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Extract Method private isSchedulingSource(sourceId PlanNodeId) : boolean extracted from private updateSources(sources List<TaskSource>) : Map<PlanNodeId,TaskSource> in class com.facebook.presto.execution.SqlTaskExecution	From	To
Rename Parameter	4
Rename Parameter splitSource : SplitSource to splitSources : Map<PlanNodeId,SplitSource> in method public FixedSourcePartitionedScheduler(stage SqlStageExecution, splitSources Map<PlanNodeId,SplitSource>, schedulingOrder List<PlanNodeId>, partitioning NodePartitionMap, splitBatchSize int, nodeSelector NodeSelector) in class com.facebook.presto.execution.scheduler.FixedSourcePartitionedScheduler	From	To
Rename Parameter partitionedSource : PlanNodeId to partitionedSources : List<PlanNodeId> in method public PlanFragment(id PlanFragmentId, root PlanNode, symbols Map<Symbol,Type>, partitioning PartitioningHandle, partitionedSources List<PlanNodeId>, partitionFunction PartitionFunctionBinding) in class com.facebook.presto.sql.planner.PlanFragment	From	To
Rename Parameter dataSource : Optional<SplitSource> to splitSources : Map<PlanNodeId,SplitSource> in method public StageExecutionPlan(fragment PlanFragment, splitSources Map<PlanNodeId,SplitSource>, subStages List<StageExecutionPlan>) in class com.facebook.presto.sql.planner.StageExecutionPlan	From	To
Rename Parameter partitioning : PartitioningHandle to distribution : PartitioningHandle in method public addSourceDistribution(source PlanNodeId, distribution PartitioningHandle) : FragmentProperties in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To

e8a5a9063cadb5c6b775ad22e2c7b0f31f17a317

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: