f6dafa6356a654b65c95724ed2e8d1ba0a566647
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private sourceFinished() : void renamed to private checkAllSourcesFinished() : void in class com.facebook.presto.operator.exchange.LocalExchange | From | To | |
| Rename Variable | 2 | ||
| Rename Variable sinkFactory : LocalExchangeSinkFactory to newFactory : LocalExchangeSinkFactory in method public createSinkFactory() : LocalExchangeSinkFactory in class com.facebook.presto.operator.exchange.LocalExchange | From | To | |
| Rename Variable page : Page to actualPage : Page in method private assertRemovePage(source LocalExchangeSource, expectedPage Page) : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private maxBufferedBytes : long from class com.facebook.presto.operator.exchange.LocalExchange to private maxBufferedBytes : long from class com.facebook.presto.operator.exchange.LocalExchangeMemoryManager | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.operator.exchange.LocalExchangeMemoryManager from class com.facebook.presto.operator.exchange.LocalExchange | From | To | |
| Move Class | 3 | ||
| Move Class com.facebook.presto.operator.exchange.LocalExchange.LocalExchangeBufferInfo moved to com.facebook.presto.operator.exchange.LocalExchangeBufferInfo | From | To | |
| Move Class com.facebook.presto.operator.exchange.LocalExchange.LocalExchangeSource moved to com.facebook.presto.operator.exchange.LocalExchangeSource | From | To | |
| Move Class com.facebook.presto.operator.exchange.LocalExchange.LocalExchangeSink moved to com.facebook.presto.operator.exchange.LocalExchangeSink | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute sinkFactories : Set<LocalExchangeSinkFactory> to openSinkFactories : Set<LocalExchangeSinkFactory> in class com.facebook.presto.operator.exchange.LocalExchange | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type buffer : Queue<PageReference> to buffer : BlockingQueue<PageReference> in class com.facebook.presto.operator.exchange.LocalExchangeSource | From | To | |
| Extract Method | 9 | ||
| Extract Method private checkFinished() : void extracted from public removePage() : Page in class com.facebook.presto.operator.exchange.LocalExchangeSource | From | To | |
| Extract Method private createPage(i int) : Page extracted from public testBroadcast() : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Extract Method private checkFinished() : void extracted from public finish() : void in class com.facebook.presto.operator.exchange.LocalExchangeSource | From | To | |
| Extract Method private createPage(i int) : Page extracted from public testPartition() : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Extract Method private createPage(i int) : Page extracted from public writeUnblockWhenAllReadersFinishAndPagesConsumed() : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Extract Method private createPage(i int) : Page extracted from private assertSinkFinished(sink LocalExchangeSink) : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Extract Method private checkFinished() : void extracted from public close() : void in class com.facebook.presto.operator.exchange.LocalExchangeSource | From | To | |
| Extract Method private createPage(i int) : Page extracted from public testGatherSingleWriter() : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Extract Method private createPage(i int) : Page extracted from public testRandom() : void in class com.facebook.presto.operator.exchange.TestLocalExchange | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter sink : Consumer<Page> to exchanger : Consumer<Page> in method public LocalExchangeSink(types List<Type>, exchanger Consumer<Page>, memoryManager LocalExchangeMemoryManager, onFinish Consumer<LocalExchangeSink>) in class com.facebook.presto.operator.exchange.LocalExchangeSink | From | To |