fca5bff8d01cb03b1c0c3963752b51b180c656b8
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 6
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From ch.qos.logback:logback-classic 1.2.3 To 1.1.3 | |
| From ch.qos.logback:logback-core 1.2.3 To 1.1.3 | |
| From org.assertj:assertj-core 3.5.2 To 3.8.0 | |
| From ch.qos.logback:logback-classic 1.1.3 To 1.2.3 | |
| From ch.qos.logback:logback-core 1.1.3 To 1.2.3 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, nextFilter FilterChain) : void renamed to public authenticate(request HttpServletRequest) : Principal in class com.facebook.presto.server.security.KerberosAuthenticator | From | To | |
| Rename Method public setAuthenticationType(authenticationType AuthenticationType) : SecurityConfig renamed to public setAuthenticationTypes(authenticationTypes Set<AuthenticationType>) : SecurityConfig in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Rename Method public getAuthenticationType() : AuthenticationType renamed to public getAuthenticationTypes() : Set<AuthenticationType> in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type authenticationType : AuthenticationType to authenticationTypes : Set<AuthenticationType> in method public setAuthenticationTypes(authenticationTypes Set<AuthenticationType>) : SecurityConfig in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Move Method | 7 | ||
| Move Method public destroy() : void from class com.facebook.presto.server.security.SpnegoFilter to public destroy() : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method public destroy() : void from class com.facebook.presto.server.security.LdapFilter to public destroy() : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method private skipRequestBody(request HttpServletRequest) : void from class com.facebook.presto.server.security.SpnegoFilter to private skipRequestBody(request HttpServletRequest) : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method public init(filterConfig FilterConfig) : void from class com.facebook.presto.server.security.LdapFilter to public init(filterConfig FilterConfig) : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, nextFilter FilterChain) : void from class com.facebook.presto.server.security.LdapFilter to public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, nextFilter FilterChain) : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method public init(filterConfig FilterConfig) : void from class com.facebook.presto.server.security.SpnegoFilter to public init(filterConfig FilterConfig) : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Move Method private skipRequestBody(request HttpServletRequest) : void from class com.facebook.presto.server.security.LdapFilter to private skipRequestBody(request HttpServletRequest) : void from class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to Principal in method public authenticate(request HttpServletRequest) : Principal in class com.facebook.presto.server.security.KerberosAuthenticator | From | To | |
| Change Return Type AuthenticationType to Set<AuthenticationType> in method public getAuthenticationTypes() : Set<AuthenticationType> in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Extract Class | 2 | ||
| Extract Class com.facebook.presto.server.security.AuthenticationFilter from class com.facebook.presto.server.security.SpnegoFilter | From | To | |
| Extract Class com.facebook.presto.server.security.AuthenticationFilter from class com.facebook.presto.server.security.LdapFilter | From | To | |
| Rename Class | 2 | ||
| Rename Class com.facebook.presto.server.security.SpnegoFilter renamed to com.facebook.presto.server.security.KerberosAuthenticator | From | To | |
| Rename Class com.facebook.presto.server.security.LdapFilter renamed to com.facebook.presto.server.security.LdapAuthenticator | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute authenticationType : AuthenticationType to authenticationTypes : Set<AuthenticationType> in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Extract Method | 1 | ||
| Extract Method private withPrincipal(request HttpServletRequest, principal Principal) : ServletRequest extracted from public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, nextFilter FilterChain) : void in class com.facebook.presto.server.security.AuthenticationFilter | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type authenticationType : AuthenticationType to authenticationTypes : Set<AuthenticationType> in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter authenticationType : AuthenticationType to authenticationTypes : Set<AuthenticationType> in method public setAuthenticationTypes(authenticationTypes Set<AuthenticationType>) : SecurityConfig in class com.facebook.presto.server.security.SecurityConfig | From | To | |
| Rename Parameter header : String to base64EncodedCredentials : String in method private getCredentials(base64EncodedCredentials String) : Credentials in class com.facebook.presto.server.security.LdapAuthenticator | From | To | |
| Rename Parameter securityBinder : Binder to binder : Binder in method protected setup(binder Binder) : void in class com.facebook.presto.server.security.ServerSecurityModule | From | To |