presto fd4dc6324de2e210969aa43a05647af293fbcb17

fd4dc6324de2e210969aa43a05647af293fbcb17

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 14

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	20
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetLongDecimalColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetShortDecimalColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetIntColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetLongDecimalColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetIntColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetShortDecimalColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetLongColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetLongColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetFloatColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetFloatColumnReader	From	To
Rename Method public abstract skipValues(offsetNumber int) : void renamed to protected abstract skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetTimestampColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetBooleanColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetTimestampColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetBooleanColumnReader	From	To
Rename Method public abstract readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected abstract readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetBinaryColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetBinaryColumnReader	From	To
Rename Method public skipValues(offsetNumber int) : void renamed to protected skipValue() : void in class com.facebook.presto.hive.parquet.reader.ParquetDoubleColumnReader	From	To
Rename Method public readValues(blockBuilder BlockBuilder, valueNumber int, type Type) : void renamed to protected readValue(blockBuilder BlockBuilder, type Type) : void in class com.facebook.presto.hive.parquet.reader.ParquetDoubleColumnReader	From	To
Move And Inline Method	1
Move And Inline Method public createBlockBuilder(type Type) : BlockBuilder moved from class com.facebook.presto.hive.parquet.reader.ParquetBinaryColumnReader to class com.facebook.presto.hive.parquet.reader.ParquetColumnReader & inlined to public readPrimitive(type Type, positions IntList) : Block	From	To
Rename Variable	4
Rename Variable offsetNumber : int to offset : int in method private seek() : void in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To
Rename Variable interleavedBlock : InterleavedBlock to block : Block in method public readArray(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Rename Variable columnDescriptor : Optional<RichColumnDescriptor> to descriptor : Optional<RichColumnDescriptor> in method private readBlock(name String, type Type, path List<String>, offsets IntList) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Rename Variable valueNumber : int to numValues : int in method public readPrimitive(type Type, positions IntList) : Block in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To
Parameterize Variable	1
Parameterize Variable fieldType : Type to type : Type in method private readBlock(name String, type Type, path List<String>, offsets IntList) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Change Variable Type	1
Change Variable Type interleavedBlock : InterleavedBlock to block : Block in method public readArray(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Extract Variable	1
Extract Variable fieldName : String in method public getNextPage() : Page from class com.facebook.presto.hive.parquet.ParquetPageSource	From	To
Extract Method	6
Extract Method private getBlockOffsets(block Block, offsets IntList) : void extracted from public readStruct(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Extract Method private seek() : void extracted from public readPrimitive(type Type) : Block in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To
Extract Method public readMap(type Type, path List<String>) : Block extracted from public readStruct(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Extract Method public readArray(type Type, path List<String>) : Block extracted from public readStruct(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Extract Method private readBlock(name String, type Type, path List<String>, offsets IntList) : Block extracted from public readStruct(type Type, path List<String>) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Extract Method private readPrimitive(columnDescriptor ColumnDescriptor, type Type, offsets IntList) : Block extracted from public readPrimitive(columnDescriptor ColumnDescriptor, type Type) : Block in class com.facebook.presto.hive.parquet.reader.ParquetReader	From	To
Rename Parameter	1
Rename Parameter valueNumber : int to numValues : int in method private updatePosition(numValues int) : void in class com.facebook.presto.hive.parquet.reader.ParquetColumnReader	From	To

fd4dc6324de2e210969aa43a05647af293fbcb17

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: