ffe9f326eec62cb49697b0a854e7a3c6ce02e823
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type returnType : Class<?> to methodType : MethodType in method public invokeDynamic(bootstrapMethod Method, bootstrapArgs Iterable<? extends Object>, methodName String, methodType MethodType, parameters ByteCodeExpression...) : ByteCodeExpression in class com.facebook.presto.byteCode.expression.ByteCodeExpressions | From | To | |
Rename Variable | 2 | ||
Rename Variable scratchStateVariable : Variable to scratchState : Variable in method private generateAddIntermediateAsCombine(definition ClassDefinition, stateField FieldDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, combineFunction MethodHandle, singleStateClass Class<?>, callSiteBinder CallSiteBinder, grouped boolean) : void in class com.facebook.presto.operator.aggregation.AccumulatorCompiler | From | To | |
Rename Variable positionVariable : Variable to groupIdsBlock : Variable in method private generateEnsureCapacity(context CompilerContext, stateField FieldDefinition, block Block) : void in class com.facebook.presto.operator.aggregation.AccumulatorCompiler | From | To | |
Change Variable Type | 2 | ||
Change Variable Type ensureCapacity : Block to ensureCapacity : MethodDefinition in method private generateGroupedStateClass(clazz Class<T>, classLoader DynamicClassLoader) : Class<? extends T> in class com.facebook.presto.operator.aggregation.state.StateCompiler | From | To | |
Change Variable Type size : int to size : ByteCodeExpression in method private generateSerialize(definition ClassDefinition, clazz Class<T>, fields List<StateField>) : void in class com.facebook.presto.operator.aggregation.state.StateCompiler | From | To | |
Extract Variable | 2 | ||
Extract Variable getEstimatedSize : MethodDefinition in method private generateGroupedStateClass(clazz Class<T>, classLoader DynamicClassLoader) : Class<? extends T> from class com.facebook.presto.operator.aggregation.state.StateCompiler | From | To | |
Extract Variable method : MethodDefinition in method private generateEvaluateFinal(definition ClassDefinition, confidenceField FieldDefinition, stateSerializerField FieldDefinition, stateField FieldDefinition, outputFunction MethodHandle, approximate boolean, callSiteBinder CallSiteBinder) : void from class com.facebook.presto.operator.aggregation.AccumulatorCompiler | From | To | |
Extract Method | 2 | ||
Extract Method public invokeDynamic(bootstrapMethod Method, bootstrapArgs Iterable<? extends Object>, methodName String, returnType ParameterizedType, parameters Iterable<? extends ByteCodeExpression>) : ByteCodeExpression extracted from public invokeDynamic(bootstrapMethod Method, bootstrapArgs Iterable<? extends Object>, methodName String, returnType Class<?>, parameterTypes Iterable<? extends Class<?>>, parameters ByteCodeExpression...) : ByteCodeExpression in class com.facebook.presto.byteCode.expression.ByteCodeExpressions | From | To | |
Extract Method private generateEnsureCapacity(context CompilerContext, stateField FieldDefinition, block Block) : void extracted from private generateAddIntermediateAsCombine(definition ClassDefinition, stateField FieldDefinition, stateSerializerField FieldDefinition, stateFactoryField FieldDefinition, combineFunction MethodHandle, singleStateClass Class<?>, callSiteBinder CallSiteBinder, grouped boolean) : void in class com.facebook.presto.operator.aggregation.AccumulatorCompiler | From | To | |
Rename Parameter | 1 | ||
Rename Parameter returnType : Class<?> to methodType : MethodType in method public invokeDynamic(bootstrapMethod Method, bootstrapArgs Iterable<? extends Object>, methodName String, methodType MethodType, parameters ByteCodeExpression...) : ByteCodeExpression in class com.facebook.presto.byteCode.expression.ByteCodeExpressions | From | To |