004e022fbc30dc2e3c9942c379367dbb04b8bb35
Files Diff
- Added: 19
- Removed: 1
- Renamed: 0
- Modified: 34
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public isHttpRedirect() : boolean renamed to public isRedirect() : boolean in class com.yahoo.pulsar.broker.lookup.LookupResult | From | To | |
| Rename Method public init() : void renamed to public initNamespace() : void in class com.yahoo.pulsar.broker.admin.NamespacesTest | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public getBroker(destination DestinationName) : CompletableFuture<InetSocketAddress> from class com.yahoo.pulsar.client.impl.LookupService to public getBroker(destination DestinationName) : CompletableFuture<InetSocketAddress> from class com.yahoo.pulsar.client.impl.HttpLookupService | From | To | |
| Push Down Method public LookupService(httpClient HttpClient, useTls boolean) from class com.yahoo.pulsar.client.impl.LookupService to public HttpLookupService(httpClient HttpClient, useTls boolean) from class com.yahoo.pulsar.client.impl.HttpLookupService | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass com.yahoo.pulsar.client.impl.HttpLookupService from class com.yahoo.pulsar.client.impl.LookupService | From | To | |
| Rename Variable | 1 | ||
| Rename Variable clusterData : ClusterData to differentClusterData : ClusterData in method protected validateClusterOwnership(cluster String) : void in class com.yahoo.pulsar.broker.web.PulsarWebResource | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute private useTls : boolean from class com.yahoo.pulsar.client.impl.LookupService to private useTls : boolean from class com.yahoo.pulsar.client.impl.HttpLookupService | From | To | |
| Push Down Attribute private BasePath : String from class com.yahoo.pulsar.client.impl.LookupService to private BasePath : String from class com.yahoo.pulsar.client.impl.HttpLookupService | From | To | |
| Push Down Attribute private httpClient : HttpClient from class com.yahoo.pulsar.client.impl.LookupService to private httpClient : HttpClient from class com.yahoo.pulsar.client.impl.HttpLookupService | From | To | |
| Extract Variable | 2 | ||
| Extract Variable lookupUrl : String in method protected internalSetup() : void from class com.yahoo.pulsar.broker.auth.MockedPulsarServiceBaseTest | From | To | |
| Extract Variable lookupUrl : String in method protected internalSetupForStatsTest() : void from class com.yahoo.pulsar.broker.auth.MockedPulsarServiceBaseTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable appId : String in method protected validateAdminAccessOnProperty(property String) : void from class com.yahoo.pulsar.broker.web.PulsarWebResource | From | To | |
| Extract Method | 4 | ||
| Extract Method protected validateAdminAccessOnProperty(pulsar PulsarService, clientAppId String, property String) : void extracted from protected validateAdminAccessOnProperty(property String) : void in class com.yahoo.pulsar.broker.web.PulsarWebResource | From | To | |
| Extract Method protected checkAuthorization(pulsarService PulsarService, destination DestinationName, role String) : void extracted from protected checkConnect(destination DestinationName) : void in class com.yahoo.pulsar.broker.web.PulsarWebResource | From | To | |
| Extract Method protected isLeaderBroker(pulsar PulsarService) : boolean extracted from protected isLeaderBroker() : boolean in class com.yahoo.pulsar.broker.web.PulsarWebResource | From | To | |
| Extract Method protected startWebService(server ServerManager, config ServiceConfig) : void extracted from public init(configFile String) : void in class com.yahoo.pulsar.discovery.service.server.DiscoveryServiceStarter | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter destination : DestinationName to topic : DestinationName in method public getBroker(topic DestinationName) : CompletableFuture<InetSocketAddress> in class com.yahoo.pulsar.client.impl.LookupService | From | To |