pulsar 1386e6dfdba16bb1ee0a3c7649cb7daed50a5d8c

1386e6dfdba16bb1ee0a3c7649cb7daed50a5d8c

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 30

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method public getSinks(tenant String, namespace String) : List<String> renamed to public listSinks(tenant String, namespace String) : List<String> in class org.apache.pulsar.client.admin.Sink	From	To
Rename Method public getSinks(tenant String, namespace String) : List<String> renamed to public listSinks(tenant String, namespace String) : List<String> in class org.apache.pulsar.client.admin.internal.SinkImpl	From	To
Rename Method public getSources(tenant String, namespace String) : List<String> renamed to public listSources(tenant String, namespace String) : List<String> in class org.apache.pulsar.client.admin.Source	From	To
Rename Method public getSources(tenant String, namespace String) : List<String> renamed to public listSources(tenant String, namespace String) : List<String> in class org.apache.pulsar.client.admin.internal.SourceImpl	From	To
Move Method	14
Move Method protected validateSourceConfigs(sourceConfig SourceConfig) : void from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected validateSourceConfigs(sourceConfig SourceConfig) : void from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Method protected validateSinkType(sinkType String) : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected validateSinkType(sinkType String) : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method protected createSourceConfigProto2(sourceConfig SourceConfig) : Function.FunctionDetails from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected createSourceConfigProto2(sourceConfig SourceConfig) : Function.FunctionDetails from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Method protected createSinkConfigProto2(sinkConfig SinkConfig) : Function.FunctionDetails from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected createSinkConfigProto2(sinkConfig SinkConfig) : Function.FunctionDetails from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method protected inferMissingArguments(sinkConfig SinkConfig) : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected inferMissingArguments(sinkConfig SinkConfig) : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method private mergeArgs() : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to private mergeArgs() : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method package processArguments() : void from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource to package processArguments() : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method package processArguments() : void from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink to package processArguments() : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method protected parseConfigs(str String) : Map<String,Object> from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected parseConfigs(str String) : Map<String,Object> from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method private inferMissingArguments(sourceConfig SourceConfig) : void from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to private inferMissingArguments(sourceConfig SourceConfig) : void from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Method protected parseConfigs(str String) : Map<String,Object> from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected parseConfigs(str String) : Map<String,Object> from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method protected validateSourceType(sourceType String) : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected validateSourceType(sourceType String) : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Method protected validateSinkConfigs(sinkConfig SinkConfig) : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected validateSinkConfigs(sinkConfig SinkConfig) : void from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Method private mergeArgs() : void from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to private mergeArgs() : void from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Change Return Type	7
Change Return Type FunctionDetails to SinkConfig in method public getSink(tenant String, namespace String, sinkName String) : SinkConfig in class org.apache.pulsar.client.admin.internal.SinkImpl	From	To
Change Return Type Function.FunctionDetails to SinkConfig in method public getSink(tenant String, namespace String, sink String) : SinkConfig in class org.apache.pulsar.client.admin.Sink	From	To
Change Return Type Function.FunctionDetails to SourceConfig in method public getSource(tenant String, namespace String, source String) : SourceConfig in class org.apache.pulsar.client.admin.Source	From	To
Change Return Type FunctionDetails to FunctionConfig in method public getFunction(tenant String, namespace String, function String) : FunctionConfig in class org.apache.pulsar.client.admin.Functions	From	To
Change Return Type Collection<String> to Collection<FunctionMetaData> in method public listFunctions(tenant String, namespace String) : Collection<FunctionMetaData> in class org.apache.pulsar.functions.worker.FunctionMetaDataManager	From	To
Change Return Type FunctionDetails to FunctionConfig in method public getFunction(tenant String, namespace String, function String) : FunctionConfig in class org.apache.pulsar.client.admin.internal.FunctionsImpl	From	To
Change Return Type FunctionDetails to SourceConfig in method public getSource(tenant String, namespace String, sourceName String) : SourceConfig in class org.apache.pulsar.client.admin.internal.SourceImpl	From	To
Move Attribute	57
Move Attribute protected archive : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected archive : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected parallelism : Integer from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected parallelism : Integer from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected parallelism : Integer from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected parallelism : Integer from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected disk : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected disk : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_className : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_className : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected name : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected name : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_sourceConfigFile : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_sourceConfigFile : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected sinkConfigFile : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected sinkConfigFile : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected namespace : String from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource to protected namespace : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_sinkConfigString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_sinkConfigString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_deserializationClassName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_deserializationClassName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_sourceConfigString : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_sourceConfigString : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected timeoutMs : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected timeoutMs : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected topicsPattern : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected topicsPattern : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected tenant : String from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource to protected tenant : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected sinkType : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected sinkType : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_customSerdeInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_customSerdeInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected sinkConfigString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected sinkConfigString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected deserializationClassName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected deserializationClassName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected classLoader : NarClassLoader from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected classLoader : NarClassLoader from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_className : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_className : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected autoAck : boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected autoAck : boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected className : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected className : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected sourceConfigFile : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected sourceConfigFile : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_retainOrdering : Boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_retainOrdering : Boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected customSchemaInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected customSchemaInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_topicsPattern : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_topicsPattern : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected classLoader : NarClassLoader from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected classLoader : NarClassLoader from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected sourceConfig : SourceConfig from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected sourceConfig : SourceConfig from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected sourceConfigString : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected sourceConfigString : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected name : String from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink to protected name : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected customSerdeInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected customSerdeInputString : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected tenant : String from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink to protected tenant : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected sourceType : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected sourceType : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected cpu : Double from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected cpu : Double from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected processingGuarantees : FunctionConfig.ProcessingGuarantees from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected name : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected name : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected cpu : Double from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected cpu : Double from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected ram : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected ram : Long from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected schemaType : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected schemaType : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_destinationTopicName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected DEPRECATED_destinationTopicName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected subsName : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected subsName : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected DEPRECATED_sinkConfigFile : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_sinkConfigFile : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected namespace : String from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink to protected namespace : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected retainOrdering : boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected retainOrdering : boolean from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected sinkConfig : SinkConfig from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected sinkConfig : SinkConfig from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected name : String from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource to protected name : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected className : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected className : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected inputs : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected inputs : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Move Attribute protected archive : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected archive : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected disk : Long from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected disk : Long from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected ram : Long from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected ram : Long from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected destinationTopicName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceCommand to protected destinationTopicName : String from class org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand	From	To
Move Attribute protected DEPRECATED_subsName : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand to protected DEPRECATED_subsName : String from class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand	From	To
Extract Class	2
Extract Class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource	From	To
Extract Class org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink	From	To
Extract Superclass	2
Extract Superclass org.apache.pulsar.admin.cli.CmdSources.SourceDetailsCommand from classes [org.apache.pulsar.admin.cli.CmdSources.CreateSource, org.apache.pulsar.admin.cli.CmdSources.UpdateSource]	From	To
Extract Superclass org.apache.pulsar.admin.cli.CmdSinks.SinkDetailsCommand from classes [org.apache.pulsar.admin.cli.CmdSinks.CreateSink, org.apache.pulsar.admin.cli.CmdSinks.UpdateSink]	From	To
Move And Rename Attribute	2
Move And Rename Attribute protected name : String renamed to protected sinkName : String and moved from class org.apache.pulsar.admin.cli.CmdSinks.DeleteSink to class org.apache.pulsar.admin.cli.CmdSinks.SinkCommand	From	To
Move And Rename Attribute protected name : String renamed to protected sourceName : String and moved from class org.apache.pulsar.admin.cli.CmdSources.DeleteSource to class org.apache.pulsar.admin.cli.CmdSources.SourceCommand	From	To
Extract Variable	3
Extract Variable f1 : Function.FunctionMetaData in method public testListFunctions() : void from class org.apache.pulsar.functions.worker.FunctionMetaDataManagerTest	From	To
Extract Variable f2 : Function.FunctionMetaData in method public testListFunctions() : void from class org.apache.pulsar.functions.worker.FunctionMetaDataManagerTest	From	To
Extract Variable f3 : Function.FunctionMetaData in method public testListFunctions() : void from class org.apache.pulsar.functions.worker.FunctionMetaDataManagerTest	From	To
Change Variable Type	2
Change Variable Type ret : List<String> to ret : List<FunctionMetaData> in method public listFunctions(tenant String, namespace String) : Collection<FunctionMetaData> in class org.apache.pulsar.functions.worker.FunctionMetaDataManager	From	To
Change Variable Type functionStateList : Collection<String> to functionStateList : Collection<FunctionMetaData> in method public listFunctions(tenant String, namespace String, componentType String) : Response in class org.apache.pulsar.functions.worker.rest.api.FunctionsImpl	From	To
Rename Parameter	4
Rename Parameter functionName : String to componentName : String in method private validateUpdateRequestParams(tenant String, namespace String, componentName String, uploadedInputStreamAsFile File, fileDetail FormDataContentDisposition, functionDetailsJson String, componentConfigJson String, componentType String) : FunctionDetails in class org.apache.pulsar.functions.worker.rest.api.FunctionsImpl	From	To
Rename Parameter functionName : String to componentName : String in method public updateFunction(tenant String, namespace String, componentName String, uploadedInputStream InputStream, fileDetail FormDataContentDisposition, functionPkgUrl String, functionDetailsJson String, componentConfigJson String, componentType String, clientRole String) : Response in class org.apache.pulsar.functions.worker.rest.api.FunctionsImpl	From	To
Rename Parameter functionName : String to componentName : String in method public registerFunction(tenant String, namespace String, componentName String, uploadedInputStream InputStream, fileDetail FormDataContentDisposition, functionPkgUrl String, functionDetailsJson String, componentConfigJson String, componentType String, clientRole String) : Response in class org.apache.pulsar.functions.worker.rest.api.FunctionsImpl	From	To
Rename Parameter functionName : String to componentName : String in method private validateUpdateRequestParamsWithPkgUrl(tenant String, namespace String, componentName String, functionPkgUrl String, functionDetailsJson String, componentConfigJson String, componentType String) : FunctionDetails in class org.apache.pulsar.functions.worker.rest.api.FunctionsImpl	From	To

1386e6dfdba16bb1ee0a3c7649cb7daed50a5d8c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: