1e02afb29fb3016f8a2ea8851c3b0fa56b4be85b
Files Diff
- Added: 21
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type manager : LoadManager to manager : AtomicReference<LoadManager> in method public LoadReportUpdaterTask(manager AtomicReference<LoadManager>) in class com.yahoo.pulsar.broker.loadbalance.LoadReportUpdaterTask | From | To | |
| Change Parameter Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in method public LoadSheddingTask(loadManager AtomicReference<LoadManager>) in class com.yahoo.pulsar.broker.loadbalance.LoadSheddingTask | From | To | |
| Change Parameter Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in method public LoadResourceQuotaUpdaterTask(loadManager AtomicReference<LoadManager>) in class com.yahoo.pulsar.broker.loadbalance.LoadResourceQuotaUpdaterTask | From | To | |
| Move Method | 2 | ||
| Move Method private getBundleRangeFromBundleName(bundleName String) : String from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl to public getBundleRangeFromBundleName(bundleName String) : String from class com.yahoo.pulsar.broker.loadbalance.impl.LoadManagerShared | From | To | |
| Move Method private getNamespaceNameFromBundleName(bundleName String) : String from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl to public getNamespaceNameFromBundleName(bundleName String) : String from class com.yahoo.pulsar.broker.loadbalance.impl.LoadManagerShared | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute public LOADBALANCE_BROKERS_ROOT : String from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl to public LOADBALANCE_BROKERS_ROOT : String from class com.yahoo.pulsar.broker.loadbalance.LoadManager | From | To | |
| Extract Class | 1 | ||
| Extract Class com.yahoo.pulsar.broker.loadbalance.impl.LoadManagerShared from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Extract Variable | 2 | ||
| Extract Variable rank : Long in method private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Extract Variable resourceUnits : Set<ResourceUnit> in method private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> from class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Extract Method | 1 | ||
| Extract Method public initialize(pulsar PulsarService) : void extracted from public SimpleLoadManagerImpl(pulsar PulsarService) in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Rename Method | 1 | ||
| Rename Method public getPulsarServieUrlTls() : String renamed to public getPulsarServiceUrlTls() : String in class com.yahoo.pulsar.common.policies.data.loadbalancer.LoadReport | From | To | |
| Rename Variable | 4 | ||
| Rename Variable finalCandidates : Multimap<Long,ResourceUnit> to result : Multimap<Long,ResourceUnit> in method private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Rename Variable ru : ResourceUnit to resourceUnit : ResourceUnit in method private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Rename Variable matchedShared : Multimap<Long,ResourceUnit> to result : Multimap<Long,ResourceUnit> in method private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Inline Method | 4 | ||
| Inline Method private getFinalCandidatesNoPolicy(shared Multimap<Long,ResourceUnit>) : Multimap<Long,ResourceUnit> inlined to private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Inline Method private getFinalCandidatesWithPolicy(namespace NamespaceName, primaries Multimap<Long,ResourceUnit>, shared Multimap<Long,ResourceUnit>) : Multimap<Long,ResourceUnit> inlined to private getFinalCandidates(serviceUnit ServiceUnitId, availableBrokers Map<Long,Set<ResourceUnit>>) : Multimap<Long,ResourceUnit> in class com.yahoo.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type LoadManager to AtomicReference<LoadManager> in method public getLoadManager() : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.PulsarService | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute pulsarServieUrlTls : String to pulsarServiceUrlTls : String in class com.yahoo.pulsar.common.policies.data.loadbalancer.LoadReport | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.yahoo.pulsar.common.policies.data.loadbalancer.ServiceLookupData from classes [com.yahoo.pulsar.common.policies.data.loadbalancer.LoadReport] | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.PulsarService | From | To | |
| Change Attribute Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.loadbalance.LoadReportUpdaterTask | From | To | |
| Change Attribute Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.namespace.NamespaceService | From | To | |
| Change Attribute Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.loadbalance.LoadSheddingTask | From | To | |
| Change Attribute Type loadManager : LoadManager to loadManager : AtomicReference<LoadManager> in class com.yahoo.pulsar.broker.loadbalance.LoadResourceQuotaUpdaterTask | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter pulsarServieUrlTls : String to pulsarServiceUrlTls : String in method public LoadReport(webServiceUrl String, webServiceUrlTls String, pulsarServiceUrl String, pulsarServiceUrlTls String) in class com.yahoo.pulsar.common.policies.data.loadbalancer.LoadReport | From | To |