9348d34e830f558e3fc0ca096115bcc0d569ab0d
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private verifyAuthenticationIfNeeded(connect CommandConnect) : boolean renamed to private authenticateAndCreateClient(connect CommandConnect) : boolean in class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Move Method | 3 | ||
| Move Method package getConnectionPool() : ConnectionPool from class org.apache.pulsar.proxy.server.ProxyService to package getConnectionPool() : ConnectionPool from class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Move Method public getClientAuthentication() : Authentication from class org.apache.pulsar.proxy.server.ProxyService to public getClientAuthentication() : Authentication from class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Move Method package newRequestId() : long from class org.apache.pulsar.proxy.server.ProxyService to package newRequestId() : long from class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Inline Method | 2 | ||
| Inline Method public newLookup(topic String, authoritative boolean, originalAuthRole String, originalAuthData String, originalAuthMethod String, requestId long) : ByteBuf inlined to public newLookup(topic String, authoritative boolean, requestId long) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Inline Method public newPartitionMetadataRequest(topic String, requestId long, originalAuthRole String, originalAuthData String, originalAuthMethod String) : ByteBuf inlined to public newPartitionMetadataRequest(topic String, requestId long) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private client : PulsarClientImpl from class org.apache.pulsar.proxy.server.ProxyService to private client : PulsarClientImpl from class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Move Attribute private clientAuthentication : Authentication from class org.apache.pulsar.proxy.server.ProxyService to private clientAuthentication : Authentication from class org.apache.pulsar.proxy.server.ProxyConnection | From | To | |
| Extract Method | 2 | ||
| Extract Method protected newConnectCommand() : ByteBuf extracted from public channelActive(ctx ChannelHandlerContext) : void in class org.apache.pulsar.client.impl.ClientCnx | From | To | |
| Extract Method public close() : void extracted from public channelActive(ctx ChannelHandlerContext) : void in class org.apache.pulsar.client.impl.ClientCnx | From | To |