bddfa2a5a233f17b93cb756b289b40d587321e4c
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public hashFinished() : boolean renamed to public hasFinished() : boolean in class org.apache.pulsar.sql.presto.PulsarRecordCursor.ReadEntries | From | To | |
| Change Parameter Type | 13 | ||
| Change Parameter Type subscription : String to entryId : long in method public verifyChecksum(topic TopicName, headersAndPayload ByteBuf, ledgerId long, entryId long) : boolean in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Change Parameter Type bytes : byte[] to payload : ByteBuf in method public deserialize(payload ByteBuf) : Object in class org.apache.pulsar.sql.presto.SchemaHandler | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public abstract getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.PropertiesColumn | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.KeyColumn | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.SequenceIdColumn | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.ProducerNameColumn | From | To | |
| Change Parameter Type topic : String to topic : TopicName in method public verifyChecksum(topic TopicName, headersAndPayload ByteBuf, ledgerId long, entryId long) : boolean in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.EventTimeColumn | From | To | |
| Change Parameter Type bytes : byte[] to payload : ByteBuf in method public deserialize(payload ByteBuf) : Object in class org.apache.pulsar.sql.presto.AvroSchemaHandler | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.MessageIdColumn | From | To | |
| Change Parameter Type message : Message to message : RawMessage in method public getData(message RawMessage) : Object in class org.apache.pulsar.sql.presto.PulsarInternalColumn.PublishTimeColumn | From | To | |
| Change Parameter Type topic : String to topic : TopicName in method public uncompressPayloadIfNeeded(topic TopicName, msgMetadata MessageMetadata, payload ByteBuf, ledgerId long, entryId long) : ByteBuf in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.pulsar.client.impl.MessageParser moved to org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable messageId : MessageIdData to ledgerId : long in method public parseMessage(topicName TopicName, ledgerId long, entryId long, headersAndPayload ByteBuf, processor MessageProcessor) : void in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Split Parameter | 2 | ||
| Split Parameter messageId : MessageIdData to [ledgerId : long, entryId : long] in method public verifyChecksum(topic TopicName, headersAndPayload ByteBuf, ledgerId long, entryId long) : boolean in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Split Parameter topicName : TopicName to [ledgerId : long, entryId : long] in method public parseMessage(topicName TopicName, ledgerId long, entryId long, headersAndPayload ByteBuf, processor MessageProcessor) : void in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type messages : List<Message<?>> to messages : List<RawMessage> in method public testWithoutBatches() : void in class org.apache.pulsar.client.impl.MessageParserTest | From | To | |
| Change Variable Type messages : List<Message<?>> to messages : List<RawMessage> in method public testWithBatches() : void in class org.apache.pulsar.client.impl.MessageParserTest | From | To | |
| Change Variable Type messageId : MessageIdData to ledgerId : long in method public parseMessage(topicName TopicName, ledgerId long, entryId long, headersAndPayload ByteBuf, processor MessageProcessor) : void in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type currentMessage : Message to currentMessage : RawMessage in class org.apache.pulsar.sql.presto.PulsarRecordCursor | From | To | |
| Change Attribute Type messageQueue : SpscArrayQueue<Message> to messageQueue : SpscArrayQueue<RawMessage> in class org.apache.pulsar.sql.presto.PulsarRecordCursor | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter subscription : String to entryId : long in method public verifyChecksum(topic TopicName, headersAndPayload ByteBuf, ledgerId long, entryId long) : boolean in class org.apache.pulsar.common.api.raw.MessageParser | From | To | |
| Rename Parameter bytes : byte[] to payload : ByteBuf in method public deserialize(payload ByteBuf) : Object in class org.apache.pulsar.sql.presto.SchemaHandler | From | To | |
| Rename Parameter bytes : byte[] to payload : ByteBuf in method public deserialize(payload ByteBuf) : Object in class org.apache.pulsar.sql.presto.AvroSchemaHandler | From | To |