f36b70cd6fb249cd54d1f63fe55e3a4e3203d168
Files Diff
- Added: 18
- Removed: 0
- Renamed: 0
- Modified: 19
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From io.prometheus:simpleclient_hotspot 0.0.21 To 0.0.23 | |
| From io.prometheus:simpleclient_servlet 0.0.21 To 0.0.23 | |
| From io.prometheus:simpleclient 0.0.21 To 0.0.23 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public newLookupResponse(error ServerError, errorMsg String, requestId long) : ByteBuf renamed to public newLookupErrorResponse(error ServerError, errorMsg String, requestId long) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type cmdConnect : CommandConnect to clientProtocolVersion : int in method public newConnected(clientProtocolVersion int) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Rename Variable | 2 | ||
| Rename Variable connectionLookupResponse : CommandLookupTopicResponse to commandLookupTopicResponse : CommandLookupTopicResponse in method public newLookupResponse(brokerServiceUrl String, brokerServiceUrlTls String, authoritative boolean, response LookupType, requestId long, proxyThroughServiceUrl boolean) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Rename Variable connectionBuilder : CommandLookupTopicResponse.Builder to commandLookupTopicResponseBuilder : CommandLookupTopicResponse.Builder in method public newLookupResponse(brokerServiceUrl String, brokerServiceUrlTls String, authoritative boolean, response LookupType, requestId long, proxyThroughServiceUrl boolean) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To | |
| Change Return Type | 4 | ||
| Change Return Type CompletableFuture<InetSocketAddress> to CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in method public getBroker(destination DestinationName) : CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in class org.apache.pulsar.client.impl.BinaryProtoLookupService | From | To | |
| Change Return Type CompletableFuture<InetSocketAddress> to CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in method private findBroker(socketAddress InetSocketAddress, authoritative boolean, destination DestinationName) : CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in class org.apache.pulsar.client.impl.BinaryProtoLookupService | From | To | |
| Change Return Type CompletableFuture<InetSocketAddress> to CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in method public getBroker(destination DestinationName) : CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in class org.apache.pulsar.client.impl.HttpLookupService | From | To | |
| Change Return Type CompletableFuture<InetSocketAddress> to CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in method public getBroker(topic DestinationName) : CompletableFuture<Pair<InetSocketAddress,InetSocketAddress>> in class org.apache.pulsar.client.impl.LookupService | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [brokerUrl : String, brokerUrlTls : String, authoritative : boolean] to result : CommandLookupTopicResponse in method public LookupDataResult(result CommandLookupTopicResponse) in class org.apache.pulsar.client.impl.BinaryProtoLookupService.LookupDataResult | From | To | |
| Extract Method | 1 | ||
| Extract Method public getConnection(logicalAddress InetSocketAddress, physicalAddress InetSocketAddress) : CompletableFuture<ClientCnx> extracted from public getConnection(address InetSocketAddress) : CompletableFuture<ClientCnx> in class org.apache.pulsar.client.impl.ConnectionPool | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter address : InetSocketAddress to logicalAddress : InetSocketAddress in method private createConnection(logicalAddress InetSocketAddress, physicalAddress InetSocketAddress, connectionKey int) : CompletableFuture<ClientCnx> in class org.apache.pulsar.client.impl.ConnectionPool | From | To | |
| Rename Parameter cmdConnect : CommandConnect to clientProtocolVersion : int in method public newConnected(clientProtocolVersion int) : ByteBuf in class org.apache.pulsar.common.api.Commands | From | To |