387ed744b8bb49a49f9cd41adfd500c4592d2027
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 3 | ||
| Pull Up Method private connect(cfg BaseMasterSlaveServersConfig<?>, addr URI) : RFuture<RedisConnection> from class org.redisson.connection.ReplicatedConnectionManager to protected connectToNode(cfg BaseMasterSlaveServersConfig<?>, addr URI, client RedisClient) : RFuture<RedisConnection> from class org.redisson.connection.MasterSlaveConnectionManager | From | To | |
| Pull Up Method private close(conn RedisConnection) : void from class org.redisson.cluster.ClusterConnectionManager to protected closeNodeConnection(conn RedisConnection) : void from class org.redisson.connection.MasterSlaveConnectionManager | From | To | |
| Pull Up Method private connect(cfg ClusterServersConfig, addr URI) : RFuture<RedisConnection> from class org.redisson.cluster.ClusterConnectionManager to protected connectToNode(cfg BaseMasterSlaveServersConfig<?>, addr URI, client RedisClient) : RFuture<RedisConnection> from class org.redisson.connection.MasterSlaveConnectionManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type cfg : ClusterServersConfig to cfg : BaseMasterSlaveServersConfig<?> in method protected connectToNode(cfg BaseMasterSlaveServersConfig<?>, addr URI, client RedisClient) : RFuture<RedisConnection> in class org.redisson.connection.MasterSlaveConnectionManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type RFuture<RedisPubSubConnection> to RFuture<Void> in method private registerSentinel(cfg SentinelServersConfig, addr URI, c MasterSlaveServersConfig) : RFuture<Void> in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Extract Variable | 1 | ||
| Extract Variable key : String in method private registerSentinel(cfg SentinelServersConfig, addr URI, c MasterSlaveServersConfig) : RFuture<Void> from class org.redisson.connection.SentinelConnectionManager | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type connectionFutures : List<RFuture<RedisPubSubConnection>> to connectionFutures : List<RFuture<Void>> in method public SentinelConnectionManager(cfg SentinelServersConfig, config Config) in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Change Variable Type future : RFuture<RedisPubSubConnection> to future : RFuture<Void> in method public SentinelConnectionManager(cfg SentinelServersConfig, config Config) in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Extract Method | 2 | ||
| Extract Method protected addSlave(ip String, port String, slaveAddr String) : RFuture<Void> extracted from protected onSlaveAdded(addr URI, msg String) : void in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Extract Method protected isUseSameMaster(slaveIp String, slavePort String, slaveMasterHost String, slaveMasterPort String) : boolean extracted from private isUseSameMaster(parts String[]) : boolean in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type slaves : ConcurrentMap<String,Boolean> to slaves : Set<String> in class org.redisson.connection.SentinelConnectionManager | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected closeNodeConnections() : void extracted from public shutdown() : void in class org.redisson.connection.ReplicatedConnectionManager & moved to class org.redisson.connection.MasterSlaveConnectionManager | From | To | |
| Extract And Move Method protected closeNodeConnections() : void extracted from public shutdown() : void in class org.redisson.cluster.ClusterConnectionManager & moved to class org.redisson.connection.MasterSlaveConnectionManager | From | To |