df1519575e490f1e6fe6cd847ea913e86e38b1aa
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 1 | ||
| Move And Inline Method public isAtomic() : boolean moved from class org.redisson.api.BatchOptions to class org.redisson.command.CommandBatchService & inlined to public executeAsync(options BatchOptions) : RFuture<R> | From | To | |
| Replace Variable With Attribute | 5 | ||
| Replace Variable With Attribute options : BatchOptions to batchOptions : BatchOptions in method public testBigRequestAtomic() : void in class org.redisson.RedissonBatchTest | From | To | |
| Replace Variable With Attribute options : BatchOptions to batchOptions : BatchOptions in method public testAtomicSyncSlaves() : void in class org.redisson.RedissonBatchTest | From | To | |
| Replace Variable With Attribute options : BatchOptions to batchOptions : BatchOptions in method public testAtomic() : void in class org.redisson.RedissonBatchTest | From | To | |
| Replace Variable With Attribute options : BatchOptions to batchOptions : BatchOptions in method public testSyncSlaves() : void in class org.redisson.RedissonBatchTest | From | To | |
| Replace Variable With Attribute options : BatchOptions to batchOptions : BatchOptions in method public testSkipResult() : void in class org.redisson.RedissonBatchTest | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type transactionFuture : RFuture<Object> to transactionFuture : RFuture<List<?>> in method public operationComplete(future Future<Map<HashKey,HashValue>>) : void in class org.redisson.transaction.RedissonTransaction.commitAsync.addListener | From | To | |
| Change Variable Type future : RFuture<Object> to future : RFuture<List<?>> in method public rollbackAsync() : RFuture<Void> in class org.redisson.transaction.RedissonTransaction | From | To | |
| Change Variable Type iter : Iterator<Runnable> to iter : Iterator<Entry> in method public release() : void in class org.redisson.pubsub.AsyncSemaphore | From | To | |
| Extract Variable | 1 | ||
| Extract Variable entry : Entry in method public release() : void from class org.redisson.pubsub.AsyncSemaphore | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type executed : boolean to executed : AtomicBoolean in class org.redisson.command.CommandBatchService | From | To | |
| Change Attribute Type listeners : Set<Runnable> to listeners : Set<Entry> in class org.redisson.pubsub.AsyncSemaphore | From | To | |
| Extract Method | 17 | ||
| Extract Method private createOptions() : BatchOptions extracted from public commit(localCaches Set<String>, operations List<TransactionalOperation>) : void in class org.redisson.transaction.RedissonTransaction | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public writeAsync(entry MasterSlaveEntry, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public writeAsync(key String, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAsync(key String, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected handleError(promise RPromise<R>, cause Throwable) : void extracted from private checkAttemptFuture(source NodeSource, details AsyncDetails<V,R>, future Future<R>, ignoreRedirect boolean) : void in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAsync(client RedisClient, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected handleSuccess(promise RPromise<R>, command RedisCommand<?>, res R) : void extracted from private checkAttemptFuture(source NodeSource, details AsyncDetails<V,R>, future Future<R>, ignoreRedirect boolean) : void in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readRandomAsync(command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method private createOptions() : BatchOptions extracted from public commitAsync() : RFuture<Void> in class org.redisson.transaction.RedissonTransaction | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAllAsync(command RedisCommand<T>, params Object...) : RFuture<Collection<R>> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from private evalAsync(nodeSource NodeSource, readOnlyMode boolean, codec Codec, evalCommandType RedisCommand<T>, script String, keys List<Object>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAsync(client RedisClient, name String, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method public acquire(listener Runnable, permits int) : void extracted from public acquire(listener Runnable) : void in class org.redisson.pubsub.AsyncSemaphore | From | To | |
| Extract Method protected completeResponse(data CommandData<Object,Object>, result Object, channel Channel) : void extracted from private handleResult(data CommandData<Object,Object>, parts List<Object>, result Object, multiResult boolean, channel Channel) : void in class org.redisson.client.handler.CommandDecoder | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAsync(entry MasterSlaveEntry, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected getConnection(readOnlyMode boolean, source NodeSource, command RedisCommand<V>) : RFuture<RedisConnection> extracted from protected async(readOnlyMode boolean, source NodeSource, codec Codec, command RedisCommand<V>, params Object[], mainPromise RPromise<R>, attempt int, ignoreRedirect boolean) : void in class org.redisson.command.CommandAsyncService | From | To | |
| Extract Method protected createPromise() : RPromise<R> extracted from public readAsync(client RedisClient, entry MasterSlaveEntry, codec Codec, command RedisCommand<T>, params Object...) : RFuture<R> in class org.redisson.command.CommandAsyncService | From | To |