sonarqube 102faa7f46c509fd2bf7f3d933b78375ca2f4166

102faa7f46c509fd2bf7f3d933b78375ca2f4166

Files Diff

Added: 7
Removed: 4
Renamed: 0
Modified: 30

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	14
Rename Method public create_session() : void renamed to public create_token() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public generate_csrf_state() : void renamed to public generate_csrf_state_when_creating_token() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public remove_session_when_user_is_disabled() : void renamed to public validate_token_fails_with_unauthorized_when_user_is_disabled() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public refresh_state_when_refreshing_token() : void renamed to public validate_token_refresh_state_when_refreshing_token() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public refresh_session_when_refresh_time_is_reached() : void renamed to public validate_token_refresh_session_when_refresh_time_is_reached() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public remove_state_when_removing_token() : void renamed to public validate_token_remove_state_when_removing_token() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public does_nothing_when_no_jwt_cookie() : void renamed to public validate_token_does_nothing_when_no_jwt_cookie() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public does_nothing_when_empty_value_in_jwt_cookie() : void renamed to public validate_token_does_nothing_when_empty_value_in_jwt_cookie() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public remove_session_when_token_is_no_more_valid() : void renamed to public validate_token_removes_session_when_token_is_no_more_valid() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public use_session_timeout_from_settings() : void renamed to public generate_token_is_using_session_timeout_from_settings() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public verify_csrf_state() : void renamed to public validate_token_verify_csrf_state() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method private removeSession(request HttpServletRequest, response HttpServletResponse) : void renamed to package removeToken(response HttpServletResponse) : void in class org.sonar.server.authentication.JwtHttpHandler	From	To
Rename Method public does_not_refresh_session_when_refresh_time_is_not_reached() : void renamed to public validate_token_does_not_refresh_session_when_refresh_time_is_not_reached() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Rename Method public remove_session_when_disconnected_timeout_is_reached() : void renamed to public validate_token_removes_session_when_disconnected_timeout_is_reached() : void in class org.sonar.server.authentication.JwtHttpHandlerTest	From	To
Change Parameter Type	1
Change Parameter Type userLogin : String to user : UserDto in method package generateToken(user UserDto, response HttpServletResponse) : void in class org.sonar.server.authentication.JwtHttpHandler	From	To
Change Return Type	7
Change Return Type void to boolean in method private validateScmAccounts(dbSession DbSession, scmAccounts List<String>, login String, email String, existingUser UserDto, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type String to boolean in method private validateLoginFormat(login String, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type void to boolean in method private checkNotEmptyParam(value String, param String, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type void to boolean in method private validatePasswords(password String, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type void to boolean in method private validateEmailFormat(email String, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type void to boolean in method private checkPasswordChangeAllowed(userDto UserDto, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Change Return Type void to boolean in method private validateNameFormat(name String, messages List<Message>) : boolean in class org.sonar.server.user.UserUpdater	From	To
Move Attribute	16
Move Attribute private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticator to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactory	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.GenerateJwtTokenFilterTest to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactory	From	To
Move Attribute private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticator to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactory	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticatorTest to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactory	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticatorTest to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactoryTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.GenerateJwtTokenFilterTest to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactory	From	To
Move Attribute private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticator to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Move Attribute public userSession : UserSessionRule from class org.sonar.server.authentication.GenerateJwtTokenFilterTest to public userSession : UserSessionRule from class org.sonar.server.authentication.ValidateJwtTokenFilterTest	From	To
Move Attribute private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticator to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.AuthLoginActionTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.GenerateJwtTokenFilterTest to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Move Attribute public userSession : UserSessionRule from class org.sonar.server.authentication.JwtHttpHandlerTest to public userSession : UserSessionRule from class org.sonar.server.authentication.ValidateJwtTokenFilterTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticatorTest to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.AuthLoginActionTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticatorTest to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Move Attribute private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticator to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactoryTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.GenerateJwtTokenFilterTest to package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.BaseContextFactoryTest	From	To
Move Attribute package jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.UserIdentityAuthenticatorTest to private jwtHttpHandler : JwtHttpHandler from class org.sonar.server.authentication.OAuth2ContextFactory	From	To
Rename Class	1
Rename Class org.sonar.server.authentication.GenerateJwtTokenFilter renamed to org.sonar.server.authentication.AuthLoginAction	From	To
Merge Parameter	1
Merge Parameter [authorizationDao : AuthorizationDao, resourceDao : ResourceDao] to dbClient : DbClient in method private ServerUserSession(dbClient DbClient, userDto UserDto) in class org.sonar.server.user.ServerUserSession	From	To
Extract Variable	1
Extract Variable updateUser : UpdateUser in method private reactivateUser(dbSession DbSession, existingUser UserDto, login String, newUser NewUser) : boolean from class org.sonar.server.user.UserUpdater	From	To
Inline Variable	4
Inline Variable componentKey : String in method public has_component_permission() : void from class org.sonar.server.user.ServerUserSessionTest	From	To
Inline Variable componentKey : String in method public has_component_permission_with_only_global_permission() : void from class org.sonar.server.user.ServerUserSessionTest	From	To
Inline Variable componentUuid : String in method public has_component_uuid_permission_with_only_global_permission() : void from class org.sonar.server.user.ServerUserSessionTest	From	To
Inline Variable componentUuid : String in method public has_component_uuid_permission() : void from class org.sonar.server.user.ServerUserSessionTest	From	To
Extract Method	9
Extract Method private newCallbackContext() : OAuth2IdentityProvider.CallbackContext extracted from public redirect_to_requested_page_with_context() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newInitContext() : OAuth2IdentityProvider.InitContext extracted from public generate_csrf_state() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newInitContext() : OAuth2IdentityProvider.InitContext extracted from public redirect_to() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newCallbackContext() : OAuth2IdentityProvider.CallbackContext extracted from public redirect_to_requested_page() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newCallbackContext() : OAuth2IdentityProvider.CallbackContext extracted from public verify_csrf_state() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newCallbackContext() : OAuth2IdentityProvider.CallbackContext extracted from public authenticate() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newCallbackContext() : OAuth2IdentityProvider.CallbackContext extracted from public create_callback() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newInitContext() : OAuth2IdentityProvider.InitContext extracted from public create_context() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Extract Method private newInitContext() : OAuth2IdentityProvider.InitContext extracted from public fail_to_get_callback_url_on_not_secured_server() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Rename Parameter	1
Rename Parameter userLogin : String to user : UserDto in method package generateToken(user UserDto, response HttpServletResponse) : void in class org.sonar.server.authentication.JwtHttpHandler	From	To

102faa7f46c509fd2bf7f3d933b78375ca2f4166

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: