sonarqube 1344e8d8b8f8d75129405024adfa566ce3593384

1344e8d8b8f8d75129405024adfa566ce3593384

Files Diff

Added: 5
Removed: 2
Renamed: 0
Modified: 30

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	1
Change Parameter Type populateRuleDto : Consumer<RuleDto> to populaters : Consumer<RuleDto>... in method public insertRule(organization OrganizationDto, populaters Consumer<RuleDto>...) : RuleDto in class org.sonar.db.rule.RuleDbTester	From	To
Move Attribute	2
Move Attribute private defaultOrganizationProvider : DefaultOrganizationProvider from class org.sonar.server.rule.index.RuleIndexer to private defaultOrganizationProvider : DefaultOrganizationProvider from class org.sonar.server.rule.RegisterRules	From	To
Move Attribute private dbClient : DbClient from class org.sonar.server.rule.index.RuleIndexer to private dbClient : DbClient from class org.sonar.server.rule.index.RuleIteratorFactory	From	To
Extract Class	1
Extract Class org.sonar.server.rule.index.RuleIteratorFactory from class org.sonar.server.rule.index.RuleIndexer	From	To
Rename Class	1
Rename Class org.sonar.server.rule.index.RuleResultSetIteratorTest renamed to org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Change Variable Type	4
Change Variable Type rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public iterator_over_rules() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Change Variable Type rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public removed_rule_is_returned() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Change Variable Type rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public iterator_over_one_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Change Variable Type rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public custom_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Extract Variable	2
Extract Variable ruleDefinitionDto : RuleDefinitionDto in method public bulk_activation() : void from class org.sonar.server.qualityprofile.RuleActivatorMediumTest	From	To
Extract Variable bulk : BulkIndexer in method public index(organization OrganizationDto, ruleKey RuleKey) : void from class org.sonar.server.rule.index.RuleIndexer	From	To
Extract Method	37
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_custom_rules_from_template_key() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private getResults() : List<RuleDoc> extracted from public custom_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public return_lang_field() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public return_mandatory_fields_even_when_setting_f_param() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_2_rules() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_profile_active_rules_with_inheritance() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private getResults() : List<RuleDoc> extracted from public iterator_over_one_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_2_rules_with_fields_selection() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_debt_rules_with_default_linear_offset_and_overridden_linear_debt() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public available_since() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public statuses_facet_should_be_sticky() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public filter_by_key_rules() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_all_active_rules() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_debt_rules_with_default_and_overridden_debt_values() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_all_active_rules_params() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_template_rules() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public sort_by_name() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_profile_active_rules() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public get_note_as_markdown_and_html() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public return_lang_key_field_when_language_name_is_not_available() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private getResults() : List<RuleDoc> extracted from public removed_rule_is_returned() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public return_lang_name_field() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_rules_with_deprecated_fields() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private getResults() : List<RuleDoc> extracted from public iterator_over_rules() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public search_debt_rules_with_default_linear_offset_and_overridden_constant_debt() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Extract Method private insertRule(definition RuleDefinitionDto) : void extracted from public filter_by_tags() : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Rename Method	1
Rename Method protected doIndex(lastUpdatedAt long) : long renamed to public index(organization OrganizationDto, ruleKey RuleKey) : void in class org.sonar.server.rule.index.RuleIndexer	From	To
Rename Variable	6
Rename Variable rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public iterator_over_one_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Rename Variable activeRules : List<RuleDefinitionDto> to removedRules : List<RuleDefinitionDto> in method public start() : void in class org.sonar.server.rule.RegisterRules	From	To
Rename Variable rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public removed_rule_is_returned() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Rename Variable rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public custom_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Rename Variable rule : RuleDoc to templateDoc : RuleDoc in method public iterator_over_one_rule() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Rename Variable rulesByKey : Map<String,RuleDoc> to results : List<RuleDoc> in method public iterator_over_rules() : void in class org.sonar.server.rule.index.RuleIteratorForSingleChunkTest	From	To
Change Return Type	4
Change Return Type void to RuleKey in method private updateExistingRule(ruleDto RuleDefinitionDto, newRule NewCustomRule, dbSession DbSession) : RuleKey in class org.sonar.server.rule.RuleCreator	From	To
Change Return Type long to void in method private doIndex(bulk BulkIndexer, rules Iterator<RuleDoc>) : void in class org.sonar.server.rule.index.RuleIndexer	From	To
Change Return Type void to boolean in method private registerRule(ruleDef RulesDefinition.Rule, allRules Map<RuleKey,RuleDefinitionDto>, session DbSession) : boolean in class org.sonar.server.rule.RegisterRules	From	To
Change Return Type long to void in method public index(organization OrganizationDto, ruleKey RuleKey) : void in class org.sonar.server.rule.index.RuleIndexer	From	To
Parameterize Variable	4
Parameterize Variable rule : RuleDefinitionDto to definition : RuleDefinitionDto in method private insertRule(definition RuleDefinitionDto) : void in class org.sonar.server.rule.ws.SearchActionMediumTest	From	To
Rename Attribute	3
Rename Attribute defaultOrganizationProvider : DefaultOrganizationProvider to ruleIteratorFactory : RuleIteratorFactory in class org.sonar.server.rule.index.RuleIndexer	From	To
Rename Attribute ruleService : RuleService to ruleIndexer : RuleIndexer in class org.sonar.server.rule.ws.ShowActionMediumTest	From	To
Rename Attribute dbClient : DbClient to esClient : EsClient in class org.sonar.server.rule.index.RuleIndexer	From	To
Change Attribute Type	3
Change Attribute Type defaultOrganizationProvider : DefaultOrganizationProvider to ruleIteratorFactory : RuleIteratorFactory in class org.sonar.server.rule.index.RuleIndexer	From	To
Change Attribute Type ruleService : RuleService to ruleIndexer : RuleIndexer in class org.sonar.server.rule.ws.ShowActionMediumTest	From	To
Change Attribute Type dbClient : DbClient to esClient : EsClient in class org.sonar.server.rule.index.RuleIndexer	From	To
Rename Parameter	1
Rename Parameter populateRuleDto : Consumer<RuleDto> to populaters : Consumer<RuleDto>... in method public insertRule(organization OrganizationDto, populaters Consumer<RuleDto>...) : RuleDto in class org.sonar.db.rule.RuleDbTester	From	To

1344e8d8b8f8d75129405024adfa566ce3593384

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: