175b5abd3a59664d3d638287a0f6ace8f39ea9c2
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 9 | ||
| Rename Method public fail_to_remove_last_sysadmin_permission() : void renamed to public fail_to_remove_last_admin_permission() : void in class org.sonar.server.permission.ws.RemoveGroupActionTest | From | To | |
| Rename Method public delete_last_system_admin_group_if_admin_user_left() : void renamed to public delete_admin_group_fails_if_no_admin_users_left() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Rename Method private shouldSkip(dbSession DbSession, change GroupPermissionChange) : boolean renamed to private removePermission(dbSession DbSession, change GroupPermissionChange) : boolean in class org.sonar.server.permission.GroupPermissionChanger | From | To | |
| Rename Method public fail_to_remove_sysadmin_permission_if_no_more_sysadmins() : void renamed to public fail_to_remove_admin_permission_if_no_more_admins() : void in class org.sonar.server.permission.GroupPermissionChangerTest | From | To | |
| Rename Method public selectAnyonePermissions() : void renamed to public selectProjectPermissionsOfGroup() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
| Rename Method private checkAdminUsersExistOutsideTheRemovedGroup(dbSession DbSession, change GroupPermissionChange) : void renamed to private checkIfRemainingGlobalAdministrators(dbSession DbSession, change GroupPermissionChange) : void in class org.sonar.server.permission.GroupPermissionChanger | From | To | |
| Rename Method private checkNotTryingToDeleteLastSystemAdminGroup(dbSession DbSession, group GroupId) : void renamed to private checkNotTryingToDeleteLastAdminGroup(dbSession DbSession, group GroupId) : void in class org.sonar.server.usergroups.ws.DeleteAction | From | To | |
| Rename Method public delete_system_admin_group_if_not_last() : void renamed to public delete_admin_group_succeeds_if_other_groups_have_administrators() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Rename Method public selectGroupPermissions() : void renamed to public selectGlobalPermissionsOfGroup() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
| Rename Variable | 5 | ||
| Rename Variable defaultOrg : OrganizationDto to org : OrganizationDto in method public delete_admin_group_succeeds_if_other_groups_have_administrators() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Rename Variable lastGroup : GroupDto to adminGroup : GroupDto in method public delete_admin_group_fails_if_no_admin_users_left() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Rename Variable funkyAdmins : GroupDto to adminGroup1 : GroupDto in method public delete_admin_group_succeeds_if_other_groups_have_administrators() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Rename Variable project : ComponentDto to project1 : ComponentDto in method public selectProjectPermissionsOfGroup() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
| Rename Variable boringAdmins : GroupDto to adminGroup2 : GroupDto in method public delete_admin_group_succeeds_if_other_groups_have_administrators() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Variable | 3 | ||
| Extract Variable groupId : long in method public fail_if_id_does_not_exist() : void from class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Variable defaultOrganization : OrganizationDto in method public add_project_permission_to_anyone() : void from class org.sonar.server.permission.GroupPermissionChangerTest | From | To | |
| Extract Variable defaultOrganization : OrganizationDto in method public add_permission_to_anyone() : void from class org.sonar.server.permission.GroupPermissionChangerTest | From | To | |
| Extract Method | 9 | ||
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public fail_if_id_does_not_exist() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public cannot_delete_default_group_of_default_organization() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public delete_members() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public delete_by_name_on_default_organization() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private addPermission(dbSession DbSession, change GroupPermissionChange) : boolean extracted from public apply(dbSession DbSession, change GroupPermissionChange) : boolean in class org.sonar.server.permission.GroupPermissionChanger | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public delete_permissions() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private loadExistingPermissions(dbSession DbSession, change GroupPermissionChange) : List<String> extracted from private shouldSkip(dbSession DbSession, change GroupPermissionChange) : boolean in class org.sonar.server.permission.GroupPermissionChanger | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public cannot_delete_last_system_admin_group() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To | |
| Extract Method private loginAsAdminOnDefaultOrganization() : void extracted from public delete_by_id() : void in class org.sonar.server.usergroups.ws.DeleteActionTest | From | To |