1c0b9a97e3bc6d58c4697b4350b39adc81a6efc1
Files Diff
- Added: 19
- Removed: 8
- Renamed: 0
- Modified: 74
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public selectChangelogOfUnresolvedIssuesByComponent(componentUuid String) : List<IssueChangeDto> renamed to public selectChangelogOfNonClosedIssuesByComponent(componentUuid String) : List<IssueChangeDto> in class org.sonar.core.issue.db.IssueChangeDao | From | To | |
| Rename Method private checkCharacteristicsAreInitialized() : void renamed to private checkInitialized() : void in class org.sonar.server.computation.debt.DebtModelHolderImpl | From | To | |
| Rename Method public selectChangelogOfUnresolvedIssuesByComponent() : void renamed to public selectChangelogOfNonClosedIssuesByComponent() : void in class org.sonar.core.issue.db.IssueChangeDaoTest | From | To | |
| Rename Method public loadComponentUuids() : Set<String> renamed to public loadUuidsOfComponentsWithOpenIssues() : Set<String> in class org.sonar.server.computation.issue.BaseIssuesLoader | From | To | |
| Change Parameter Type | 8 | ||
| Change Parameter Type ruleCache : RuleCache to ruleRepository : RuleRepository in method public PersistIssuesStep(dbClient DbClient, system2 System2, conflictResolver UpdateConflictResolver, ruleRepository RuleRepository, issueCache IssueCache) in class org.sonar.server.computation.step.PersistIssuesStep | From | To | |
| Change Parameter Type debtChangelog : List<IssueChangeDto> to debtChangelog : Collection<IssueChangeDto> in method public calculate(issue DefaultIssue, debtChangelog Collection<IssueChangeDto>, period Period) : long in class org.sonar.server.computation.issue.NewDebtCalculator | From | To | |
| Change Parameter Type ruleCache : RuleCache to ruleRepository : RuleRepository in method public BaseIssuesLoader(reportReader BatchReportReader, treeRootHolder TreeRootHolder, dbClient DbClient, ruleRepository RuleRepository) in class org.sonar.server.computation.issue.BaseIssuesLoader | From | To | |
| Change Parameter Type line : int to line : Integer in method package associateManualIssueToLine(manualIssue BASE, line Integer) : void in class org.sonar.core.issue.tracking.Tracking | From | To | |
| Change Parameter Type debtChangelog : List<IssueChangeDto> to debtChangelog : Collection<IssueChangeDto> in method private calculateFromChangelog(issue DefaultIssue, debtChangelog Collection<IssueChangeDto>, periodDate long) : long in class org.sonar.server.computation.issue.NewDebtCalculator | From | To | |
| Change Parameter Type ruleCache : RuleCache to ruleRepository : RuleRepository in method public DebtAggregator(ruleRepository RuleRepository, debtModelHolder DebtModelHolder, metricRepository MetricRepository, measureRepository MeasureRepository) in class org.sonar.server.computation.issue.DebtAggregator | From | To | |
| Change Parameter Type ruleCache : RuleCache to ruleRepository : RuleRepository in method public RuleTagsCopier(ruleRepository RuleRepository) in class org.sonar.server.computation.issue.RuleTagsCopier | From | To | |
| Change Parameter Type rules : RuleCache to rules : RuleRepository in method public SendIssueNotificationsStep(issueCache IssueCache, rules RuleRepository, treeRootHolder TreeRootHolder, service NotificationService, reportReader BatchReportReader, newIssuesNotificationFactory NewIssuesNotificationFactory) in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Rename Variable | 2 | ||
| Rename Variable lineHash : String to baseHash : String in method private relocateManualIssues(rawInput Input<RAW>, baseInput Input<BASE>, tracking Tracking<RAW,BASE>) : void in class org.sonar.core.issue.tracking.Tracker | From | To | |
| Rename Variable map : Map<Integer,HashOccurrence> to occurrencesByHash : Map<Integer,HashOccurrence> in method package match(rawInput Input<RAW>, baseInput Input<BASE>, tracking Tracking<RAW,BASE>) : void in class org.sonar.core.issue.tracking.BlockRecognizer | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Map<RuleKey,RuleDto> to Map<RuleKey,Rule> in method public loadAll(keys Collection<? extends RuleKey>) : Map<RuleKey,Rule> in class org.sonar.server.computation.issue.RuleCacheLoader | From | To | |
| Change Return Type RuleDto to Rule in method public load(key RuleKey) : Rule in class org.sonar.server.computation.issue.RuleCacheLoader | From | To | |
| Change Return Type void to MutableDebtModelHolder in method public addCharacteristics(rootCharacteristic Characteristic, subCharacteristics Iterable<? extends Characteristic>) : MutableDebtModelHolder in class org.sonar.server.computation.debt.MutableDebtModelHolder | From | To | |
| Change Return Type void to DebtModelHolderImpl in method public addCharacteristics(rootCharacteristic Characteristic, subCharacteristics Iterable<? extends Characteristic>) : DebtModelHolderImpl in class org.sonar.server.computation.debt.DebtModelHolderImpl | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public metricRepository : MetricRepositoryRule from class org.sonar.server.computation.step.PersistMeasuresStepTest to public metricRepository : MetricRepositoryRule from class org.sonar.server.computation.issue.DebtAggregatorTest | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonar.server.computation.issue.DebtAggregatorTest from class org.sonar.server.computation.step.PersistMeasuresStepTest | From | To | |
| Rename Class | 2 | ||
| Rename Class org.sonar.server.computation.issue.RuleCache renamed to org.sonar.server.computation.issue.RuleRepository | From | To | |
| Rename Class org.sonar.server.computation.issue.CountIssuesListenerTest renamed to org.sonar.server.computation.issue.IssueCounterTest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.sonar.server.computation.issue.BaseIssuesLoader.ToRuleKey moved and renamed to org.sonar.core.rule.RuleKeyFunctions.StringToRuleKey | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.RuleTagsCopier | From | To | |
| Rename Attribute ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.DebtAggregator | From | To | |
| Rename Attribute ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.BaseIssuesLoader | From | To | |
| Rename Attribute ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.step.PersistIssuesStep | From | To | |
| Extract Variable | 2 | ||
| Extract Variable jsRule : Rule in method public load_by_key() : void from class org.sonar.server.computation.issue.RuleCacheLoaderTest | From | To | |
| Extract Variable javaRule : Rule in method public load_by_key() : void from class org.sonar.server.computation.issue.RuleCacheLoaderTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type line : int to line : Integer in method private fillExistingOpenIssues(component Component, tracking Tracking<DefaultIssue,DefaultIssue>, cacheAppender DiskCache<DefaultIssue>) : void in class org.sonar.server.computation.step.IntegrateIssuesStep | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.RuleTagsCopier | From | To | |
| Change Attribute Type ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.BaseIssuesLoader | From | To | |
| Change Attribute Type ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.issue.DebtAggregator | From | To | |
| Change Attribute Type ruleCache : RuleCache to ruleRepository : RuleRepository in class org.sonar.server.computation.step.PersistIssuesStep | From | To | |
| Change Attribute Type rules : RuleCache to rules : RuleRepository in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter ruleCache : RuleCache to ruleRepository : RuleRepository in method public DebtAggregator(ruleRepository RuleRepository, debtModelHolder DebtModelHolder, metricRepository MetricRepository, measureRepository MeasureRepository) in class org.sonar.server.computation.issue.DebtAggregator | From | To | |
| Rename Parameter ruleCache : RuleCache to ruleRepository : RuleRepository in method public RuleTagsCopier(ruleRepository RuleRepository) in class org.sonar.server.computation.issue.RuleTagsCopier | From | To | |
| Rename Parameter ruleCache : RuleCache to ruleRepository : RuleRepository in method public BaseIssuesLoader(reportReader BatchReportReader, treeRootHolder TreeRootHolder, dbClient DbClient, ruleRepository RuleRepository) in class org.sonar.server.computation.issue.BaseIssuesLoader | From | To | |
| Rename Parameter ruleCache : RuleCache to ruleRepository : RuleRepository in method public PersistIssuesStep(dbClient DbClient, system2 System2, conflictResolver UpdateConflictResolver, ruleRepository RuleRepository, issueCache IssueCache) in class org.sonar.server.computation.step.PersistIssuesStep | From | To |