1d4bc6788cb482bb8b45e29f5bd4fca06c0e99f9
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private matchLine(range BatchReport.TextRange, line int) : boolean renamed to private isLineInBlock(range TextBlock, line int) : boolean in class org.sonar.server.computation.source.DuplicationLineReader | From | To | |
| Change Parameter Type | 7 | ||
| Change Parameter Type duplications : List<BatchReport.Duplication> to duplications : BatchReport.Duplication... in method public putDuplications(componentRef int, duplications BatchReport.Duplication...) : void in class org.sonar.server.computation.batch.BatchReportReaderRule | From | To | |
| Change Parameter Type range : BatchReport.TextRange to textBlock : TextBlock in method private appendDuplication(xml StringBuilder, componentKey String, textBlock TextBlock) : void in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Change Parameter Type duplications : Iterator<BatchReport.Duplication> to duplications : Iterable<Duplication> in method private saveDuplications(component Component, duplications Iterable<Duplication>) : void in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Change Parameter Type duplicate : BatchReport.Duplicate to duplicate : Duplicate in method private appendDuplication(xml StringBuilder, componentKey String, duplicate Duplicate) : void in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Change Parameter Type duplications : Iterator<BatchReport.Duplication> to duplications : Iterable<Duplication> in method private createXmlDuplications(componentKey String, duplications Iterable<Duplication>) : String in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Change Parameter Type reportReader : BatchReportReader to duplicationRepository : DuplicationRepository in method public PersistDuplicationsStep(dbClient DbClient, dbIdsRepository DbIdsRepository, treeRootHolder ReportTreeRootHolder, duplicationRepository DuplicationRepository) in class org.sonar.server.computation.step.PersistDuplicationsStep | From | To | |
| Change Parameter Type range : BatchReport.TextRange to range : TextBlock in method private isLineInBlock(range TextBlock, line int) : boolean in class org.sonar.server.computation.source.DuplicationLineReader | From | To | |
| Inline Method | 1 | ||
| Inline Method private visitComponent(component Component) : void inlined to public visitFile(file Component) : void in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Rename Variable | 2 | ||
| Rename Variable duplicationBlock : BatchReport.Duplicate to duplicate : Duplicate in method private createXmlDuplications(componentKey String, duplications Iterable<Duplication>) : String in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Rename Variable block : BatchReport.TextRange to textBlockIndex : Integer in method public read(lineBuilder DbFileSources.Line.Builder) : void in class org.sonar.server.computation.source.DuplicationLineReader | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public reportReader : BatchReportReaderRule from class org.sonar.server.computation.step.PersistDuplicationsStepTest to public reportReader : BatchReportReaderRule from class org.sonar.server.computation.step.LoadDuplicationsFromReportStepTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute reportReader : BatchReportReader to duplicationRepository : DuplicationRepository in class org.sonar.server.computation.step.PersistDuplicationsStep | From | To | |
| Rename Attribute reportReader : BatchReportReaderRule to duplicationRepository : DuplicationRepositoryRule in class org.sonar.server.computation.step.PersistDuplicationsStepTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type duplicationBlock : BatchReport.Duplicate to duplicate : Duplicate in method private createXmlDuplications(componentKey String, duplications Iterable<Duplication>) : String in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To | |
| Change Variable Type block : BatchReport.TextRange to textBlockIndex : Integer in method public read(lineBuilder DbFileSources.Line.Builder) : void in class org.sonar.server.computation.source.DuplicationLineReader | From | To | |
| Extract Method | 5 | ||
| Extract Method private duplicationLineReader(duplications Duplication...) : DuplicationLineReader extracted from public read_many_duplications() : void in class org.sonar.server.computation.source.DuplicationLineReaderTest | From | To | |
| Extract Method private duplicationLineReader(duplications Duplication...) : DuplicationLineReader extracted from public read_duplication_with_duplicates_on_other_file() : void in class org.sonar.server.computation.source.DuplicationLineReaderTest | From | To | |
| Extract Method private duplicationLineReader(duplications Duplication...) : DuplicationLineReader extracted from public should_be_sorted_by_line_length() : void in class org.sonar.server.computation.source.DuplicationLineReaderTest | From | To | |
| Extract Method private duplicationLineReader(duplications Duplication...) : DuplicationLineReader extracted from public read_duplication_with_duplicates_on_same_file() : void in class org.sonar.server.computation.source.DuplicationLineReaderTest | From | To | |
| Extract Method private duplicationLineReader(duplications Duplication...) : DuplicationLineReader extracted from public should_be_sorted_by_line_block() : void in class org.sonar.server.computation.source.DuplicationLineReaderTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type reportReader : BatchReportReaderRule to duplicationRepository : DuplicationRepositoryRule in class org.sonar.server.computation.step.PersistDuplicationsStepTest | From | To | |
| Change Attribute Type reportReader : BatchReportReader to duplicationRepository : DuplicationRepository in class org.sonar.server.computation.step.PersistDuplicationsStep | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter reportReader : BatchReportReader to duplicationRepository : DuplicationRepository in method public PersistDuplicationsStep(dbClient DbClient, dbIdsRepository DbIdsRepository, treeRootHolder ReportTreeRootHolder, duplicationRepository DuplicationRepository) in class org.sonar.server.computation.step.PersistDuplicationsStep | From | To | |
| Rename Parameter range : BatchReport.TextRange to textBlock : TextBlock in method private appendDuplication(xml StringBuilder, componentKey String, textBlock TextBlock) : void in class org.sonar.server.computation.step.PersistDuplicationsStep.DuplicationVisitor | From | To |