1e663e71492dc7a9a1d9bd1a33e22b34545748e0
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 9 | ||
Rename Method public select_groups_by_query_does_not_return_anyone_when_group_roles_is_empty() : void renamed to public selectGroupNamesByQuery_does_not_return_anyone_when_group_roles_is_empty() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Method public select_group_permissions_by_group_names_on_global_permissions() : void renamed to public selectByGroupIds_on_global_permissions() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Method public selectByNames(session DbSession, names Collection<String>) : List<GroupDto> renamed to public selectByIds(dbSession DbSession, ids List<Long>) : List<GroupDto> in class org.sonar.db.user.GroupDao | From | To | |
Rename Method public countGroupsByPermissionQuery(dbSession DbSession, query PermissionQuery) : int renamed to public countGroupsByQuery(dbSession DbSession, organizationUuid String, query PermissionQuery) : int in class org.sonar.db.permission.GroupPermissionDao | From | To | |
Rename Method public select_groups_by_query_with_global_permission() : void renamed to public selectGroupNamesByQuery_with_global_permission() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Method public select_groups_by_query_paginated() : void renamed to public selectGroupNamesByQuery_is_paginated() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Method public selectGroupNamesByPermissionQuery(dbSession DbSession, query PermissionQuery) : List<String> renamed to public selectGroupNamesByQuery(dbSession DbSession, organizationUuid String, query PermissionQuery) : List<String> in class org.sonar.db.permission.GroupPermissionDao | From | To | |
Rename Method public count_groups_by_query() : void renamed to public countGroupsByQuery() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Method public select_group_permissions_by_group_names_on_project_permissions() : void renamed to public selectByGroupIds_on_projects() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type names : Collection<String> to ids : List<Long> in method public selectByIds(dbSession DbSession, ids List<Long>) : List<GroupDto> in class org.sonar.db.user.GroupDao | From | To | |
Rename Variable | 1 | ||
Rename Variable names : List<String> to ids : List<Long> in method private findGroupPermissions(dbSession DbSession, org OrganizationDto, groups List<GroupDto>, project Optional<ProjectId>) : List<GroupPermissionDto> in class org.sonar.server.permission.ws.GroupsAction | From | To | |
Change Variable Type | 1 | ||
Change Variable Type names : List<String> to ids : List<Long> in method private findGroupPermissions(dbSession DbSession, org OrganizationDto, groups List<GroupDto>, project Optional<ProjectId>) : List<GroupPermissionDto> in class org.sonar.server.permission.ws.GroupsAction | From | To | |
Extract Method | 12 | ||
Extract Method private addGroupOnDefaultOrganization(name String) : GroupDto extracted from public count_groups_by_query() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Extract Method private addGroupOnDefaultOrganization(name String) : GroupDto extracted from public select_group_permissions_by_group_names_on_global_permissions() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Extract Method private addGroupOnDefaultOrganization(name String) : GroupDto extracted from public select_groups_by_query_with_global_permission() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Extract Method private addGroupOnDefaultOrganization(name String) : GroupDto extracted from public select_group_permissions_by_group_names_on_project_permissions() : void in class org.sonar.db.permission.GroupPermissionDaoTest | From | To | |
Rename Parameter | 2 | ||
Rename Parameter names : Collection<String> to ids : List<Long> in method public selectByIds(dbSession DbSession, ids List<Long>) : List<GroupDto> in class org.sonar.db.user.GroupDao | From | To | |
Rename Parameter session : DbSession to dbSession : DbSession in method public selectByIds(dbSession DbSession, ids List<Long>) : List<GroupDto> in class org.sonar.db.user.GroupDao | From | To |