25e95eda0c4c00bf5a92543db8b5e990f901d117
Files Diff
- Added: 5
- Removed: 3
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public return_403_if_user_is_not_allowed_to_access_project() : void renamed to public fail_if_user_is_not_allowed_to_access_project() : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Rename Method public return_404_if_file_does_not_exist() : void renamed to public fail_if_file_does_not_exist() : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Rename Method private writeDuplication(refByComponentKey Map<String,String>, duplication DuplicationsParser.Duplication, json JsonWriter) : void renamed to private toWsBlock(refByComponentKey Map<String,String>, duplication DuplicationsParser.Duplication) : Block.Builder in class org.sonar.server.duplication.ws.ShowResponseBuilder | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type requestFactory : Function<ComponentDto,WsTester.TestRequest> to requestFactory : Function<ComponentDto,TestRequest> in method private verifyCallToFileWithDuplications(requestFactory Function<ComponentDto,TestRequest>) : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Change Parameter Type duplicationsJsonWriter : DuplicationsJsonWriter to responseBuilder : ShowResponseBuilder in method public ShowAction(dbClient DbClient, parser DuplicationsParser, responseBuilder ShowResponseBuilder, userSession UserSession, componentFinder ComponentFinder) in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to Block.Builder in method private toWsBlock(refByComponentKey Map<String,String>, duplication DuplicationsParser.Duplication) : Block.Builder in class org.sonar.server.duplication.ws.ShowResponseBuilder | From | To | |
| Change Return Type WsTester.TestRequest to TestRequest in method private newBaseRequest() : TestRequest in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private organization : OrganizationDto in class org.sonar.server.duplication.ws.ShowResponseBuilderTest | From | To | |
| Rename Class | 2 | ||
| Rename Class org.sonar.server.duplication.ws.DuplicationsJsonWriter renamed to org.sonar.server.duplication.ws.ShowResponseBuilder | From | To | |
| Rename Class org.sonar.server.duplication.ws.DuplicationsJsonWriterTest renamed to org.sonar.server.duplication.ws.ShowResponseBuilderTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute duplicationsJsonWriter : DuplicationsJsonWriter to responseBuilder : ShowResponseBuilder in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Rename Attribute session : DbSession to dbSession : DbSession in class org.sonar.server.duplication.ws.ShowResponseBuilderTest | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type request : WsTester.TestRequest to request : TestRequest in method public get_duplications_by_file_key() : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Change Variable Type request : WsTester.TestRequest to request : TestRequest in method public get_duplications_by_file_id() : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Change Variable Type request : WsTester.TestRequest to request : TestRequest in method private verifyCallToFileWithDuplications(requestFactory Function<ComponentDto,TestRequest>) : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Change Variable Type result : WsTester.Result to result : TestResponse in method private verifyCallToFileWithDuplications(requestFactory Function<ComponentDto,TestRequest>) : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Change Variable Type result : WsTester.Result to result : TestResponse in method public return_file_with_missing_duplication_data() : void in class org.sonar.server.duplication.ws.ShowActionTest | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.sonar.server.duplication.ws.DuplicationsWsAction from classes [org.sonar.server.duplication.ws.ShowAction] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type duplicationsJsonWriter : DuplicationsJsonWriter to responseBuilder : ShowResponseBuilder in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter duplicationsJsonWriter : DuplicationsJsonWriter to responseBuilder : ShowResponseBuilder in method public ShowAction(dbClient DbClient, parser DuplicationsParser, responseBuilder ShowResponseBuilder, userSession UserSession, componentFinder ComponentFinder) in class org.sonar.server.duplication.ws.ShowAction | From | To |