43e4f60243539bdbcfdcefea14774ee1e108fc1a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type qualityGates : QualityGates to qualityGateFinder : QualityGateFinder in method public RegisterQualityGates(dbClient DbClient, qualityGateUpdater QualityGateUpdater, qualityGateConditionsUpdater QualityGateConditionsUpdater, qualityGateFinder QualityGateFinder, system2 System2) in class org.sonar.server.qualitygate.RegisterQualityGates | From | To | |
| Rename Variable | 1 | ||
| Rename Variable defaultQgate : PropertyDto to defaultQualityGateId : PropertyDto in method private getDefaultId(dbSession DbSession) : Optional<Long> in class org.sonar.server.qualitygate.QualityGateFinder | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Long to Optional<Long> in method private getDefaultId(dbSession DbSession) : Optional<Long> in class org.sonar.server.qualitygate.QualityGateFinder | From | To | |
| Extract Attribute | 2 | ||
| Extract Attribute private qualityGateDao : QualityGateDao in class org.sonar.server.qualitygate.RegisterQualityGatesTest | From | To | |
| Extract Attribute private gateConditionDao : QualityGateConditionDao in class org.sonar.server.qualitygate.RegisterQualityGatesTest | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute qualityGates : QualityGates to qualityGateFinder : QualityGateFinder in class org.sonar.server.qualitygate.RegisterQualityGates | From | To | |
| Rename Attribute task : RegisterQualityGates to underTest : RegisterQualityGates in class org.sonar.server.qualitygate.RegisterQualityGatesTest | From | To | |
| Rename Attribute loadedTemplateDao : LoadedTemplateDao to qualityGateDao : QualityGateDao in class org.sonar.server.qualitygate.RegisterQualityGates | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type defaultQualityGate : QualityGateDto to defaultQualityGate : Optional<QualityGateDto> in method public getQualityGate(dbSession DbSession, componentId long) : Optional<QualityGateData> in class org.sonar.server.qualitygate.QualityGateFinder | From | To | |
| Split Attribute | 1 | ||
| Split Attribute dbClient : DbClient to [qualityGateDao : QualityGateDao, gateConditionDao : QualityGateConditionDao] in class org.sonar.server.qualitygate.RegisterQualityGatesTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private verifyCorrectBuiltInQualityGate() : void extracted from public register_default_gate() : void in class org.sonar.server.qualitygate.RegisterQualityGatesTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type qualityGates : QualityGates to qualityGateFinder : QualityGateFinder in class org.sonar.server.qualitygate.RegisterQualityGates | From | To | |
| Change Attribute Type loadedTemplateDao : LoadedTemplateDao to qualityGateDao : QualityGateDao in class org.sonar.server.qualitygate.RegisterQualityGates | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter qualityGates : QualityGates to qualityGateFinder : QualityGateFinder in method public RegisterQualityGates(dbClient DbClient, qualityGateUpdater QualityGateUpdater, qualityGateConditionsUpdater QualityGateConditionsUpdater, qualityGateFinder QualityGateFinder, system2 System2) in class org.sonar.server.qualitygate.RegisterQualityGates | From | To |