sonarqube 4411bd57b286b519f13017d061539b9789ae0f83

4411bd57b286b519f13017d061539b9789ae0f83

Files Diff

Added: 12
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	1
Move And Inline Method public debt() : Duration moved from class org.sonar.server.issue.notification.NewIssuesStatistics to class org.sonar.server.computation.step.SendIssueNotificationsStep & inlined to private sendNewIssuesStatistics(context ComputationContext, statistics NewIssuesStatistics) : void	From	To
Change Parameter Type	4
Change Parameter Type debt : String to debt : Duration in method public setDebt(debt Duration) : NewIssuesNotification in class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Change Parameter Type stats : NewIssuesStatistics to stats : NewIssuesStatistics.Stats in method protected setSeverityStatistics(stats NewIssuesStatistics.Stats) : void in class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Change Parameter Type stats : NewIssuesStatistics to stats : NewIssuesStatistics.Stats in method protected setTagsStatistics(stats NewIssuesStatistics.Stats) : void in class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Change Parameter Type durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in method public SendIssueNotificationsStep(issueCache IssueCache, rules RuleCache, service NotificationService, newIssuesNotificationFactory NewIssuesNotificationFactory) in class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Move Method	3
Move Method public statsForMetric(metric METRIC) : List<Multiset.Entry<String>> from class org.sonar.server.issue.notification.NewIssuesStatistics to public statsForMetric(metric METRIC) : List<Multiset.Entry<String>> from class org.sonar.server.issue.notification.NewIssuesStatistics.Stats	From	To
Move Method public countForMetric(metric METRIC) : int from class org.sonar.server.issue.notification.NewIssuesStatistics to public countForMetric(metric METRIC) : int from class org.sonar.server.issue.notification.NewIssuesStatistics.Stats	From	To
Move Method public countForMetric(metric METRIC, label String) : int from class org.sonar.server.issue.notification.NewIssuesStatistics to public countForMetric(metric METRIC, label String) : int from class org.sonar.server.issue.notification.NewIssuesStatistics.Stats	From	To
Pull Up Attribute	11
Pull Up Attribute private LABEL : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected LABEL : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private NEW_LINE : char from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected NEW_LINE : char from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute public FIELD_PROJECT_UUID : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package FIELD_PROJECT_UUID : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute public FIELD_PROJECT_DATE : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package FIELD_PROJECT_DATE : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute public FIELD_PROJECT_NAME : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package FIELD_PROJECT_NAME : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute public FIELD_PROJECT_KEY : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package FIELD_PROJECT_KEY : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private COUNT : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected COUNT : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private settings : EmailSettings from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected settings : EmailSettings from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private DOT : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected DOT : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private TAB : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected TAB : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Attribute private i18n : I18n from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected i18n : I18n from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Move Attribute	7
Move Attribute private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesNotificationFactory	From	To
Move Attribute private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package userIndex : UserIndex from class org.sonar.server.issue.notification.MyNewIssuesEmailTemplateTest	From	To
Move Attribute private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Move Attribute private userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to package userIndex : UserIndex from class org.sonar.server.issue.notification.NewIssuesNotificationTest	From	To
Move Attribute private durations : Durations from class org.sonar.server.computation.step.SendIssueNotificationsStep to private durations : Durations from class org.sonar.server.issue.notification.NewIssuesNotificationFactory	From	To
Move Attribute package durations : Durations from class org.sonar.server.computation.step.SendIssueNotificationsStepTest to private durations : Durations from class org.sonar.server.issue.notification.NewIssuesNotificationFactory	From	To
Move Attribute package durations : Durations from class org.sonar.server.computation.step.SendIssueNotificationsStepTest to private durations : Durations from class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Extract Class	1
Extract Class org.sonar.server.issue.notification.NewIssuesNotificationFactory from class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Extract Method	6
Extract Method private genericAppendOfMetric(metric METRIC, label String, message StringBuilder, notification Notification) : void extracted from private appendComponents(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Extract Method private doNotHaveValue(notification Notification, metric METRIC) : boolean extracted from private appendTags(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Extract Method private genericAppendOfMetric(metric METRIC, label String, message StringBuilder, notification Notification) : void extracted from private appendTags(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Extract Method private doNotHaveValue(notification Notification, metric METRIC) : boolean extracted from private appendAssignees(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Extract Method private doNotHaveValue(notification Notification, metric METRIC) : boolean extracted from private appendComponents(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Extract Method private genericAppendOfMetric(metric METRIC, label String, message StringBuilder, notification Notification) : void extracted from private appendAssignees(message StringBuilder, notification Notification) : void in class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Rename Method	3
Rename Method private setTop5CountsForMetric(stats NewIssuesStatistics, metric METRIC) : void renamed to protected setTagsStatistics(stats NewIssuesStatistics.Stats) : void in class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Rename Method public shouldNotFormatIfNotCorrectNotification() : void renamed to public no_format_is_not_the_correct_notification() : void in class org.sonar.server.issue.notification.NewIssuesEmailTemplateTest	From	To
Rename Method private statisticsForLogin(login String) : Stats renamed to private getOrCreate(assignee String) : Stats in class org.sonar.server.issue.notification.NewIssuesStatistics	From	To
Push Down Method	1
Push Down Method public NewIssuesNotification() from class org.sonar.server.issue.notification.NewIssuesNotification to package MyNewIssuesNotification(userIndex UserIndex, dbClient DbClient, durations Durations) from class org.sonar.server.issue.notification.MyNewIssuesNotification	From	To
Pull Up Method	8
Pull Up Method public encode(toEncode String) : String from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to public encode(toEncode String) : String from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private appendFooter(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected appendFooter(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private appendSeverity(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected appendSeverity(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private getLocale() : Locale from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to private getLocale() : Locale from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private appendComponents(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected appendComponents(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method public format(notification Notification) : EmailMessage from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to public format(notification Notification) : EmailMessage from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private appendAssignees(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected appendAssignees(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Pull Up Method private appendTags(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.NewIssuesEmailTemplate to protected appendTags(message StringBuilder, notification Notification) : void from class org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate	From	To
Rename Variable	1
Rename Variable loginStats : List<Multiset.Entry<String>> to metricStats : List<Multiset.Entry<String>> in method protected setTagsStatistics(stats NewIssuesStatistics.Stats) : void in class org.sonar.server.issue.notification.NewIssuesNotification	From	To
Extract Superclass	1
Extract Superclass org.sonar.server.issue.notification.AbstractNewIssuesEmailTemplate from classes [org.sonar.server.issue.notification.NewIssuesEmailTemplate]	From	To
Rename Attribute	4
Rename Attribute durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in class org.sonar.server.computation.step.SendIssueNotificationsStepTest	From	To
Rename Attribute computeDistribution : boolean to isComputedByDistribution : boolean in class org.sonar.server.issue.notification.NewIssuesStatistics.METRIC	From	To
Rename Attribute statisticsByLogin : Map<String,Stats> to assigneesStatistics : Map<String,Stats> in class org.sonar.server.issue.notification.NewIssuesStatistics	From	To
Rename Attribute durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Change Attribute Type	3
Change Attribute Type stats : NewIssuesStatistics to stats : NewIssuesStatistics.Stats in class org.sonar.server.issue.notification.NewIssuesNotificationTest	From	To
Change Attribute Type durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Change Attribute Type durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in class org.sonar.server.computation.step.SendIssueNotificationsStepTest	From	To
Rename Parameter	4
Rename Parameter login : String to assignee : String in method private getOrCreate(assignee String) : Stats in class org.sonar.server.issue.notification.NewIssuesStatistics	From	To
Rename Parameter stats : NewIssuesStatistics to statistics : NewIssuesStatistics in method private sendNewIssuesStatistics(context ComputationContext, statistics NewIssuesStatistics) : void in class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Rename Parameter computeDistribution : boolean to isComputedByDistribution : boolean in method package METRIC(isComputedByDistribution boolean) in class org.sonar.server.issue.notification.NewIssuesStatistics.METRIC	From	To
Rename Parameter durations : Durations to newIssuesNotificationFactory : NewIssuesNotificationFactory in method public SendIssueNotificationsStep(issueCache IssueCache, rules RuleCache, service NotificationService, newIssuesNotificationFactory NewIssuesNotificationFactory) in class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To

4411bd57b286b519f13017d061539b9789ae0f83

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: