44a34aca80bb01c3a7689fe02d34f17718bf9293
Files Diff
- Added: 10
- Removed: 18
- Renamed: 0
- Modified: 62
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 6 | ||
| Move And Rename Method public setRuleKey(value String) : Builder from class org.sonar.batch.protocol.output.BatchReport.Measure.Builder to public setActiveRuleKey(index int, value String) : Builder from class org.sonar.batch.protocol.output.BatchReport.Metadata.Builder | From | To | |
| Move And Rename Method private exportMetadata(writer BatchReportWriter) : void from class org.sonar.batch.report.IssuesPublisher to public publish(writer BatchReportWriter) : void from class org.sonar.batch.report.MetadataPublisher | From | To | |
| Move And Rename Method public setAlertTextBytes(value ByteString) : Builder from class org.sonar.batch.protocol.output.BatchReport.Measure.Builder to public addActiveRuleKeyBytes(value ByteString) : Builder from class org.sonar.batch.protocol.output.BatchReport.Metadata.Builder | From | To | |
| Move And Rename Method public clearRuleKey() : Builder from class org.sonar.batch.protocol.output.BatchReport.Measure.Builder to public clearActiveRuleKey() : Builder from class org.sonar.batch.protocol.output.BatchReport.Metadata.Builder | From | To | |
| Move And Rename Method public setRuleKeyBytes(value ByteString) : Builder from class org.sonar.batch.protocol.output.BatchReport.Measure.Builder to public addActiveRuleKey(value String) : Builder from class org.sonar.batch.protocol.output.BatchReport.Metadata.Builder | From | To | |
| Move And Rename Method public publishMetadataWithBranch() : void from class org.sonar.batch.report.IssuesPublisherTest to public write_metadata() : void from class org.sonar.batch.report.MetadataPublisherTest | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type listeners : IssueListener[] to visitors : IssueVisitor[] in method public IssueVisitors(visitors IssueVisitor[]) in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Change Parameter Type issueListeners : IssueListeners to issueVisitors : IssueVisitors in method public IntegrateIssuesStep(treeRootHolder TreeRootHolder, tracker TrackerExecution, issueCache IssueCache, baseIssuesLoader BaseIssuesLoader, issueLifecycle IssueLifecycle, issueVisitors IssueVisitors) in class org.sonar.server.computation.step.IntegrateIssuesStep | From | To | |
| Change Parameter Type value : ByteString to value : String in method public addActiveRuleKey(value String) : Builder in class org.sonar.batch.protocol.output.BatchReport.Metadata.Builder | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private reactor : ImmutableProjectReactor from class org.sonar.batch.report.IssuesPublisher to private reactor : ImmutableProjectReactor from class org.sonar.batch.report.MetadataPublisher | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute public NOW : long in class org.sonar.server.computation.step.PersistIssuesStepTest | From | To | |
| Rename Class | 5 | ||
| Rename Class org.sonar.server.computation.issue.IssueListeners renamed to org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Rename Class org.sonar.server.computation.issue.DebtCalculator renamed to org.sonar.server.computation.issue.DebtAggregator | From | To | |
| Rename Class org.sonar.server.computation.issue.IssueListener renamed to org.sonar.server.computation.issue.IssueVisitor | From | To | |
| Rename Class org.sonar.server.computation.issue.CountIssuesListener renamed to org.sonar.server.computation.issue.IssueCounter | From | To | |
| Rename Class org.sonar.core.issue.tracking.Tracker.LineHashAndMessagekeyFactory renamed to org.sonar.core.issue.tracking.Tracker.LineHashAndMessageKeyFactory | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type listener : IssueListener to visitor : IssueVisitor in method public beforeComponent(component Component, tracking Tracking) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Change Variable Type listener : IssueListener to visitor : IssueVisitor in method public onIssue(component Component, issue DefaultIssue) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Change Variable Type listener : IssueListener to visitor : IssueVisitor in method public afterComponent(component Component) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Extract Variable | 2 | ||
| Extract Variable subCharacteristicId : Integer in method package add(issue DefaultIssue) : void from class org.sonar.server.computation.issue.DebtAggregator.Debt | From | To | |
| Extract Variable dto : IssueDto in method public execute() : void from class org.sonar.server.computation.step.PersistIssuesStep | From | To | |
| Rename Method | 4 | ||
| Rename Method public publishIssuesAndMetadata() : void renamed to public write_issues() : void in class org.sonar.batch.report.IssuesPublisherTest | From | To | |
| Rename Method protected abstract loadSourceLines() : Iterable<String> renamed to protected abstract loadLineHashSequence() : LineHashSequence in class org.sonar.core.issue.tracking.LazyInput | From | To | |
| Rename Method public fail_if_raw_line_does_not_exist() : void renamed to public do_not_fail_if_raw_line_does_not_exist() : void in class org.sonar.core.issue.tracking.TrackerTest | From | To | |
| Rename Method protected loadSourceLines() : Iterable<String> renamed to protected loadLineHashSequence() : LineHashSequence in class org.sonar.server.computation.issue.TrackerBaseInputFactory.BaseLazyInput | From | To | |
| Rename Variable | 3 | ||
| Rename Variable listener : IssueListener to visitor : IssueVisitor in method public afterComponent(component Component) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Rename Variable listener : IssueListener to visitor : IssueVisitor in method public onIssue(component Component, issue DefaultIssue) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Rename Variable listener : IssueListener to visitor : IssueVisitor in method public beforeComponent(component Component, tracking Tracking) : void in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Inline Method | 1 | ||
| Inline Method private createBuilder(batchMeasure BatchReport.Measure) : Measure.NewMeasureBuilder inlined to public toMeasure(batchMeasure BatchReport.Measure, metric Metric) : Optional<Measure> in class org.sonar.server.computation.measure.BatchMeasureToMeasure | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Iterable<String> to List<String> in method public selectLineHashes(dbSession DbSession, fileUuid String) : List<String> in class org.sonar.server.source.db.FileSourceDao | From | To | |
| Change Return Type Iterable<String> to LineHashSequence in method protected abstract loadLineHashSequence() : LineHashSequence in class org.sonar.core.issue.tracking.LazyInput | From | To | |
| Change Return Type Iterable<String> to LineHashSequence in method protected loadLineHashSequence() : LineHashSequence in class org.sonar.server.computation.issue.TrackerBaseInputFactory.BaseLazyInput | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute listeners : IssueListener[] to visitors : IssueVisitor[] in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Rename Attribute publisher : IssuesPublisher to underTest : IssuesPublisher in class org.sonar.batch.report.IssuesPublisherTest | From | To | |
| Rename Attribute p : Project to project : Project in class org.sonar.batch.report.IssuesPublisherTest | From | To | |
| Rename Attribute root : ProjectDefinition to projectDef : ProjectDefinition in class org.sonar.batch.report.IssuesPublisherTest | From | To | |
| Rename Attribute issueListeners : IssueListeners to issueVisitors : IssueVisitors in class org.sonar.server.computation.step.IntegrateIssuesStep | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type issueListeners : IssueListeners to issueVisitors : IssueVisitors in class org.sonar.server.computation.step.IntegrateIssuesStep | From | To | |
| Change Attribute Type listeners : IssueListener[] to visitors : IssueVisitor[] in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Change Attribute Type sut : CountIssuesListener to sut : IssueCounter in class org.sonar.server.computation.issue.CountIssuesListenerTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter listeners : IssueListener[] to visitors : IssueVisitor[] in method public IssueVisitors(visitors IssueVisitor[]) in class org.sonar.server.computation.issue.IssueVisitors | From | To | |
| Rename Parameter issueListeners : IssueListeners to issueVisitors : IssueVisitors in method public IntegrateIssuesStep(treeRootHolder TreeRootHolder, tracker TrackerExecution, issueCache IssueCache, baseIssuesLoader BaseIssuesLoader, issueLifecycle IssueLifecycle, issueVisitors IssueVisitors) in class org.sonar.server.computation.step.IntegrateIssuesStep | From | To |