453dcdb5e93a05e550094194bead446ac2247361
Files Diff
- Added: 7
- Removed: 9
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public cancel_task_if_report_file_is_missing() : void renamed to private insertTaskData(taskUuid String) : void in class org.sonar.server.computation.queue.CeQueueCleanerTest | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type params : String... to params : Object... in method public executeUpdateSql(sql String, params Object...) : void in class org.sonar.db.DbTester | From | To | |
| Change Parameter Type values : String... to values : Object... in method private mapOf(firstColumn String, values Object...) : Map<String,Object> in class org.sonar.db.DbTester | From | To | |
| Change Parameter Type valuesByColumn : Map<String,String> to valuesByColumn : Map<String,Object> in method public executeInsert(table String, valuesByColumn Map<String,Object>) : void in class org.sonar.db.DbTester | From | To | |
| Change Parameter Type reportFiles : ReportFiles to dbClient : DbClient in method public ExtractReportStep(dbClient DbClient, task CeTask, tempFolder TempFolder, reportDirectoryHolder MutableBatchReportDirectoryHolder) in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStep | From | To | |
| Inline Method | 1 | ||
| Inline Method private insertInQueue(taskUuid String, status CeQueueDto.Status, createFile boolean) : CeQueueDto inlined to private insertInQueue(taskUuid String, status CeQueueDto.Status) : CeQueueDto in class org.sonar.server.computation.queue.CeQueueCleanerTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable queueDto : CeQueueDto to dto : CeQueueDto in method private insertInQueue(taskUuid String, status CeQueueDto.Status) : CeQueueDto in class org.sonar.server.computation.queue.CeQueueCleanerTest | From | To | |
| Rename Variable dir : File to unzippedDir : File in method public execute() : void in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStep | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to CeQueueDto in method private insertInQueue(taskUuid String, status CeQueueDto.Status) : CeQueueDto in class org.sonar.server.computation.queue.CeQueueCleanerTest | From | To | |
| Change Return Type Map<String,String> to Map<String,Object> in method private mapOf(firstColumn String, values Object...) : Map<String,Object> in class org.sonar.db.DbTester | From | To | |
| Move Class | 2 | ||
| Move Class org.sonar.ce.queue.report.ReportSubmitterTest moved to org.sonar.server.computation.queue.ReportSubmitterTest | From | To | |
| Move Class org.sonar.ce.queue.report.ReportSubmitter moved to org.sonar.server.computation.queue.ReportSubmitter | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute reportFiles : ReportFiles to dbClient : DbClient in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStep | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type builder : ImmutableMap.Builder<String,String> to builder : ImmutableMap.Builder<String,Object> in method private mapOf(firstColumn String, values Object...) : Map<String,Object> in class org.sonar.db.DbTester | From | To | |
| Change Package | 1 | ||
| Change Package org.sonar.ce.queue.report to org.sonar.server.computation.queue | From | To | |
| Extract Method | 1 | ||
| Extract Method private generateReport() : File extracted from public unzip_report() : void in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStepTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type reportFiles : ReportFiles to dbClient : DbClient in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStep | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter reportFiles : ReportFiles to dbClient : DbClient in method public ExtractReportStep(dbClient DbClient, task CeTask, tempFolder TempFolder, reportDirectoryHolder MutableBatchReportDirectoryHolder) in class org.sonar.server.computation.task.projectanalysis.step.ExtractReportStep | From | To |