465047d8b497de79ff636e98dab0e34a6edf6257
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public redirect_to_requested_page_doesnt_need_context() : void renamed to public redirect_to_requested_page_does_not_need_context() : void in class org.sonar.server.authentication.OAuth2ContextFactoryTest | From | To | |
| Rename Method private verifyDeleteRedirection() : void renamed to private verifyDeleteAuthCookie() : void in class org.sonar.server.authentication.InitFilterTest | From | To | |
| Rename Method public fail_to_authenticate_new_user_when_email_already_exists() : void renamed to public throw_AuthenticationException_when_authenticating_new_user_when_email_already_exists_and_strategy_is_FORBID() : void in class org.sonar.server.authentication.UserIdentityAuthenticatorTest | From | To | |
| Rename Method private register(user UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source) : UserDto renamed to public authenticate(user UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : UserDto in class org.sonar.server.authentication.UserIdentityAuthenticator | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public init(context InitContext) : void from class org.sonar.server.authentication.OAuth2CallbackFilterTest.FailWithIllegalStateException to public init(context InitContext) : void from class org.sonar.server.authentication.OAuth2CallbackFilterTest.FailingIdentityProvider | From | To | |
| Pull Up Method public init(context InitContext) : void from class org.sonar.server.authentication.OAuth2CallbackFilterTest.FailWithUnauthorizedExceptionIdProvider to public init(context InitContext) : void from class org.sonar.server.authentication.OAuth2CallbackFilterTest.FailingIdentityProvider | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type oAuthRedirection : OAuth2Redirection to oAuthParameters : OAuth2AuthenticationParameters in method public OAuth2ContextFactory(threadLocalUserSession ThreadLocalUserSession, userIdentityAuthenticator UserIdentityAuthenticator, server Server, csrfVerifier OAuthCsrfVerifier, jwtHttpHandler JwtHttpHandler, userSessionFactory UserSessionFactory, oAuthParameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Change Parameter Type oAuthRedirection : OAuth2Redirection to oauth2Parameters : OAuth2AuthenticationParameters in method public OAuth2CallbackFilter(identityProviderRepository IdentityProviderRepository, oAuth2ContextFactory OAuth2ContextFactory, server Server, authenticationEvent AuthenticationEvent, oauth2Parameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Change Parameter Type oAuthRedirection : OAuth2Redirection to oAuthOAuth2AuthenticationParameters : OAuth2AuthenticationParameters in method public InitFilter(identityProviderRepository IdentityProviderRepository, baseContextFactory BaseContextFactory, oAuth2ContextFactory OAuth2ContextFactory, server Server, authenticationEvent AuthenticationEvent, oAuthOAuth2AuthenticationParameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.InitFilter | From | To | |
| Move Method | 2 | ||
| Move Method private redirectTo(response HttpServletResponse, url String) : void from class org.sonar.server.authentication.AuthenticationError to package redirectTo(response HttpServletResponse, url String) : void from class org.sonar.server.authentication.AuthenticationRedirection | From | To | |
| Move Method private encodeMessage(message String) : String from class org.sonar.server.authentication.AuthenticationError to package encodeMessage(message String) : String from class org.sonar.server.authentication.AuthenticationRedirection | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonar.server.authentication.AuthenticationRedirection from class org.sonar.server.authentication.AuthenticationError | From | To | |
| Rename Class | 1 | ||
| Rename Class org.sonar.server.authentication.OAuth2Redirection renamed to org.sonar.server.authentication.OAuth2AuthenticationParameters | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.sonar.server.authentication.OAuth2CallbackFilterTest.FailingIdentityProvider from classes [org.sonar.server.authentication.OAuth2CallbackFilterTest.FailWithUnauthorizedExceptionIdProvider, org.sonar.server.authentication.OAuth2CallbackFilterTest.FailWithIllegalStateException] | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute oAuthRedirection : OAuth2Redirection to oAuthParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Rename Attribute oAuthRedirection : OAuth2Redirection to oAuthOAuth2AuthenticationParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.InitFilter | From | To | |
| Rename Attribute oAuthRedirection : OAuth2Redirection to oauth2Parameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Rename Attribute oAuthRedirection : OAuth2Redirection to auth2AuthenticationParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.InitFilterTest | From | To | |
| Rename Attribute thrown : ExpectedException to expectedException : ExpectedException in class org.sonar.server.authentication.UserIdentityAuthenticatorTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable userLogin : String in method private registerNewUser(dbSession DbSession, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticator | From | To | |
| Extract Method | 1 | ||
| Extract Method private validateEmail(dbSession DbSession, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : Optional<UserDto> extracted from private registerNewUser(dbSession DbSession, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source) : UserDto in class org.sonar.server.authentication.UserIdentityAuthenticator | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type oAuthRedirection : OAuth2Redirection to oAuthOAuth2AuthenticationParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.InitFilter | From | To | |
| Change Attribute Type oAuthRedirection : OAuth2Redirection to oauth2Parameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Change Attribute Type oAuthRedirection : OAuth2Redirection to auth2AuthenticationParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.InitFilterTest | From | To | |
| Change Attribute Type oAuthRedirection : OAuth2Redirection to oAuthRedirection : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2CallbackFilterTest | From | To | |
| Change Attribute Type oAuthRedirection : OAuth2Redirection to oAuthParameters : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter oAuthRedirection : OAuth2Redirection to oAuthParameters : OAuth2AuthenticationParameters in method public OAuth2ContextFactory(threadLocalUserSession ThreadLocalUserSession, userIdentityAuthenticator UserIdentityAuthenticator, server Server, csrfVerifier OAuthCsrfVerifier, jwtHttpHandler JwtHttpHandler, userSessionFactory UserSessionFactory, oAuthParameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Rename Parameter oAuthRedirection : OAuth2Redirection to oauth2Parameters : OAuth2AuthenticationParameters in method public OAuth2CallbackFilter(identityProviderRepository IdentityProviderRepository, oAuth2ContextFactory OAuth2ContextFactory, server Server, authenticationEvent AuthenticationEvent, oauth2Parameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Rename Parameter oAuthRedirection : OAuth2Redirection to oAuthOAuth2AuthenticationParameters : OAuth2AuthenticationParameters in method public InitFilter(identityProviderRepository IdentityProviderRepository, baseContextFactory BaseContextFactory, oAuth2ContextFactory OAuth2ContextFactory, server Server, authenticationEvent AuthenticationEvent, oAuthOAuth2AuthenticationParameters OAuth2AuthenticationParameters) in class org.sonar.server.authentication.InitFilter | From | To |