4beb2af88d3e1378d19bbaec1859c4c59acb6252
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type settingsWsComponentParameters : SettingsWsComponentParameters to componentFinder : ComponentFinder in method public ListDefinitionsAction(dbClient DbClient, componentFinder ComponentFinder, userSession UserSession, propertyDefinitions PropertyDefinitions) in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Change Parameter Type component : ComponentDto to component : Optional<ComponentDto> in method private checkAdminPermission(component Optional<ComponentDto>) : void in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Change Parameter Type request : Request to wsRequest : ListDefinitionsRequest in method private getQualifier(wsRequest ListDefinitionsRequest) : Optional<String> in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Move Method | 1 | ||
| Move Method package checkAdminPermission(component ComponentDto) : void from class org.sonar.server.settings.ws.SettingsWsComponentParameters to private checkAdminPermission(component Optional<ComponentDto>) : void from class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to Optional<String> in method private getQualifier(wsRequest ListDefinitionsRequest) : Optional<String> in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Move Attribute | 4 | ||
| Move Attribute package PARAM_COMPONENT_ID : String from class org.sonar.server.settings.ws.SettingsWsComponentParameters to public PARAM_COMPONENT_ID : String from class org.sonarqube.ws.client.setting.SettingsWsParameters | From | To | |
| Move Attribute private userSession : UserSession from class org.sonar.server.settings.ws.SettingsWsComponentParameters to private userSession : UserSession from class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Move Attribute private componentFinder : ComponentFinder from class org.sonar.server.settings.ws.SettingsWsComponentParameters to private componentFinder : ComponentFinder from class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Move Attribute package PARAM_COMPONENT_KEY : String from class org.sonar.server.settings.ws.SettingsWsComponentParameters to public PARAM_COMPONENT_KEY : String from class org.sonarqube.ws.client.setting.SettingsWsParameters | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonarqube.ws.client.setting.SettingsWsParameters from class org.sonar.server.settings.ws.SettingsWsComponentParameters | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute settingsWsComponentParameters : SettingsWsComponentParameters to componentFinder : ComponentFinder in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type qualifier : String to qualifier : Optional<String> in method private doHandle(request Request) : ListDefinitionsWsResponse in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type settingsWsComponentParameters : SettingsWsComponentParameters to componentFinder : ComponentFinder in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter request : Request to wsRequest : ListDefinitionsRequest in method private getQualifier(wsRequest ListDefinitionsRequest) : Optional<String> in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To | |
| Rename Parameter settingsWsComponentParameters : SettingsWsComponentParameters to componentFinder : ComponentFinder in method public ListDefinitionsAction(dbClient DbClient, componentFinder ComponentFinder, userSession UserSession, propertyDefinitions PropertyDefinitions) in class org.sonar.server.settings.ws.ListDefinitionsAction | From | To |