4da794930af2336e2802aa5d778aa091d646f016
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 8 | ||
| Rename Method private validateId(id String) : void renamed to private validateLogin(login String) : void in class org.sonar.api.server.authentication.UserIdentity.Builder | From | To | |
| Rename Method public fail_when_id_is_loo_long() : void renamed to public fail_when_login_is_too_long() : void in class org.sonar.api.server.authentication.UserIdentityTest | From | To | |
| Rename Method public fail_when_id_is_null() : void renamed to public fail_when_login_is_empty() : void in class org.sonar.api.server.authentication.UserIdentityTest | From | To | |
| Rename Method public reactivate_user_when_creating_user_with_existing_login_and_with_authority() : void renamed to public reactivate_user_when_creating_user_with_existing_login() : void in class org.sonar.server.user.UserUpdaterTest | From | To | |
| Rename Method public getId() : String renamed to public getLogin() : String in class org.sonar.api.server.authentication.UserIdentity | From | To | |
| Rename Method public setId(id String) : Builder renamed to public setLogin(login String) : Builder in class org.sonar.api.server.authentication.UserIdentity.Builder | From | To | |
| Rename Method public fail_when_id_is_empty() : void renamed to public fail_when_provider_login_is_null() : void in class org.sonar.api.server.authentication.UserIdentityTest | From | To | |
| Rename Method public fail_when_id_is_loo_small() : void renamed to public fail_when_login_is_too_small() : void in class org.sonar.api.server.authentication.UserIdentityTest | From | To | |
| Move Method | 2 | ||
| Move Method public fail_with_NPE_when_identity_id_is_null() : void from class org.sonar.server.user.NewUserTest to public fail_with_NPE_when_identity_id_is_null() : void from class org.sonar.server.user.ExternalIdentityTest | From | To | |
| Move Method public fail_with_NPE_when_identity_provider_is_null() : void from class org.sonar.server.user.NewUserTest to public fail_with_NPE_when_identity_provider_is_null() : void from class org.sonar.server.user.ExternalIdentityTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable userId : String to userLogin : String in method private register(user UserIdentity, provider IdentityProvider) : long in class org.sonar.server.authentication.UserIdentityAuthenticator | From | To | |
| Rename Variable newUser : UpdateUser to updateUser : UpdateUser in method public authenticate_existing_user() : void in class org.sonar.server.authentication.UserIdentityAuthenticatorTest | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonar.server.user.ExternalIdentityTest from class org.sonar.server.user.NewUserTest | From | To | |
| Move Class | 1 | ||
| Move Class org.sonar.server.user.NewUser.ExternalIdentity moved to org.sonar.server.user.ExternalIdentity | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable userDto : UserDto to dto : UserDto in method private setExternalIdentity(dto UserDto, externalIdentity ExternalIdentity) : void in class org.sonar.server.user.UserUpdater | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute isEmailChanged : boolean to emailChanged : boolean in class org.sonar.server.user.UpdateUser | From | To | |
| Rename Attribute isNameChanged : boolean to nameChanged : boolean in class org.sonar.server.user.UpdateUser | From | To | |
| Rename Attribute isScmAccountsChanged : boolean to scmAccountsChanged : boolean in class org.sonar.server.user.UpdateUser | From | To | |
| Rename Attribute isPasswordChanged : boolean to passwordChanged : boolean in class org.sonar.server.user.UpdateUser | From | To | |
| Rename Attribute id : String to login : String in class org.sonar.api.server.authentication.UserIdentity | From | To | |
| Rename Attribute id : String to login : String in class org.sonar.api.server.authentication.UserIdentity.Builder | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type existingUser : Optional<UserDto> to existingUser : UserDto in method public create(dbSession DbSession, newUser NewUser) : boolean in class org.sonar.server.user.UserUpdater | From | To | |
| Change Variable Type userDto : Optional<UserDto> to userDto : UserDto in method private register(user UserIdentity, provider IdentityProvider) : long in class org.sonar.server.authentication.UserIdentityAuthenticator | From | To | |
| Extract Method | 1 | ||
| Extract Method private setExternalIdentity(dto UserDto, externalIdentity ExternalIdentity) : void extracted from private createNewUserDto(dbSession DbSession, newUser NewUser) : UserDto in class org.sonar.server.user.UserUpdater | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter id : String to login : String in method public setLogin(login String) : Builder in class org.sonar.api.server.authentication.UserIdentity.Builder | From | To | |
| Rename Parameter id : String to login : String in method private validateLogin(login String) : void in class org.sonar.api.server.authentication.UserIdentity.Builder | From | To |